From: Peter Bergner <bergner@vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH, rs6000] Fix PR84279, powerpc64le ICE on cvc4
Date: Tue, 13 Feb 2018 23:07:00 -0000 [thread overview]
Message-ID: <622b7e77-bfac-7e9d-de9d-5f63e8b6f2c0@vnet.ibm.com> (raw)
In-Reply-To: <20180213223428.GV21977@gate.crashing.org>
On 2/13/18 4:34 PM, Segher Boessenkool wrote:
>> This patch passed bootstrap and retesting on powerpc64le-linux with
>> no regressions. Ok for mainline?
>
> Okay, thanks! Does this need backports?
Committed with your suggested change below. Thanks!
It'd be easy to backport and should be fairly harmless. That said, I was
never able to create a simpler test case, using __builtin_altivec_lvx()
that would end up being re-recog'd as vsx_movv4si_64, so the only way I
know we can hit this is with Kelvin's optimization that replaces aligned
vsx loads/stores with altivec loads/stores and that optimization is only
on trunk.
It's up to you whether you want the backport because you don't trust
me being able to create a failing test case. :-)
>> --- gcc/testsuite/g++.dg/pr84279.C (nonexistent)
>> +++ gcc/testsuite/g++.dg/pr84279.C (working copy)
>> @@ -0,0 +1,35 @@
>> +/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
>
> I don't think this needs lp64?
Yeah, I think you're right. I'll remove it. Thanks.
Peter
next prev parent reply other threads:[~2018-02-13 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 3:34 Peter Bergner
2018-02-13 22:34 ` Segher Boessenkool
2018-02-13 23:07 ` Peter Bergner [this message]
2018-02-13 23:51 ` Segher Boessenkool
2018-02-14 1:12 ` Peter Bergner
2018-02-14 15:19 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622b7e77-bfac-7e9d-de9d-5f63e8b6f2c0@vnet.ibm.com \
--to=bergner@vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).