From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id B2E883858407 for ; Tue, 9 Jan 2024 18:43:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2E883858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2E883858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::136 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704825827; cv=none; b=aeBr83SKmtmF8zvsmfzbC5R//UNcUYdT+B66UTc0V5wA1zlN0EaLlVmTa2kSFfalp1yp2i4GuN6XoGJrE8cCbWBr23r3OORh4VJwAMgx0igR8DVq3ARACIfSzTrDMuCZa94SSofDq34ATouMRA3joVklsnodL453gl6i8hg66cs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704825827; c=relaxed/simple; bh=F3zqKGfagUuqYwDZgBOEa7Pk/p0LdkHEWQafSrgeEOw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wPESBYB9aJLlLC/5NhMDuPHIFwYDF2jwEk1zajoURCyl/sykU7ROKPA+nlZBca5q53Ut1DbXBGz/YNXt0CnwWjGqJgWTjPDBfnA1//KcAop6NId/GobPL+bEi6UisrB+19Y+zekCIsv8vlZzAcdakkkGc2jiLOJadMK+pjT5DVo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-3606ebda57cso19011075ab.2 for ; Tue, 09 Jan 2024 10:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704825825; x=1705430625; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VKTko3VOmMBK0adpdGH+pOb5AwbmuMjE5sGiDJFf6ww=; b=EjZqmHJq3yq9Ca56znZeQaZf/97zZBTD3qg5T4B89pW8o8kzkAYx8R6mnXluHbI8u2 hY9v7yfQ9AonKRRIBoz6gcdPKELGSnxtmBk1W+JaSl/cIlQmxFfEp5h15yltqeVH1ciJ RVzkkU2h3avNO8n6XgPqbqIz6eFGo5q+Xprh1OKf7LU7YSqewqLt8CRI+JbNKPdqiBpE /VTncf0RY7i1u4xCaEJlDy5Pc1Oh92jRL9+cVacMqVnmlihvIgxz/6FrISlPon35A89P gV3MJkcbVzM7B0HdmXgpTNt9lLroIhcbmRvY708O5JIc0IfmS5UtQKVYIGHBhCDOGrm9 YRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704825825; x=1705430625; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VKTko3VOmMBK0adpdGH+pOb5AwbmuMjE5sGiDJFf6ww=; b=JyC15KtVD3ajHeGx+t/aKhoTRTUaO1CaHBd66F8QbwSNHVgW5odYELtAqXMuD5HOXw 8cBY2OZRPduGWXTlol2UXtWua2KLm2qelLvMdk4fElgDleDp6vc0EeOmg4Borc6/8WIL kd4sWSug9bXc0pYdhWzCTCn0iOM4FpzQ1kyHyipSbmGiGnPZ53iOMa0qMtInCNRvSGGY AHuZhXB+U3MVETjKNGoSXEmBRSL0/S3VUedXns5aFNOafGxV8ek5yQgbzuGcDnEzd6Vk Mt55xWdLQCFf573es1wKjTZiqGfBEYWdAHJOTkHJSvP56qjt2NMtE16GhSh9f//73aaG l/ow== X-Gm-Message-State: AOJu0YzJQMb+leVCE1KQj70fYVRn27zEls2F70Mpv/x8jABpHAb/f/9A xv4ZSgLdVcv5ajbTlN1BcE52qspEKmE= X-Google-Smtp-Source: AGHT+IEFdvfQ4q4drQJU9g+89qBANGbgmJw3YOnANllBt9Pm3DaL3MWhFtpBD6k7Mf7GbK451TDHsA== X-Received: by 2002:a05:6e02:1c87:b0:35f:f11b:c41e with SMTP id w7-20020a056e021c8700b0035ff11bc41emr8178995ill.1.1704825824848; Tue, 09 Jan 2024 10:43:44 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id v2-20020a92cd42000000b0035ff59f9ffcsm740959ilq.62.2024.01.09.10.43.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 10:43:44 -0800 (PST) Message-ID: <623765fe-16e6-4065-81ba-6c3426e9388c@gmail.com> Date: Tue, 9 Jan 2024 11:43:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] RISC-V: Add support for XCVbi extension in CV32E40P Content-Language: en-US To: Mary Bennett , gcc-patches@gcc.gnu.org References: <20231212193253.220195-4-mary.bennett@embecosm.com> <20240108131456.803003-1-mary.bennett@embecosm.com> <20240108131456.803003-2-mary.bennett@embecosm.com> From: Jeff Law In-Reply-To: <20240108131456.803003-2-mary.bennett@embecosm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/8/24 06:14, Mary Bennett wrote: > Spec: github.com/openhwgroup/core-v-sw/blob/master/specifications/corev-builtin-spec.md > > Contributors: > Mary Bennett > Nandni Jamnadas > Pietra Ferreira > Charlie Keaney > Jessica Mills > Craig Blackmore > Simon Cook > Jeremy Bennett > Helene Chelin > > gcc/ChangeLog: > * common/config/riscv/riscv-common.cc: Create XCVbi extension > support. > * config/riscv/riscv.opt: Likewise. > * config/riscv/corev.md: Implement cv_branch pattern > for cv.beqimm and cv.bneimm. > * config/riscv/riscv.md: Add CORE-V branch immediate to RISC-V > branch instruction pattern. > * config/riscv/constraints.md: Implement constraints > cv_bi_s5 - signed 5-bit immediate. > * config/riscv/predicates.md: Implement predicate > const_int5s_operand - signed 5 bit immediate. > * doc/sourcebuild.texi: Add XCVbi documentation. > > gcc/testsuite/ChangeLog: > * gcc.target/riscv/cv-bi-beqimm-compile-1.c: New test. > * gcc.target/riscv/cv-bi-beqimm-compile-2.c: New test. > * gcc.target/riscv/cv-bi-bneimm-compile-1.c: New test. > * gcc.target/riscv/cv-bi-bneimm-compile-2.c: New test. > * lib/target-supports.exp: Add proc for XCVbi. Assuming this has gone through a testing cycle, this is fine for the trunk. Thanks, jeff