From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 040633858D35 for ; Thu, 26 Oct 2023 21:06:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 040633858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 040633858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698354395; cv=none; b=lb2BDR1yh8Ochb5pYt553mndyLSpg9C5YgvBAk1fJarPNIcgUCqmBV7T0WpJZapv8MYAGQjjobqfGyeWfGtsxyIoGQp2qH3pEXsa8ZeTN33Wrg+55W7RmwzRNR+p5WxDV0houqw3utILRiub6o/t/ZHszkHTfJXzJWPXCQPmFFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698354395; c=relaxed/simple; bh=t1j5n27dQNUHgWv9xJoLoXBeXNv3pVmHaOHK3HhJwz0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wdTMwPqUapNBnk4hxeALIeh4GKI2i+D3DOAlspJubF8INEFqB5qqmEf5G5xdklnz2bZDM9+/1sToVn4Cb7EKFrcvialpgnyo48YBtpiBO9n4g6YkL9dxxYtywHUkUMyWo0Xdir7sx90xS7FGP9LJtTUmYoF8Br8a8KSaNpNKD/g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698354393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R7sGj8WpXTJ0N4B7+ISRufTfvH0tBJjfHC39cMG59Is=; b=drQEqyLIQdPtoResuzjI7W0R1PwkMXJFY/Lb4RFZmyffQ+vAy4iZq5D4AV8u15e1FiyYvX SpYn+IE1YJhqkKiR/9zN9W2XoaoqFRFD79uT9dWd94YgcMUaPm/F0UFx3YArV6FczvSGkB JsRkRDLpHX9/2a0hmxOlu/VepFkFIlI= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-kyc6kH1GPJijGBeJ6S5pLg-1; Thu, 26 Oct 2023 17:06:32 -0400 X-MC-Unique: kyc6kH1GPJijGBeJ6S5pLg-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-581dc6915b5so2204579eaf.1 for ; Thu, 26 Oct 2023 14:06:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698354391; x=1698959191; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R7sGj8WpXTJ0N4B7+ISRufTfvH0tBJjfHC39cMG59Is=; b=kx1Hh7NC6iVBnfOeOwn0yJz/Ey/7qXe0rRM2Sj1NBw9g4Hb4/tQ4m3PioYlU5iaHJO JAITXbLdt1MEk27iMliW+v+y4j3OEQfaYCkc6bCjtwibBXETLnyZxA2/TANqg3F3MxUM wQtlN53JDO4xgeCziv5B8IKsMx7dFdHovLM5F+4LLIu4Aj4hEfYjcrqznkwTCgoDcyG7 twYXoYI5KZmA6JrZM2boR5Mw1BfDasqSQecRzRv0vxgc70IOTToOWSn7APHIhdAas+9I EBJP9TTa+wHBX2LwxDW+x6g3/HsHxTO1j+cZuVL8WtNHdi3uC9UpU4ZJ189WV4SB1g/B gV2g== X-Gm-Message-State: AOJu0Yx4cxyXTgG5b63FnIPDR3qGhPZwISENPOSDdROeEya1jWpldEBW BzBjt0b+UwoP7vZka2g4WWxrOHdImTnQl+NBXXsepXRZpXPzgxKRoyl5bo2/jXZnH3OF/F9phxN Vj2F747IDV5EvN8jBIw== X-Received: by 2002:a05:6358:710:b0:168:e7f8:7cd2 with SMTP id e16-20020a056358071000b00168e7f87cd2mr1068169rwj.11.1698354391311; Thu, 26 Oct 2023 14:06:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzuoRJNOVBFKQTzK4OGLJ67oL3Jfi6azRdHMjkc7JfezEUayD2odZ+FRdBTgijrW3984sXbA== X-Received: by 2002:a05:6358:710:b0:168:e7f8:7cd2 with SMTP id e16-20020a056358071000b00168e7f87cd2mr1068152rwj.11.1698354390983; Thu, 26 Oct 2023 14:06:30 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id y8-20020a0cf148000000b0065cfec43097sm93876qvl.39.2023.10.26.14.06.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 14:06:30 -0700 (PDT) Message-ID: <6237945a-9b6a-45a0-94d2-8f150e4e3797@redhat.com> Date: Thu, 26 Oct 2023 17:06:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] c-family: Implement __has_feature and __has_extension [PR60512] To: Alex Coplan , gcc-patches@gcc.gnu.org Cc: Nathan Sidwell , Joseph Myers , Iain Sandoe References: From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/25/23 06:28, Alex Coplan wrote: > On 11/10/2023 14:31, Alex Coplan wrote: >> On 27/09/2023 15:27, Alex Coplan wrote: >>> Hi, >>> >>> This is a v4 patch to address Jason's feedback here: >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630911.html >>> >>> w.r.t. v3 it just removes a comment now that some uncertainty around >>> cxx_binary_literals has been resolved, and updates the documentation as >>> suggested to point to the Clang docs. >>> >>> ---------------------------------------------------------------------- Incidentally, putting a 8< or >8 in the line of dashes lets git am --scissors prune the text above the line. >>> This patch implements clang's __has_feature and __has_extension in GCC. >>> Currently the patch aims to implement all documented features (and some >>> undocumented ones) following the documentation at >>> https://clang.llvm.org/docs/LanguageExtensions.html with the exception >>> of the legacy features for C++ type traits. These are omitted, since as >>> the clang documentation notes, __has_builtin is the correct "modern" way >>> to query for these (which GCC already implements). >> >> Gentle ping on this: >> https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631525.html > > Ping^2 > +static const hf_feature_info has_feature_table[] = You might use constexpr for these tables? OK either way, thanks! Jason