From: "Martin Liška" <mliska@suse.cz>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH v2] preprocessor: -Wbidi-chars and UCNs [PR104030]
Date: Fri, 28 Jan 2022 16:08:18 +0100 [thread overview]
Message-ID: <62b897f5-4ac1-49ac-7ef3-d595dd868967@suse.cz> (raw)
In-Reply-To: <YfQEvEqUZyfh3xFd@redhat.com>
On 1/28/22 15:59, Marek Polacek wrote:
> On Fri, Jan 28, 2022 at 02:53:16PM +0100, Martin Liška wrote:
>> On 1/24/22 23:36, Marek Polacek via Gcc-patches wrote:
>>> |@@ -7820,6 +7820,10 @@ bidi contexts. @option{-Wbidi-chars=none} turns the warning off. @option{-Wbidi-chars=any} warns about any use of bidirectional control characters. +By default, this warning does not warn about UCNs. It is, however, possible +to turn on such checking by using @option{-Wbidi-chars=unpaired,ucn} or +@option{-Wbidi-chars=any,ucn}.|
>>
>> Hello.
>>
>> Can you please extend the documentation entry and explain what 'ucn' actually means?
>>
>> '''
>> There are three levels of warning supported by GCC@. The default is
>> @option{-Wbidi-chars=unpaired}, which warns about improperly terminated
>> bidi contexts. @option{-Wbidi-chars=none} turns the warning off.
>> @option{-Wbidi-chars=any} warns about any use of bidirectional control
>> characters.
>> '''
>>
>> Right now we have 4 levels and 'ucn' is not defined the paragraph.
>
> The following paragraph says
>
> By default, this warning does not warn about UCNs. It is, however, possible
> to turn on such checking by using @option{-Wbidi-chars=unpaired,ucn} or
> @option{-Wbidi-chars=any,ucn}.
>
> Is that not enough?
Yeah, makes sense. Do I understand it correctly that one can't use -Wbidi-chars=ucn?
Thanks,
Martin
>
> Marek
>
next prev parent reply other threads:[~2022-01-28 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 16:44 [PATCH] " Marek Polacek
2022-01-24 22:36 ` [PATCH v2] " Marek Polacek
2022-01-24 22:44 ` Jakub Jelinek
2022-01-28 13:53 ` Martin Liška
2022-01-28 14:59 ` Marek Polacek
2022-01-28 15:08 ` Martin Liška [this message]
2022-01-28 15:26 ` Marek Polacek
2022-01-28 16:12 ` Martin Liška
2022-01-28 20:57 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b897f5-4ac1-49ac-7ef3-d595dd868967@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).