From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 819443858418 for ; Fri, 28 Jan 2022 15:08:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 819443858418 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4254C1F391; Fri, 28 Jan 2022 15:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643382499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z42W9hbDcUaX4QAbhVbLdIeaz/uxK/+49W9vINHcn1o=; b=tan9eXkLSLd4fpgKMSIQpeqisaAMW7NOc/IMtfVSMHMuQ0QxUgu/v8XOrZOv0Bqmz8dyNc s42fxfW+qhyoZjjwTmE3CkYu+I8uQQi8NHphb0W8v6L+9oFVry4XBBzulWFXQUFAP7zGha /4bVYj5GRpdCzIbPlUDDPuZHoEVD3Xs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643382499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z42W9hbDcUaX4QAbhVbLdIeaz/uxK/+49W9vINHcn1o=; b=289YW3pF/kDvq+e0pizjFYR0/KXbz4i0DYSLf8ltjwTa9HY6GD8ezMd7IujJRFcY6z+rsV QaDdgVGH99fE3DAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28DD0139B3; Fri, 28 Jan 2022 15:08:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id P/gGCeMG9GEyPAAAMHmgww (envelope-from ); Fri, 28 Jan 2022 15:08:19 +0000 Message-ID: <62b897f5-4ac1-49ac-7ef3-d595dd868967@suse.cz> Date: Fri, 28 Jan 2022 16:08:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] preprocessor: -Wbidi-chars and UCNs [PR104030] Content-Language: en-US To: Marek Polacek Cc: GCC Patches , Jakub Jelinek References: <20220120164439.42202-1-polacek@redhat.com> <1401625c-8500-a721-087d-68d1a024838d@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 15:08:21 -0000 On 1/28/22 15:59, Marek Polacek wrote: > On Fri, Jan 28, 2022 at 02:53:16PM +0100, Martin Liška wrote: >> On 1/24/22 23:36, Marek Polacek via Gcc-patches wrote: >>> |@@ -7820,6 +7820,10 @@ bidi contexts. @option{-Wbidi-chars=none} turns the warning off. @option{-Wbidi-chars=any} warns about any use of bidirectional control characters. +By default, this warning does not warn about UCNs. It is, however, possible +to turn on such checking by using @option{-Wbidi-chars=unpaired,ucn} or +@option{-Wbidi-chars=any,ucn}.| >> >> Hello. >> >> Can you please extend the documentation entry and explain what 'ucn' actually means? >> >> ''' >> There are three levels of warning supported by GCC@. The default is >> @option{-Wbidi-chars=unpaired}, which warns about improperly terminated >> bidi contexts. @option{-Wbidi-chars=none} turns the warning off. >> @option{-Wbidi-chars=any} warns about any use of bidirectional control >> characters. >> ''' >> >> Right now we have 4 levels and 'ucn' is not defined the paragraph. > > The following paragraph says > > By default, this warning does not warn about UCNs. It is, however, possible > to turn on such checking by using @option{-Wbidi-chars=unpaired,ucn} or > @option{-Wbidi-chars=any,ucn}. > > Is that not enough? Yeah, makes sense. Do I understand it correctly that one can't use -Wbidi-chars=ucn? Thanks, Martin > > Marek >