From: Jeff Law <jeffreyalaw@gmail.com>
To: Edwin Lu <ewlu@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com, Vineet Gupta <vineetg@rivosinc.com>
Subject: Re: [PATCH V3] riscv: generate builtin macro for compilation with strict alignment:
Date: Mon, 28 Aug 2023 16:40:38 -0600 [thread overview]
Message-ID: <62d8c70a-43f8-c450-a8c6-05e5e58b76a6@gmail.com> (raw)
In-Reply-To: <20230815182913.2824479-1-ewlu@rivosinc.com>
On 8/15/23 12:29, Edwin Lu wrote:
> This patch is a modification of
> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610115.html
> following the discussion on
> https://github.com/riscv-non-isa/riscv-c-api-doc/issues/32
>
> Distinguish between explicit -mstrict-align and cpu tune param
> for slow_unaligned_access=true/false.
>
> Tested for regressions using rv32/64 multilib with newlib/linux
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins):
> Generate __riscv_unaligned_avoid with value 1 or
> __riscv_unaligned_slow with value 1 or
> __riscv_unaligned_fast with value 1
> * config/riscv/riscv.cc (riscv_option_override):
> Define riscv_user_wants_strict_align. Set
> riscv_user_wants_strict_align to TARGET_STRICT_ALIGN
> * config/riscv/riscv.h: Declare riscv_user_wants_strict_align
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/attribute-1.c: Check for
> __riscv_unaligned_slow or __riscv_unaligned_fast
> * gcc.target/riscv/attribute-4.c: Check for
> __riscv_unaligned_avoid
> * gcc.target/riscv/attribute-5.c: Check for
> __riscv_unaligned_slow or __riscv_unaligned_fast
> * gcc.target/riscv/predef-align-1.c: New test.
> * gcc.target/riscv/predef-align-2.c: New test.
> * gcc.target/riscv/predef-align-3.c: New test.
> * gcc.target/riscv/predef-align-4.c: New test.
> * gcc.target/riscv/predef-align-5.c: New test.
> * gcc.target/riscv/predef-align-6.c: New test.
OK. Though I'm pretty sure the commit hooks are going to complain about
your ChangeLog :-)
jeff
next prev parent reply other threads:[~2023-08-28 22:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 18:29 Edwin Lu
2023-08-28 22:40 ` Jeff Law [this message]
2023-08-29 15:48 ` [Committed] " Edwin Lu
2023-08-29 15:53 ` Palmer Dabbelt
2023-08-29 16:12 ` Edwin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d8c70a-43f8-c450-a8c6-05e5e58b76a6@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).