From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id A93863858D28 for ; Sat, 11 Nov 2023 16:19:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A93863858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A93863858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699719552; cv=none; b=VYWYZhi/ivgdjjg/GGButc7mypH5dRMbIyuIQejRXpxKeemFG2b42zTVdx+gyBUaX32QyrbQkd9EY+mefzdCGLotLlfD37YhrLzOhZDXrp45isz8LjAwzYDq5E0whYnT1NZMJVWVTkoforvZ3qzODM46Jg5G5H6qJvHvPQ4qLuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699719552; c=relaxed/simple; bh=H+XCBwTJxXk6AdzKjhflkqyOyrC1390EuV25Y9GfnDs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RZqaTkpNVBsNFPjqsc6mtjck9xHzQc/34buHp76FAjg4I3oIPoStZaxF8NqgOLXtWQFReJ/HOZYgqXkVNe9l40FUK2rFtd4mx/3wk9LC+xaWJnTdaJmmGjN6d0kQlyeT5JpAwoShwJdfuAGUjb03F/1RYv0sJZ5/7YFZ/TrnTPs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-357cf6725acso11960055ab.3 for ; Sat, 11 Nov 2023 08:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699719551; x=1700324351; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=muhEW6HEz965QknkBE9iHbBd2zxyB9Ce/vps1AQKNVw=; b=nYxIvwVXOFwKqSahuMbLSnZvsZELHXfvfiTHZnnmEn8HqRsbfPNx/8zbWwUeYLbN3/ gUPXw6Vvj8EIAcWfn1s1P+foA9x12k8EASbdj7/LTbakG2Ggms1IOM+3sm7gACmmg3IN p+J6WxUJb3lJLrtmQJCfFwaI5Gyif6XwvZTsgTCjvZPdAVFr8UxnqlLrDuyp/gcAWbnS sPHxAyUuLZJX3l1LT1WxTEzS5qNq/HHtT9q/EyYJSC+CTuoGXdM4W9iUKCFcsg53jUCM H6f+ml0jkUZwa+qSG4gRnevRcE5nazl7/Pm1Xi82E1IjTz8Lc8LBFkgJ4NtCQajQ1kYn glXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699719551; x=1700324351; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=muhEW6HEz965QknkBE9iHbBd2zxyB9Ce/vps1AQKNVw=; b=c2jX/DTi119JRwz0v6BjSM94v5cKHwRW/zJzXwyDzLqEZsAIIKbkO85AeDR60WaTE7 foi4CXBegl1Hxc/GMz8nDUWjnBqWv5exEib2RRtkI5kUOR2dyc5Vwx5cM4IyQ5Uid/tC qJPUiymQb9weXaKi/YqhQp/ds+J0GbOKzx0fXV4qN/0ns8vP2/Qs0yObvigp9QD9V3cQ lYDy0S214DQ81xaT964bO1HVAbNBJ74SwI6Loon9RGFd/xMe2q4CPf5+oykhbNX16F+2 nNAtGeMtcP3hykE1DEnE2TNM/SMK6BHNayiMJMLTB5dZHTRaBZEz1WgdH3Xsx2Yt9nJD 99gw== X-Gm-Message-State: AOJu0YxIbUB3oh+3C3RjOtE/SrgjJAYmMqNNT652eMWW+AADsXuTezBy kOKl4iCFRMSK3i6BKMPAXs0= X-Google-Smtp-Source: AGHT+IEKeGa7mwnlGaRnUyG5jELRDH6S0ymeqipewLhSujMwB+RUWpychcFQ2ejEbN93kKAfhB7ciw== X-Received: by 2002:a05:6e02:1bcf:b0:357:438f:6ecf with SMTP id x15-20020a056e021bcf00b00357438f6ecfmr3385680ilv.13.1699719550691; Sat, 11 Nov 2023 08:19:10 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id b6-20020a02a586000000b0046400df8ceasm507466jam.170.2023.11.11.08.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Nov 2023 08:19:10 -0800 (PST) Message-ID: <62fdc8a2-d8bd-4ec9-9566-cb5c81215039@gmail.com> Date: Sat, 11 Nov 2023 09:19:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/12] mode-switching: Use 1-based edge aux fields Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: <3aec5244-f77a-400a-b9d6-a8cd72eb935b@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/11/23 08:51, Richard Sandiford wrote: > Jeff Law writes: >> On 11/7/23 17:35, Richard Sandiford wrote: >> >>> I could have sworn that there was something that checked that passes >>> left edge aux fields clear, but it looks like I misremembered. So I >>> probably need to stick a clear_aux_for_edges () call above the first >>> main loop (for 12/12) and keep the initialisation here as well. >> That does sound vaguely familiar. Maybe it was a one-off test someone >> did. >> >>> >>> That kind-of takes away the point of shifting to 1-based values >>> in the first place. Ah well... >> Your call. I'd tend to lean towards inserting the clear_aux call if we >> don't have something that's consistently verifying aux state. > > Agreed. A convention that isn't tested isn't strong enough to rely on. > >> Alternately we can return to the -1 handling. I doubt it's all that >> important from a compile-time standpoint. > > I dithered about it a bit, but in the end, zero does still seem to work > out a bit more nicely. > > I think you'd basically OKed the patch with this change, but I'm feeling > extra risk-averse at the moment :) so, here's an updated patch. > Tested as before. OK to install? > > Thanks for catching this. > > Richard > > > gcc/ > * mode-switching.cc (commit_mode_sets): Use 1-based edge aux values. Yea, intention was to ACK whichever approach you preferred. OK. jeff