From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14740 invoked by alias); 21 Oct 2011 11:10:39 -0000 Received: (qmail 14731 invoked by uid 22791); 21 Oct 2011 11:10:38 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2bthomr10.btconnect.com (HELO mail.btconnect.com) (213.123.20.128) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Oct 2011 11:10:12 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2bthomr10.btconnect.com with ESMTP id EWY81840; Fri, 21 Oct 2011 12:10:09 +0100 (BST) Cc: Hans-Peter Nilsson , GCC Patches Message-Id: <63B3C6F6-2C30-4A7C-A324-8805D8AA8667@sandoe-acoustics.co.uk> From: Iain Sandoe To: Jan Hubicka In-Reply-To: <20111021093112.GD2976@kam.mff.cuni.cz> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [RFA:] fix breakage with "Update testsuite to run with slim LTO" Date: Fri, 21 Oct 2011 12:23:00 -0000 References: <20111020221932.GA13355@kam.mff.cuni.cz> <201110210229.p9L2TKmx010677@ignucius.se.axis.com> <20111021093112.GD2976@kam.mff.cuni.cz> X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0303.4EA1530D.00D9, actions=tag X-Junkmail-Premium-Raw: score=7/50, refid=2.7.2:2011.10.21.103616:17:7.944, ip=81.138.1.83, rules=__MULTIPLE_RCPTS_CC_X2, __HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CT_TEXT_PLAIN, __CTE, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, __ANY_URI, __URI_NO_WWW, __URI_NO_PATH, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_1600_1699, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, RDNS_SUSP, BODY_SIZE_2000_LESS, BODY_SIZE_7000_LESS, MULTIPLE_RCPTS X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0209.4EA15312.0103,ss=1,fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01957.txt.bz2 On 21 Oct 2011, at 10:31, Jan Hubicka wrote: >>> Date: Fri, 21 Oct 2011 00:19:32 +0200 >>> From: Jan Hubicka >>> Yes, if we scan assembler, we likely want -fno-fat-lto-objects. >> >>>> then IIUC you need to patch *all* torture tests that use >>>> scan-assembler and scan-assembler-not. Alternatively, patch >>>> somewhere else, like not passing it if certain directives are >>>> used, like scan-assembler{,-not}. And either way, is it safe to >>>> add that option always, not just when also passing "-flto" or >>>> something? >>> >>> Hmm, some of assembler scans still works because they check for >>> presence of symbols we output anyway, but indeed, it would make more >>> sense to automatically imply -ffat-lto-object when scan-assembler >>> is used. I am not sure if my dejagnu skill as on par here however. >> >> Maybe you could make amends ;) by testing the following, which >> seems to work at least for dg-torture.exp and cris-elf/cris-sim, >> in which -ffat-lto-object is automatically added for each >> scan-assembler and scan-assembler-not test, extensible for other >> dg-final actions without polluting with checking LTO options and >> whatnot across the files. I checked (and corrected) so it also >> works when !check_effective_target_lto by commenting out the >> setting in the second chunk. > > Thanks. It looks good to me. If we ever start scanning LTO > assembler output, > we may simply add scan-lto-assembler variants or so... It looks like the gnat testsuite is also broken - but HP's fix doesn't recover that. .. will try and take a look - but short on time today, Iain