From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BFAA63858C35 for ; Fri, 9 Feb 2024 15:20:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFAA63858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BFAA63858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707492010; cv=none; b=uCyUSZf4jwU9VlOBsO5hV+KAqgmSy2b9CUkHC700HxafgBqN+45QKs51HaW0MIs0LqYj5zax11Apc/Lskw53ib4ZahRY+VtP/tMr3gv7aQwJyxTmaccJ+U8PKTDyC6rk0khYeb+DZByzktxBJuU4oJCzd6iOXiA6mG8SZfgoGJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707492010; c=relaxed/simple; bh=AhGPAWLjCtAijgmv45Stc2dy143KZN2xHQDuFJATslM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qm8ogUBDpoLcTbrx2lDpVLW01UlAdI40b2lYydJAEOh1vRiTU6QlU4F7jftkng2k+z5Tay6DlrOmxB7aZRbNYI4aofL/thW99N3V6qJXubjx6k+4XVhKpWm8PgPsJHoxU8/0ywADVGbwy6lhcDn4I6Y3tavvV/58+jbXnHqSA5Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707492008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N/sA/rOh/4/aEBuP/mAsIREdr2GfpIFy4t7ZdNQjGKs=; b=gGozg9QrRXaU5FQGrwnsDZzTLiL7aQ41sdCkUZ8l7k/ViG1I1ws6O69LueOjQdN1Hl5g7+ 5Vm6E6VpkZQPMcAuJZ6FWYMjREGcvxsdifnphP0G60OpQfWUV0PRuhrmQDULWWW+8uM9pi X1Lp5EWqLDdbEIL12jzkPs7eaCOiD10= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-BM9BW_FHO-S8HNZ9d793xA-1; Fri, 09 Feb 2024 10:20:07 -0500 X-MC-Unique: BM9BW_FHO-S8HNZ9d793xA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-68c4f4bdcaaso18005186d6.1 for ; Fri, 09 Feb 2024 07:20:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707492006; x=1708096806; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N/sA/rOh/4/aEBuP/mAsIREdr2GfpIFy4t7ZdNQjGKs=; b=E70a3JzMP4F+4NNuZbyx7qN7G5tD6ZP727OjWKMsBFa4dB8X0GBBIQ191cBxes0/qH 7N+Km1OuxSHlzKL+XahBngbAQRrVwKVflKUwU8Um3TnH1ta60wdtJ99sIeK2l/xg9QYC Qf/vnOOuidmk67UccvgSQCELmX8XI60SmmqFGf8fwO3xbNiAwrsZCtuZ6XHpjij9zU2w 7xN5RHi1XMLE/mTczjoIeXRupCCbPxvWYlKp7G6+UL+Ki98XoTPWZzt+ZTqXSviHrlS7 TmkH5HbVq67sNTaDPqOIarZCBBOlC2xiZO78sJnlyCU171hiWyS0SRelzbyHauRFG1pT FNjg== X-Gm-Message-State: AOJu0YzxS2/Rt+6ap4fd0zDrksZPfh0gvrSomWid9mNuKnM+xk2WGqUe vPzDKPbIEeWowI+9A7RH5c34BnIsIXyd9fEPoY3t/A/0U6u7QxcplHuCbu8BCHTwQnbO67vP3W1 IPCHGL9FATUuWpXtRKou1yXu0KlxESXfaRTXdBJrqWtdkbPpTYwUCwgY= X-Received: by 2002:a0c:cb11:0:b0:68c:9db6:e156 with SMTP id o17-20020a0ccb11000000b0068c9db6e156mr1694049qvk.47.1707492006631; Fri, 09 Feb 2024 07:20:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdZiGWR+YcBcDCRyu1eNs8g4y4eyBPzro4ktZJO849PUQunkBNGbu7u8qQrjq1/JvofX+kBg== X-Received: by 2002:a0c:cb11:0:b0:68c:9db6:e156 with SMTP id o17-20020a0ccb11000000b0068c9db6e156mr1694027qvk.47.1707492006197; Fri, 09 Feb 2024 07:20:06 -0800 (PST) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id oj8-20020a056214440800b0068c81299a2bsm919004qvb.15.2024.02.09.07.20.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 07:20:05 -0800 (PST) Message-ID: <63bbdd3c-f71a-45b1-bcb7-13569fb5f8da@redhat.com> Date: Fri, 9 Feb 2024 10:20:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] c++: DR2237, cdtor and template-id tweaks [PR107126] To: Marek Polacek Cc: GCC Patches References: <20240203152404.1199437-1-polacek@redhat.com> <69077fcc-97fe-43be-9e34-9d91d1a7c7af@redhat.com> <3bd79ed5-57fa-4ea9-a250-07417738579a@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/8/24 16:26, Marek Polacek wrote: > This patch does *not* fix > > where the C++20 diagnostic is missing altogether. What would it take to fix that as well? > * doc/invoke.texi: Document -Wdeprecated-template-id-cdtor. Was it ever deprecated? I'm not seeing that in https://timsong-cpp.github.io/cppwp/n4659/#depr (C++17) Let's drop the word "deprecated" from the option name and documentation. > @@ -32331,11 +32338,11 @@ cp_parser_constructor_declarator_p (cp_parser *parser, cp_parser_flags flags, > if (next_token->type != CPP_NAME > && next_token->type != CPP_SCOPE > && next_token->type != CPP_NESTED_NAME_SPECIFIER > - /* DR 2237 (C++20 only): A simple-template-id is no longer valid as the > - declarator-id of a constructor or destructor. */ > - && (next_token->type != CPP_TEMPLATE_ID || cxx_dialect >= cxx20)) > + && next_token->type != CPP_TEMPLATE_ID) > return false; > > + const bool saw_template_id = (next_token->type == CPP_TEMPLATE_ID); Please incorporate your "further DR2237 fix" patch into this one. > @@ -32552,6 +32559,19 @@ cp_parser_constructor_declarator_p (cp_parser *parser, cp_parser_flags flags, > /* We did not really want to consume any tokens. */ > cp_parser_abort_tentative_parse (parser); > > + /* DR 2237 (C++20 only): A simple-template-id is no longer valid as the > + declarator-id of a constructor or destructor. */ > + if (constructor_p && saw_template_id) > + { > + gcc_checking_assert > + (!cp_parser_uncommitted_to_tentative_parse_p (parser)); Now I see the abort_ just above, so this seems unnecessary after all. Thanks, Jason