From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D91883858414 for ; Thu, 19 Oct 2023 08:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D91883858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D91883858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697704805; cv=none; b=xybqwO+LxL4Wel5Sw1/23PYD2lqa7Pn1zVXF6lX7yrnptftiHbFZpjR/1Ab38moUaM/xQHvmV6qpcGOVimL841NoeyE6NxOYGxbfBmZGR+dquhjMwTOADns4pBKlG9tK+woebyTrd3FffkyawwL9qgQvh+lXIK1um8UAep5tCEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697704805; c=relaxed/simple; bh=UkaMaRCMCOM/LHywnQG5NO2grsPnc1Xl666/1wCH10E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MFPV+MwXPCY4i/+3FstYW6EH12zhkiPR6zWkFSoVbeKDpO9Mjj+j2iY0cznWTDdWZa+7FoKMsGd8h73aJ8fTuzMnptK/RxZjSmTs+1wo97TzAwNOdZxcLTAc0OQIEXIeS+kvj6Cy4Mdy3I/lcVHc22fWs8l0enZMQ3CnKqtLLes= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39J8YwGw019514; Thu, 19 Oct 2023 08:39:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=iPwl4PnEXa7W2BGn40zCWtCq/b6YYG8IBdzaCNMv09k=; b=bDL0VMclluu1Nx5Qi+fh7UcUcq3b8xkEGKvZNBZ3YquO5oSSM5EIEhl7y+VapFt7x2Qp iffVw6+VT5ji/mdjum8PM3urJHyQu2FNKJCw6I4phlNC3Iz6RiYaKh1ahOFuFH0HjoVh EswOlNqQWpjux4rmbVRNC3qyAquztHxZ5OCO4jfScCaya3jf8Y/QR/f9zRc1OUZaZIAz r0ycMXxzxRwfA8YKfSrSHkreYk8+Q86Q5pdn+veCgiAwXyq3ZAZswklLzyKHfvuGEYhO JUf0pE2E/pyeEoRmGJBVEci//l466hKvMbBcK53PgwQkjq/FAJ9PVC4bE4GylH1/XJbm lw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tu12pg505-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 08:39:58 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39J8Zxb0023087; Thu, 19 Oct 2023 08:39:58 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tu12pg4xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 08:39:58 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39J73sqX019713; Thu, 19 Oct 2023 08:39:56 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3tr811y4w9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 08:39:56 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39J8dr2O20578856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2023 08:39:53 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6652020043; Thu, 19 Oct 2023 08:39:53 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CABAE20040; Thu, 19 Oct 2023 08:39:51 +0000 (GMT) Received: from [9.200.103.64] (unknown [9.200.103.64]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 19 Oct 2023 08:39:51 +0000 (GMT) Message-ID: <63fcb41e-5816-ae7a-ce63-e5c209d8dfe4@linux.ibm.com> Date: Thu, 19 Oct 2023 16:39:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH-2, rs6000] Enable vector mode for memory equality compare [PR111449] Content-Language: en-US To: "Kewen.Lin" , David Edelsohn Cc: gcc-patches , Segher Boessenkool , Peter Bergner References: From: HAO CHEN GUI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: IjXOVVuqIaP_FdSrkaywLh1reGUjPmCU X-Proofpoint-ORIG-GUID: 8VwFnhwOlskdjDgd7PKkmYXAhX86b21V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-19_05,2023-10-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxlogscore=985 priorityscore=1501 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310190070 X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Kewen & David, Thanks for your comments. 在 2023/10/17 10:19, Kewen.Lin 写道: > I think David raised a good question, it sounds to me that the current > handling simply consider that if MOVE_MAX_PIECES is set to 16, the > required operations for this optimization on TImode are always available, > but unfortunately on rs6000 the assumption doesn't hold, so could we > teach generic code instead? Finally I found that it doesn't check if the scalar mode used in by pieces operations is enabled by the target. The TImode is not enabled on ppc. It should be checked before taking TImode to do by pieces operations. I made a patch for the generic code and testing it. With the patch, 16-byte comparison could be enabled on both ppc64 and ppc. Thanks Gui Haochen