From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 3871B3858000 for ; Wed, 8 Mar 2023 18:45:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3871B3858000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-x436.google.com with SMTP id fa28so10834143pfb.12 for ; Wed, 08 Mar 2023 10:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678301138; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=9pA4mWrzfNRjwADVeb0S1LLGtWD3XKLPLxQg9AXwXrw=; b=VnnNSFsY6A69RT2YAApyXeqvJ/AIyj5BqgRQjj0vYZcuovsdL2sKOLTFBGBF3Rp6Bi PEuW9IHhx0VglPC4H1L2TskNj6Bd0BxpPGeR901uJkYNkmc//4P8SOyg2oUv7tlDWZuV 83RoWWEcio2qCYtXpv08YhvBqjnJWBKiJR84s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678301138; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9pA4mWrzfNRjwADVeb0S1LLGtWD3XKLPLxQg9AXwXrw=; b=He6nn8+VFmdSTfg7E+Fk5lm8LKn7r4GD8fOy/68AWqJuRe4vnnMz5k7XllCN/IUavK rrYRWEUh7TA9fLLe9X0a4cHJisbWeMkNiQBw9i+SsEbUX/lRce5vXnAIu9hcdMI6ZZt1 O4hQIcMAtAIriG4ziKfwimj5ydyD5ZmXvyGR0ysiMkfp6o/k0sCcfsuCiUHy113noH+F DWp3S08CvU5UVUhRLhK2juBBUbnLNlQWFPZ9vbrYsPNYWbqG9uKTZ6ScicL9UvF9dYO4 /CrTXh73Vt9e6IeWA9XlQeorBYSHOToFyApH0jZoQofpdZmMK+Ocd110if74225an6RO PGqg== X-Gm-Message-State: AO0yUKXxxCo2XqM7oB/YPrSok5Y22seAJ3KILNaLLGS7/7OjuQ5NKFTt VK0lPrjciFDas16JuX9blYyVAA== X-Google-Smtp-Source: AK7set8jIfXgB/4ZxVmCTeqTAw06XjL/zHAZA3UhXtfTMJTw/ITI8xwEBriCj2IS4JmlaHtRdBqWOw== X-Received: by 2002:a62:6583:0:b0:5a8:a420:72f7 with SMTP id z125-20020a626583000000b005a8a42072f7mr15354231pfb.7.1678301138146; Wed, 08 Mar 2023 10:45:38 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id n25-20020aa79059000000b00593e4e6516csm9712999pfo.124.2023.03.08.10.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 10:45:37 -0800 (PST) Message-ID: <6408d7d1.a70a0220.484be.1a2c@mx.google.com> X-Google-Original-Message-ID: <202303081044.@keescook> Date: Wed, 8 Mar 2023 10:45:36 -0800 From: Kees Cook To: Qing Zhao Cc: joseph@codesourcery.com, rguenther@suse.de, siddhesh@gotplt.org, gcc-patches@gcc.gnu.org Subject: Re: [V4][PATCH 0/2] Handle component_ref to a structure/union field including FAM for builtin_object_size References: <20230224183505.4112295-1-qing.zhao@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230224183505.4112295-1-qing.zhao@oracle.com> X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 24, 2023 at 06:35:03PM +0000, Qing Zhao wrote: > Hi, Joseph and Richard, > > Could you please review this patch and let me know whether it’s ready > for committing into GCC13? > > The fix to Bug PR101832 is an important patch for kernel security > purpose. it's better to be put into GCC13. Hi! This series tests well for me. Getting this landed would be very nice for the Linux kernel. :) Are there any additional review notes for it, or is it ready to land? Thanks! -Kees -- Kees Cook