From: Thomas Koenig <tkoenig@netcologne.de>
To: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Fix assumed-size to assumed-rank passing [PR94070]
Date: Fri, 24 Sep 2021 22:38:18 +0200 [thread overview]
Message-ID: <6413a5ba-4b64-1e47-1800-d4fd7402c16e@netcologne.de> (raw)
In-Reply-To: <53d84639-36ea-15e0-fecc-359007294dc0@codesourcery.com>
Hi Tobias,
> OK for mainline?
As promised on IRC, here's the review.
Maybe you can add a test case which shows that the call to the size
intrinsic really does not happen.
OK with that.
Thanks for the patch!
Best regards
Thomas
next prev parent reply other threads:[~2021-09-24 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 12:26 Tobias Burnus
2021-09-24 20:38 ` Thomas Koenig [this message]
2021-09-27 12:07 ` Tobias Burnus
2021-09-27 12:38 ` [committed] libgomp.oacc-fortran/privatized-ref-2.f90: Fix dg-note (was: [Patch] Fortran: Fix assumed-size to assumed-rank passing [PR94070]) Tobias Burnus
2021-09-28 12:29 ` Thomas Schwinge
2021-09-27 19:34 ` [Patch] Fortran: Fix assumed-size to assumed-rank passing [PR94070] Harald Anlauf
2021-09-28 6:40 ` Tobias Burnus
2021-09-28 19:15 ` Harald Anlauf
2021-09-28 12:30 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6413a5ba-4b64-1e47-1800-d4fd7402c16e@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).