From: Kees Cook <keescook@chromium.org>
To: Qing Zhao <qing.zhao@oracle.com>
Cc: jakub@redhat.com, joseph@codesourcery.com,
richard.guenther@gmail.com, siddhesh@gotplt.org,
gcc-patches@gcc.gnu.org
Subject: Re: [V6][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832]
Date: Wed, 12 Apr 2023 11:46:34 -0700 [thread overview]
Message-ID: <6436fc8b.a70a0220.2d124.8193@mx.google.com> (raw)
In-Reply-To: <20230328154944.3946619-2-qing.zhao@oracle.com>
On Tue, Mar 28, 2023 at 03:49:43PM +0000, Qing Zhao wrote:
> the C front-end has been approved by Joseph.
>
> Jacub, could you please eview the middle end part of the changes of this patch?
>
> The major change is in tree-object-size.cc (addr_object_size).
> (To use the new TYPE_INCLUDE_FLEXARRAY info).
>
> This patch is to fix PR101832(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832),
> and is needed for Linux Kernel security. It’s better to be put into GCC13.
>
> Thanks a lot!
Just to confirm, I've done build testing with the Linux kernel, and this
is behaving as I'd expect. This makes my life MUCH easier -- many fewer
false positives for our bounds checking. :)
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-04-12 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 15:49 [V6][PATCH 0/2] Handle component_ref to a structure/union field including FAM for builtin_object_size Qing Zhao
2023-03-28 15:49 ` [V6][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Qing Zhao
2023-04-04 13:06 ` Fwd: " Qing Zhao
2023-04-11 13:37 ` Qing Zhao
2023-04-20 14:10 ` Ping * 3: " Qing Zhao
2023-04-12 18:46 ` Kees Cook [this message]
2023-04-17 12:56 ` Qing Zhao
2023-03-28 15:49 ` [PATCH 2/2] Update documentation to clarify a GCC extension Qing Zhao
2023-04-04 13:07 ` Fwd: [V6][PATCH " Qing Zhao
2023-04-11 13:38 ` Qing Zhao
2023-04-20 14:11 ` Ping * 3: " Qing Zhao
2023-04-11 13:35 ` Fwd: [V6][PATCH 0/2] Handle component_ref to a structure/union field including FAM for builtin_object_size Qing Zhao
2023-04-20 14:08 ` Ping * 3: " Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6436fc8b.a70a0220.2d124.8193@mx.google.com \
--to=keescook@chromium.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=qing.zhao@oracle.com \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).