From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 880703858D28 for ; Fri, 6 Jan 2023 09:02:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 880703858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x336.google.com with SMTP id m3so637339wmq.0 for ; Fri, 06 Jan 2023 01:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=nKePKkpmcZ0BmICZ/7iKERbYzDGcaChaDqQo8HWOBzM=; b=iWgH0cJvp5YDmhM5kh6jmlm8XQK8IJKFMRCyXb9sTYfJT1pLHcIJdgzE0IQqfTPvdf BGXQhAB1i9DHvTebInX8O1f6fbr73nZC5sXxIzymsoul/W/EEzTjhYRorHvfr0gkatu7 UW5l/0xd88JVtxzmZac8pN8MfbZyDzoMrdfbRDq3497goDtJOCiVUm1lBxSYxnZl7MPE JXecKFhJCuHFWk6yKs7aqzA5lk/mG538dPeHkevEhSpwDOGQRg40SFoUXgu0ofpQX6hG DkmW9z5KrS85nAL2YvzNRWmU6MJZYd+5rm05nKCwQ2Pu08wB/6RqROQwxVPcHx8YoES/ xROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nKePKkpmcZ0BmICZ/7iKERbYzDGcaChaDqQo8HWOBzM=; b=nr+QS9Hf6dKpZcDS/GML+DpWNnSxt2JqRS90A0+cUb2mJxEw5ToNhHOdofVXZyvuvX UG7fVrJjDNZcDyC7yP0U68LMq6QFiUj+gnTFj9GQMemWzTw3Q+RyynjMGJJMb5T47mGx x5tkaDrZHAg68BPK/ntY01xLV9Aph8qA3kPmI37NwnSPW9hx7FTvaYzipHrrEotby6fk yCYcZbddMOZyFr0wIIqQ6IbNSrPGz0wXb3kNzQmC/lIkWEyJresJp01TQFVByWvo8JMu mrcwTobhhzaS0dPHZxj9gs9rjWwb8IZaiia1I2ruAbIEK/zkmA5K8dVcPjvfxEYe71/d /SvA== X-Gm-Message-State: AFqh2kqMkaX1QrvScn/bOkVwkJgbm4XpHv6bBUUFQR0sopBZNVUUeC5j 4wLnMrfhUkQo1CNmQa/psjo= X-Google-Smtp-Source: AMrXdXs5gkRfTDT36P1nY+t0hW46GkeQ6s/ZbEHI5nKq9VWeSzWi7Vkx3wNRx3GFsAgFF/mwZHDLQQ== X-Received: by 2002:a05:600c:4da0:b0:3d2:3a53:2cd6 with SMTP id v32-20020a05600c4da000b003d23a532cd6mr39199086wmp.9.1672995727093; Fri, 06 Jan 2023 01:02:07 -0800 (PST) Received: from smtpclient.apple (dynamic-077-004-015-184.77.4.pool.telefonica.de. [77.4.15.184]) by smtp.gmail.com with ESMTPSA id z25-20020a1c4c19000000b003d1e1f421bfsm5348683wmf.10.2023.01.06.01.02.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 01:02:05 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] configure: remove dependencies on gmp and mpfr when gdb is disabled Date: Fri, 6 Jan 2023 10:01:54 +0100 Message-Id: <64573A4D-6CD0-4D68-A762-6069871C01FE@gmail.com> References: Cc: gcc-patches@gcc.gnu.org, tom@tromey.com, pinskia@gmail.com In-Reply-To: To: =?utf-8?Q?Cl=C3=A9ment_Chigot?= X-Mailer: iPhone Mail (20C65) X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 06.01.2023 um 09:44 schrieb Cl=C3=A9ment Chigot via Gcc-patches : >=20 > =EF=BB=BFOn Fri, Jan 6, 2023 at 9:39 AM Cl=C3=A9ment Chigot wrote: >>=20 >> Since 91e0d22025e0bf2af2e364cb7214a05512a0c431, the configure checks >> about GMP and MPFR for gdb builds have been moved to the toplevel >> configure. >> However, it doesn't take into account the --disable-gdb option. Meaning >> that a build without gdb will require these libraries even if not >> needed. >>=20 >> ChangeLog: >>=20 >> * configure.ac: Skip GMP and MPFR when --disable-gdb is >> provided. >> * configure: Regenerate. >> --- >> configure | 4 +++- >> configure.ac | 4 +++- >> 2 files changed, 6 insertions(+), 2 deletions(-) >>=20 >> diff --git a/configure b/configure >> index d6716e38e99..85883099410 100755 >> --- a/configure >> +++ b/configure >> @@ -7913,7 +7913,9 @@ if test -d ${srcdir}/gcc ; then >> require_mpc=3Dyes >> fi >> if test -d ${srcdir}/gdb ; then >> - require_gmp=3Dyes >> + if test "x$enable_gdb" !=3D xno; then >> + require_gmp=3Dyes >> + fi >> fi >>=20 >> gmplibs=3D"-lmpfr -lgmp" >> diff --git a/configure.ac b/configure.ac >> index 737c1a1172b..2b612dce6e9 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1489,7 +1489,9 @@ if test -d ${srcdir}/gcc ; then >> require_mpc=3Dyes >> fi >> if test -d ${srcdir}/gdb ; then >> - require_gmp=3Dyes >> + if test "x$enable_gdb" !=3D xno; then >> + require_gmp=3Dyes >> + fi >> fi >>=20 >> gmplibs=3D"-lmpfr -lgmp" >> -- >> 2.25.1 >=20 > This patch has already been merged in the binutils repository see [1]. Ok for GCC=20 Richard=20 > [1] https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3D5fb0e3= 08577143ceb313fde5538dc9ecb038f29f >=20 > Thanks, > Cl=C3=A9ment