From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E7831396D82B for ; Mon, 3 Jun 2024 09:50:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7831396D82B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7831396D82B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717408233; cv=none; b=DP5RBbXYmfdaxSwijT9HFpnetdQmTEJAnktSzPsm3xu85Fu+Y/3c5vLmmuiJULjzIObuFkG/K6ko9SX8O9rZ+IwW4ny28oJB+LOhAZa/50Z+U9ti2d5f/V/N/Z6cE2YDT02lUCPpplkEDfpbJNpYK/TW+tKqQG7XeWa9MLNumdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717408233; c=relaxed/simple; bh=0ODM73KBAuQLw5EIONGyz6dF77d0dZQ+AEeVs04vQhg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kX4hvg0KVDdGCuMsk9GAL3RW1/LKgdLgclOENV6+6lVJsMlsJWLiZvGa2iCFgm0TB1/lUnYcU7JWcgevJgjNOZf4SmJau1U7JfDTpckJDIeXUu3kIXTt/MHZvtq0BUh949JbQLlgmn9UOXSbSBnBOTfWS2zzrnjMmrmd/sxi9Ck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4539PKfG027416; Mon, 3 Jun 2024 09:50:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pp1; bh=R0BJ+gfs9Yu2PGHEJmqo4wwBIVKVss+Neg3Hxnpy5oo=; b=qTc3zVhxhHyH1Hhg5D8ZWbzbWpsOnQQBBygHpcTHkaHVV2OJ+ze+GesxSefAQNDBA7tt lpPcOy/lJbqp1392rGwutJt9suqK046//Mm4Oen9+dKBEK97eXtixsw64UHDR+AZob2M H+UEaHNkvViunMjZzB8j7uYuoFO/KPqNn9VpzJzKfYR+wkgpfzQ5QtGUhPFbnmMMaWME CKA01b+7hTKXSmZVbtDx5C5OKi6wD+wcVZXGZ4hwwRWdNa+OtEwscXRJdvz7xhfDuKEJ bL9xSfMeVrpctPuCJ5F4E6nNutLKew29bgUgUpeVcSkQiCLmVgx4BIiCNMOJJp9rsWeD 6A== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yh9tq88pg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jun 2024 09:50:29 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4537GRHq022840; Mon, 3 Jun 2024 09:41:18 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ygg6kxrru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jun 2024 09:41:17 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4539fE8Y51708406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Jun 2024 09:41:16 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D6D02004E; Mon, 3 Jun 2024 09:41:14 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A72F20040; Mon, 3 Jun 2024 09:41:13 +0000 (GMT) Received: from [9.197.240.120] (unknown [9.197.240.120]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 3 Jun 2024 09:41:13 +0000 (GMT) Message-ID: <64730329-e402-254a-dad9-3e29cc797a84@linux.ibm.com> Date: Mon, 3 Jun 2024 17:41:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 17/52] gcn: Remove macros {FLOAT, DOUBLE, LONG_DOUBLE}_TYPE_SIZE Content-Language: en-US To: Andrew Stubbs References: <0348fc190a61972c782a3bff13716aec0ece2d76.1717134752.git.linkw@linux.ibm.com> <1c112e05-a4b2-44e0-be3b-b82139882585@baylibre.com> Cc: gcc-patches@gcc.gnu.org From: "Kewen.Lin" In-Reply-To: <1c112e05-a4b2-44e0-be3b-b82139882585@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 0YhpOHzguzhIVkjA46PBvuGgsoVxAyV4 X-Proofpoint-GUID: 0YhpOHzguzhIVkjA46PBvuGgsoVxAyV4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-06-03_06,2024-05-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 priorityscore=1501 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 mlxlogscore=900 mlxscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406030082 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrew, on 2024/6/3 17:14, Andrew Stubbs wrote: > On 03/06/2024 04:01, Kewen Lin wrote: >> This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE >> defines in gcn port. >> >> gcc/ChangeLog: >> >>     * config/gcn/gcn.h (FLOAT_TYPE_SIZE): Remove. >>     (DOUBLE_TYPE_SIZE): Likewise. >>     (LONG_DOUBLE_TYPE_SIZE): Likewise. > > > Assuming that this does not enable some long-double mode support that wasn't present before then this LGTM. Thanks! Yes, it doesn't, as the default hook implementation returns DFmode for long double type. > > GCN does have some partially implemented support for HFmode ... do I need to do something new for that to work? For this hook, no, as it's mainly for float, double and long double types (C language supported non decimal floating point types). If you are referring to _Float16, I guess you may be interested in another hook TARGET_FLOATN_MODE which is for FloatN types. BR, Kewen > > Andrew > >> --- >>   gcc/config/gcn/gcn.h | 3 --- >>   1 file changed, 3 deletions(-) >> >> diff --git a/gcc/config/gcn/gcn.h b/gcc/config/gcn/gcn.h >> index afa615320ca..e3bfd29c17d 100644 >> --- a/gcc/config/gcn/gcn.h >> +++ b/gcc/config/gcn/gcn.h >> @@ -111,9 +111,6 @@ >>   #define INT_TYPE_SIZE          32 >>   #define LONG_TYPE_SIZE          64 >>   #define LONG_LONG_TYPE_SIZE      64 >> -#define FLOAT_TYPE_SIZE          32 >> -#define DOUBLE_TYPE_SIZE      64 >> -#define LONG_DOUBLE_TYPE_SIZE      64 >>   #define DEFAULT_SIGNED_CHAR      1 >>   #define PCC_BITFIELD_TYPE_MATTERS 1 >>   >