From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11676 invoked by alias); 23 Jan 2016 09:41:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11657 invoked by uid 89); 23 Jan 2016 09:41:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 23 Jan 2016 09:41:04 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56012) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1aMugo-0001rf-OB for gcc-patches@gnu.org; Sat, 23 Jan 2016 04:41:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMugl-0002jm-6q for gcc-patches@gnu.org; Sat, 23 Jan 2016 04:41:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:36191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMugk-0002jI-W4 for gcc-patches@gnu.org; Sat, 23 Jan 2016 04:40:59 -0500 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 52D6BAB9D; Sat, 23 Jan 2016 09:40:56 +0000 (UTC) User-Agent: K-9 Mail for Android In-Reply-To: <56A34936.1040004@mentor.com> References: <56A34936.1040004@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH, PR69426] Fix clobber removal in parloops From: Richard Biener Date: Sat, 23 Jan 2016 09:41:00 -0000 To: Tom de Vries CC: "gcc-patches@gnu.org" Message-ID: <649F0761-3C5E-47E9-A8DB-9C902D3B41CC@suse.de> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-SW-Source: 2016-01/txt/msg01807.txt.bz2 On January 23, 2016 10:34:46 AM GMT+01:00, Tom de Vries wrote: >Hi, > >this patches fixes a 5/6 regression PR69426. > >When compiling the test-case in the patch, the verify_ssa todo check=20 >fails after removing a clobber in eliminate_local_variables_stmt. > >The problem is that the clobber is removed, but the uses of the=20 >corresponding vdef are not changed, and the virtual symbol is not >marked=20 >for renaming. > >[ The same happens in 4.9, but because omp_expand_local is called >before=20 >verify_ssa, the ICE does not happen. In 5.0 and later, we use a >separate=20 >expand_omp_ssa pass. ] > >This patch fixes the problem by replacing the uses of the vdef of the=20 >clobber by the vuse of the clobber. > >The patch uses replace_uses_by, but unlink_vdef_stmt also works, I'm >not=20 >sure which one to use. Unlink_stmt_vdef please. OK with that change. Richard. >Bootstrapped and reg-tested on x86_64. > >OK for trunk, gcc-5-branch? > >Thanks, >- Tom