From: Bernd Schmidt <bschmidt@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] rtx_writer: avoid printing trailing nils
Date: Fri, 04 Nov 2016 17:14:00 -0000 [thread overview]
Message-ID: <649c7a88-b39b-f040-d651-5655d65d0898@redhat.com> (raw)
In-Reply-To: <1478280773-2027-1-git-send-email-dmalcolm@redhat.com>
On 11/04/2016 06:32 PM, David Malcolm wrote:
> ASSERT_RTL_DUMP_EQ ("(cjump_insn 1 (set (pc)\n"
> " (label_ref 0))\n"
> - " (nil))\n",
> + " )\n",
> jump_insn);
This looks like the patch doesn't go the whole way - we'd want the space
savings from avoiding the newline.
You could consider giving the print_nil thing a default argument.
Bernd
next prev parent reply other threads:[~2016-11-04 17:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 23:49 RTL frontend, insn recognition, and pointer equality David Malcolm
2016-10-20 9:22 ` Bernd Schmidt
2016-10-20 11:02 ` Bernd Schmidt
2016-10-20 14:51 ` David Malcolm
2016-10-20 15:43 ` Bernd Schmidt
2016-10-21 0:05 ` [PATCH] Start adding selftests for print_rtx David Malcolm
2016-10-21 10:04 ` Bernd Schmidt
2016-10-21 17:14 ` [PATCH] Start adding target-specific selftests David Malcolm
2016-11-04 14:52 ` [Ping] " David Malcolm
2016-11-04 15:01 ` Bernd Schmidt
2016-11-04 17:01 ` [PATCH] rtx_writer: avoid printing trailing nils David Malcolm
2016-11-04 17:14 ` Bernd Schmidt [this message]
2016-11-04 17:51 ` Bernd Schmidt
2016-11-04 18:42 ` [PATCH] rtx_writer: avoid printing trailing default values David Malcolm
2016-11-04 18:53 ` Bernd Schmidt
2016-11-04 19:25 ` David Malcolm
2016-11-04 19:40 ` Bernd Schmidt
2016-11-07 15:23 ` David Malcolm
2016-10-21 19:56 ` [PATCH] print_rtx: implement support for reuse IDs David Malcolm
2016-10-25 12:47 ` Bernd Schmidt
2016-10-26 13:39 ` [PATCH] Introduce class rtx_writer David Malcolm
2016-10-26 14:12 ` Bernd Schmidt
2016-11-07 19:38 ` [PATCH] print_rtx: implement support for reuse IDs (v2) David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649c7a88-b39b-f040-d651-5655d65d0898@redhat.com \
--to=bschmidt@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).