From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00154904.pphosted.com (mx0a-00154904.pphosted.com [148.163.133.20]) by sourceware.org (Postfix) with ESMTPS id EAFA43858D38 for ; Fri, 14 Oct 2022 19:58:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EAFA43858D38 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=dell.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dell.com Received: from pps.filterd (m0170391.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EEui9x030495; Fri, 14 Oct 2022 15:58:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=smtpout1; bh=5qipOfpIH1Ra5FdA84sEO1CwKCAe1Odq6BwAmg8/2JY=; b=E6ki6jtlWx6ZbBXXOKwVzxh31RJTNv+eYIMdpag9UPDwvNKGtbKIotd1RkyAbEj/Iwd6 7L9i4sSzjmlC1AwfN4mPPP6sJBt8/A+CV61jSCw+84nO/c6tflTHHPRRVxXTh1Sc4XAg H814OkBJp8ifAPCqerJS4fqmC278B56uvl1x5gTcxNX52s5wwhhv+OO7jmCyOx4ay4Zw tiyuqe3xR1I0IVkCQhkhb1kjQxxWcQtKAQZNDp79YtSNMfLxXUWWMBp+oJXFWisfbwgU HzkEBHz9/VFsMfCx0N6FXvq5IOgQO03bOII5ITLUs5MSJrvJknuGUMcnD7/rwCrWGu6u Bw== Received: from mx0a-00154901.pphosted.com (mx0a-00154901.pphosted.com [67.231.149.39]) by mx0a-00154904.pphosted.com (PPS) with ESMTPS id 3k34c1c65s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 15:58:43 -0400 Received: from pps.filterd (m0142699.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EJqfBX028895; Fri, 14 Oct 2022 15:58:43 -0400 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2042.outbound.protection.outlook.com [104.47.57.42]) by mx0a-00154901.pphosted.com (PPS) with ESMTPS id 3k7de0rubj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Oct 2022 15:58:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dksR4VC73aZnl5AzYks0fnjkqXIrkAl9U4Ix4m8KOIivvyyvQiAoBbxsIqVK2O3iwLbKpIQZy0IW3KBXnGzQlsSt7S3g8f6xJjGOpCGMvjO49ckSfRy7pXyv8t+e+yKtatfVn1smAlByx5VV8xai8yIo9qQLeY39kaFopLCVTMpUfy/wBhiFn4h5kBoRglMniqpb9RWJN+qDxwIMVS5C7nZT2lU04FZUzxT/G/xvIrzrfw6oaV8/eHnoWwBRnG6RTypV403Upak7rexGERTs96KB5hHGO11k0OSGcUgnooAiq1jLJRTXBxWvqAbgmwwaR4oSZeYl4v4Zthw7zd18eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5qipOfpIH1Ra5FdA84sEO1CwKCAe1Odq6BwAmg8/2JY=; b=kyg8JOVxenOOG+SG9Y2LaCWvkmuuscbXsMtDBbrfJYACGnN86shijKAh6Yj36gSCAsaYxkFEXnAyc1tBTqQTlTP/eCzV/v2lkbaaiy78LjkT5/B57rsAn20dy0RQBsWJOBL0er9TbKhyy1C53g1q+IuOUlv2DJ+u1x1g7DuXszVgF8OgYJIsyT8hNqtv+juOL/KvvCLDpDRwxCcv/o2qvqNwjJjeAmqhZvE9/ldxhRTUQlzC80Fdy1SRcQ4s0xhlEJssi+sFv4oC3du/XuPKHI+3WVaSv+ZElt7wkkgRRsnbZ9tHxg7HFl1E6AzIaFVtRYPYw8ovTgfTlQjn+VD/XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dell.com; dmarc=pass action=none header.from=dell.com; dkim=pass header.d=dell.com; arc=none Received: from DS7PR19MB4501.namprd19.prod.outlook.com (2603:10b6:5:2c9::5) by SA1PR19MB6576.namprd19.prod.outlook.com (2603:10b6:806:253::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 14 Oct 2022 19:58:39 +0000 Received: from DS7PR19MB4501.namprd19.prod.outlook.com ([fe80::84ee:6d5:8ce:6efe]) by DS7PR19MB4501.namprd19.prod.outlook.com ([fe80::84ee:6d5:8ce:6efe%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022 19:58:39 +0000 From: "Koning, Paul" To: Jeff Law CC: Segher Boessenkool , GCC Patches Subject: Re: [PATCH] Always enable LRA Thread-Topic: [PATCH] Always enable LRA Thread-Index: AQHY4AdasfW38tlqNEeSXmr+CRVQOA== Date: Fri, 14 Oct 2022 19:58:39 +0000 Message-ID: <64E0D774-6501-4AD7-8F2A-9AD18CF36CB0@dell.com> References: <20221014163700.GE25951@gate.crashing.org> <20221014173516.GF25951@gate.crashing.org> <7b04be7e-d27d-0099-6631-6a764aed2cd7@gmail.com> In-Reply-To: <7b04be7e-d27d-0099-6631-6a764aed2cd7@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR19MB4501:EE_|SA1PR19MB6576:EE_ x-ms-office365-filtering-correlation-id: 614849d4-370c-4280-ab54-08daae1e7d23 x-exotenant: 2khUwGVqB6N9v58KS13ncyUmMJd8q4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: poI08u7W5I47EqzaMXSlLVYj3P2Eu8487rTb5ZLLUOe5+3HVzzUjZQeu/FvTuSN4A5sv23fhNvahlD1liTJoaxcoieH9mVHkOOUsjdg7CZtFVS7y614sRsEqrZ/GIUg7awHrvhj4AEoCSRyVcNApfv0rExhCC3fkS0K0K8xcb+DdfDR9yDAuvbaBW3/y4fA03SEREwEZpa/mDT+5jAVKgxCNtaNz6gZY+WHWZ8fy5DRvCtsIw9HFVv2qobzwi+iGEaes6Y8pwX1qKY6R7Nrs5OPLa+mguFuEWbZnU1qH/2mMbyKPelWBZ6TspRBcqjQj1aA6h1NtC67HmM4xwZbjspHj+7bsvrtNx1u3XHevl23m8E2Ug6TLLGQ9zuYnUkZ/feRIl3sBzgtDoV4St4bzIEziWXnfwtcOi4CW6I/H7W6vUFjMrNFMwhuR9DxgoM+JZMwvF4SN6Yui049Mnz3VpYOg61MOVrRyMA1KR7jAJh4qRvkDH26lNRTdUAFCAWZmRnegY6kskwVe3vMcLIaqJGgmcxODAZ1u/5iCHG3thQL0Sz0vy7UrimRuEEOrOdWUNLaCI0nSSn1JmShbpFHEpSbb9x10UzRR+7wjRg4sVNdB1E3ZXIqPmwtPmrjB0MZUWALN2ABEjT80aZwKkSQLXT/gJCNnMpXplU46sGoXDql01p/+qemKBZalhEWgr2zkhob96EvrpVeSz/6+t6jrO6zLnIa8vcLmMJ1WAKidZV48W/s9/P+MsOSpPj3ythUAjGJCJChkmzgcGM/Jad6WR2bTHxPhzv03Ssu35s0nXq4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR19MB4501.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199015)(2616005)(66476007)(36756003)(66946007)(8676002)(38070700005)(86362001)(41300700001)(66556008)(82960400001)(4326008)(64756008)(38100700002)(122000001)(76116006)(786003)(66446008)(316002)(71200400001)(5660300002)(33656002)(6512007)(186003)(6486002)(83380400001)(8936002)(2906002)(478600001)(54906003)(6916009)(53546011)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eCIN2ibcPuNKTCXXsGWbrGciSUs8oSMx/8Yn/3VuzMj2PP9bI0pq2h4ny4qf?= =?us-ascii?Q?lD+H4F7fCPwkfKR1k0NIj2OBF/G+flIkg+K4e8SsNmnqmKZ16DM5aewsqm4T?= =?us-ascii?Q?jqOctqIfFzhUMgPdeKaQmCcfoVIYY0TpnG7X8tyNqZeWDlBp/CSmcmWR+ne+?= =?us-ascii?Q?BfkVWwMf/IZJrK3AEANdfQLwDoBl3oUD96ILONs5sl/6+mDnC1uPazw+wa9r?= =?us-ascii?Q?8Y3xsYaPU1fosOce5CtHV8WMM8YJfliTL8e9UwvCIMf07SyNOdOaI38MEELy?= =?us-ascii?Q?bRN0oeyTncQDyblCVWxQE8wup0KSYz90ZpevYSwFj1fk2HkpUEraSrdKayFC?= =?us-ascii?Q?J0h1KNP5u5b9wf7MINDWCrpxgKGUsuREsOIZx3DLyrKqEeq0O7zKFAh4YudJ?= =?us-ascii?Q?6arFEp3P2AkoZ6Nae9Z/rR4AQrpMdjg8G7zv4CF/duB68Kt8yC4lu/m4OXUa?= =?us-ascii?Q?FPrenoxtPuYDOlg3TA5ILRGt4PlxErGmzuWKAcA5mdGHOdRIHjHEmowFU+z3?= =?us-ascii?Q?0jumYpBek2yhC4cO4zsUvYGjjTrOapLIP0+YIsBQDgs+erF5SjjDusQfHi8y?= =?us-ascii?Q?HKQkOjudx1LN5a42Btnf0FUbehAGMo061Cvrv6HHxOtfHQaRL8mir7AV2WF6?= =?us-ascii?Q?EkSGoLB/AD++tS2K29Zs9eSW5452JMJSyf0AYeBI+LIjkup8SvYzHwvM0qop?= =?us-ascii?Q?YhBoEVBCWJOKzGqaVUspVi54pXR9yWkT2cQHo/t0XkS+pkRdNrlwpbOqrMJI?= =?us-ascii?Q?KXj6QM4QbZkdvL7dfyo5rUMZRqGHQ/l9u2gS6DRGMFi8nuoAhvM5Q4oEFuQ1?= =?us-ascii?Q?mAQ8I6p2SgKdGjvV4SrduaQzfU4KjyK3W9Q+pidlDHQQebpznyLKnB8zkUor?= =?us-ascii?Q?+QhYeGvccdSqSaMu9ys9Xb1GPQ4WofDv2JHv6iixTgUqmrZfvaMapuMXyrKE?= =?us-ascii?Q?gZNuQVOwNjt5eNL9pBB0ogNn6SaPeZvovZtFAx3l1F4lwH4AgA8+TeuqnAE1?= =?us-ascii?Q?BY5bqY+zIJZRl36ph4TC7Tg1iX0kU8aFN0EhnCVU0uq6sMArGK/qxeJX35Aj?= =?us-ascii?Q?Psi2Kz6Trx420UR+VxgIrL6noYVgEYGNk8IsNo/Xx/GWe0jqkHj8nRo7le76?= =?us-ascii?Q?wom8gWI7S5mqhaqAL1bbRDDKYnzj/wV2nd5wTA9hqnrGlQvYFHyqkTzAfoXv?= =?us-ascii?Q?KV/5cCijzxtyukePy73/rL5cxgie5nanRJvflRdHV/eU9QjeMBvVjYNUadrQ?= =?us-ascii?Q?L9diXCETJTANH81xIIV1Gk8aBVi3+57BuzPMEejAO0yje4irt5yeMjabiqse?= =?us-ascii?Q?hB0icb9zny/qND+KotObkQY6ve2H38wZ03ux82PXa5g0mTktoUKEng4lwq8K?= =?us-ascii?Q?XUO/wIewkU0NhMKzNa2eImusYLZyIlXJeZuczk1Y6QarUZEQK2na8qdWBovg?= =?us-ascii?Q?H89Ob3kktPpwhqVfWN49HNgimTtUBtHat5qd/oAtDOc+4KHZPo8+PLquzKk9?= =?us-ascii?Q?nHg5daw/JPGixkqnyaxFbMCRBY9N7dxqsDaSnfi/ifPDHoISOpGbDuglpofY?= =?us-ascii?Q?q3MJX2UBlluxW6IdhNKhmU+3Pv4n/9IYQEu1VL7EsHqQIAYF13FkgPV5M1Mh?= =?us-ascii?Q?nYnKpVhBLIN4PjTp3yIGIynDchXfoFSBdXPxoY3xJLBTZuPLcM9+ARS8FlPb?= =?us-ascii?Q?mb9EzQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <7DF9533E6703DB45811BF24F62AF5843@namprd19.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Dell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR19MB4501.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 614849d4-370c-4280-ab54-08daae1e7d23 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 19:58:39.7463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 945c199a-83a2-4e80-9f8c-5a91be5752dd X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kmg002HAZG/8QTyFs8dFVBWrqMr6X2W9DMeNawdroSVy3O53HabMGVN3Ny6L70+m7FniBW9PmI8PduH7r2YvLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR19MB6576 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_10,2022-10-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 clxscore=1015 mlxscore=0 mlxlogscore=920 bulkscore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210140109 X-Proofpoint-GUID: mmeYQm14Crdx_cGnYrKwy0QU7C3gU2wB X-Proofpoint-ORIG-GUID: mmeYQm14Crdx_cGnYrKwy0QU7C3gU2wB X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210140109 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Oct 14, 2022, at 2:03 PM, Jeff Law via Gcc-patches wrote: >=20 >=20 > On 10/14/22 11:35, Segher Boessenkool wrote: >> On Fri, Oct 14, 2022 at 11:07:43AM -0600, Jeff Law wrote: >>>> LRA only ever generates insns that pass recog. The backend allows thi= s >>>> define_insn, requiring it to be split (it returns template "#"), but >>>> then somehow it doesn't match in any split pass? >>> Nope. The elimination code will just change one register without >>> re-recognizing. That's precisely what happens here. >> That is a big oversight then. Please file a PR? >=20 > Sure. But just recognizing (for this particular case) will just move the= fault from a failure to split to a failure to recognize. From my wandering= s in the elimination code, I don't see that it has a path that would allow = it to reasonably handle this case -- ie, if the insn does not recognize, wh= at then? Conceptually we need to generate an input-reload but I don't see= a way to do that in the elimination code. Maybe Vlad knows how it ought t= o be handled. I probably have too simplistic a view of this, but the way I think of it is= that LRA (and reload) make decisions subject to constraints, and among tho= se constraints are the ones specified in the MD file patterns. That to me = means that a substitution proposed to be made by the LRA code is subject to= those invariants: it can't do that if the constraints say "no" and must th= en consider some other alternative. paul