From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 36AF93858D1E for ; Wed, 10 Aug 2022 11:10:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36AF93858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 264AB373C2; Wed, 10 Aug 2022 11:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1660129824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZbRW2jGu2zweBc+Uj9JFSWqyNUjvU0wbcakeFngakJw=; b=XyLLK9de+8Xild5v7UllTxP4ec8hmMmb3x13tMQSLRtQUwGAvAALg6olOIkG2VRF9er4pq S2GFPplpT8sKMnJjvwQy3alFZGMPWTUfhOgNdimfPwofwtVwJFUiWNGoBHCjQ8QMG18QyL V+mEly2HwdUFt5ZOWI7idUzzrW/+jsw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1660129824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZbRW2jGu2zweBc+Uj9JFSWqyNUjvU0wbcakeFngakJw=; b=xj2kxJJ2/QNwSJDfSGecdzG05wRJbxRSJWGz6XsNkBq42dWn8rKmNG9sVLqsy/b23gUtc5 UGIJ8+THSCPrmCAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0FE6D13A7E; Wed, 10 Aug 2022 11:10:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8graAiCS82JgUAAAMHmgww (envelope-from ); Wed, 10 Aug 2022 11:10:24 +0000 Content-Type: multipart/mixed; boundary="------------rwXE1Mly87drnVULvo10km0w" Message-ID: <651929b1-ac7b-a849-249f-7078d4699532@suse.cz> Date: Wed, 10 Aug 2022 13:10:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH 3/3] lto: respect jobserver in parallel WPA streaming Content-Language: en-US To: Richard Biener Cc: GCC Patches References: <95d2ec7222d50c8ca1e6535cb8c272d47abbb08d.1660046383.git.mliska@suse.cz> <7ad7af4bb978bffdbc220c754002c667df1b0209.1660046383.git.mliska@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 11:10:27 -0000 This is a multi-part message in MIME format. --------------rwXE1Mly87drnVULvo10km0w Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/10/22 12:52, Richard Biener wrote: > If it's not a template and the methods not inline won't we get multiple > definition errors when this include file is included in multiple places > from an executable? opts-common.cc might be a good place to > stuff it, and opts.h to declare (if it were not for std::string, so possibly > jobserver.h is good enough, or opts-jobserver.h?) Works for me, updated in v2. Martin --------------rwXE1Mly87drnVULvo10km0w Content-Type: text/x-patch; charset=UTF-8; name="0003-lto-respect-jobserver-in-parallel-WPA-streaming.patch" Content-Disposition: attachment; filename*0="0003-lto-respect-jobserver-in-parallel-WPA-streaming.patch" Content-Transfer-Encoding: base64 RnJvbSBmZjIwNzNlMWY1NDlkZjQwYTVlODU5ZTJjZGU5YTQwMzMwN2MxOTYwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUdWUsIDkgQXVnIDIwMjIgMTM6NTk6MzkgKzAyMDAKU3ViamVjdDogW1BBVENIIDMv M10gbHRvOiByZXNwZWN0IGpvYnNlcnZlciBpbiBwYXJhbGxlbCBXUEEgc3RyZWFtaW5nCgoJ UFIgbHRvLzEwNjMyOAoKZ2NjL0NoYW5nZUxvZzoKCgkqIG9wdHMtam9ic2VydmVyLmggKHN0 cnVjdCBqb2JzZXJ2ZXJfaW5mbyk6IEFkZCBwaXBlZmQuCgkoam9ic2VydmVyX2luZm86OmNv bm5lY3QpOiBOZXcuCgkoam9ic2VydmVyX2luZm86OmRpc2Nvbm5lY3QpOiBMaWtld2lzZS4K CShqb2JzZXJ2ZXJfaW5mbzo6Z2V0X3Rva2VuKTogTGlrZXdpc2UuCgkoam9ic2VydmVyX2lu Zm86OnJldHVybl90b2tlbik6IExpa2V3aXNlLgoJKiBvcHRzLWNvbW1vbi5jYzogSW1wbGVt ZW50IHRoZSBuZXcgZnVuY3Rpb25zLgoKZ2NjL2x0by9DaGFuZ2VMb2c6CgoJKiBsdG8uY2Mg KHdhaXRfZm9yX2NoaWxkKTogRGVjcmVtZW50IG5ydW5zIG9uY2UgYSBwcm9jZXNzCglmaW5p c2hlcy4KCShzdHJlYW1fb3V0X3BhcnRpdGlvbnMpOiBVc2Ugam9iIHNlcnZlciBpZiBhY3Rp dmUuCgkoZG9fd2hvbGVfcHJvZ3JhbV9hbmFseXNpcyk6IExpa2V3aXNlLgotLS0KIGdjYy9s dG8vbHRvLmNjICAgICAgIHwgNTggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0KIGdjYy9vcHRzLWNvbW1vbi5jYyAgIHwgNDIgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKIGdjYy9vcHRzLWpvYnNlcnZlci5oIHwgMTQgKysrKysrKysr KysKIDMgZmlsZXMgY2hhbmdlZCwgMTAwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2djYy9sdG8vbHRvLmNjIGIvZ2NjL2x0by9sdG8uY2MKaW5kZXgg MzFiMGMxODYyZjcuLmM4MjMwN2Y0ZjdlIDEwMDY0NAotLS0gYS9nY2MvbHRvL2x0by5jYwor KysgYi9nY2MvbHRvL2x0by5jYwpAQCAtMTgsNiArMTgsNyBAQCBZb3Ugc2hvdWxkIGhhdmUg cmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQogYWxv bmcgd2l0aCBHQ0M7IHNlZSB0aGUgZmlsZSBDT1BZSU5HMy4gIElmIG5vdCBzZWUKIDxodHRw Oi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4gICovCiAKKyNkZWZpbmUgSU5DTFVERV9TVFJJ TkcKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJzeXN0ZW0uaCIKICNpbmNsdWRl ICJjb3JldHlwZXMuaCIKQEAgLTU0LDExICs1NSwxNyBAQCBhbG9uZyB3aXRoIEdDQzsgc2Vl IHRoZSBmaWxlIENPUFlJTkczLiAgSWYgbm90IHNlZQogI2luY2x1ZGUgImF0dHJpYnMuaCIK ICNpbmNsdWRlICJidWlsdGlucy5oIgogI2luY2x1ZGUgImx0by1jb21tb24uaCIKKyNpbmNs dWRlICJvcHRzLWpvYnNlcnZlci5oIgogCi0KLS8qIE51bWJlciBvZiBwYXJhbGxlbCB0YXNr cyB0byBydW4sIC0xIGlmIHdlIHdhbnQgdG8gdXNlIEdOVSBNYWtlIGpvYnNlcnZlci4gICov CisvKiBOdW1iZXIgb2YgcGFyYWxsZWwgdGFza3MgdG8gcnVuLiAgKi8KIHN0YXRpYyBpbnQg bHRvX3BhcmFsbGVsaXNtOwogCisvKiBOdW1iZXIgb2YgYWN0aXZlIFdQQSBzdHJlYW1pbmcg cHJvY2Vzc2VzLiAgKi8KK3N0YXRpYyBpbnQgbnJ1bnMgPSAwOworCisvKiBHTlUgbWFrZSdz IGpvYnNlcnZlciBpbmZvLiAgKi8KK3N0YXRpYyBqb2JzZXJ2ZXJfaW5mbyAqamluZm8gPSBO VUxMOworCiAvKiBSZXR1cm4gdHJ1ZSB3aGVuIE5PREUgaGFzIGEgY2xvbmUgdGhhdCBpcyBh bmFseXplZCAoaS5lLiB3ZSBuZWVkCiAgICB0byBsb2FkIGl0cyBib2R5IGV2ZW4gaWYgdGhl IG5vZGUgaXRzZWxmIGlzIG5vdCBuZWVkZWQpLiAgKi8KIApAQCAtMjA1LDYgKzIxMiwxMiBA QCB3YWl0X2Zvcl9jaGlsZCAoKQogCQkgICAgICJzdHJlYW1pbmcgc3VicHJvY2VzcyB3YXMg a2lsbGVkIGJ5IHNpZ25hbCIpOwogICAgIH0KICAgd2hpbGUgKCFXSUZFWElURUQgKHN0YXR1 cykgJiYgIVdJRlNJR05BTEVEIChzdGF0dXMpKTsKKworICAgIC0tbnJ1bnM7CisKKyAgICAv KiBSZXR1cm4gdG9rZW4gdG8gdGhlIGpvYnNlcnZlciBpZiBhY3RpdmUuICAqLworICAgIGlm IChqaW5mbyAhPSBOVUxMICYmIGppbmZvLT5pc19hY3RpdmUpCisgICAgICBqaW5mby0+cmV0 dXJuX3Rva2VuICgpOwogfQogI2VuZGlmCiAKQEAgLTIyOCwyNSArMjQxLDM1IEBAIHN0cmVh bV9vdXRfcGFydGl0aW9ucyAoY2hhciAqdGVtcF9maWxlbmFtZSwgaW50IGJsZW4sIGludCBt aW4sIGludCBtYXgsCiAJCSAgICAgICBib29sIEFSR19VTlVTRUQgKGxhc3QpKQogewogI2lm ZGVmIEhBVkVfV09SS0lOR19GT1JLCi0gIHN0YXRpYyBpbnQgbnJ1bnM7Ci0KICAgaWYgKGx0 b19wYXJhbGxlbGlzbSA8PSAxKQogICAgIHsKICAgICAgIHN0cmVhbV9vdXRfcGFydGl0aW9u c18xICh0ZW1wX2ZpbGVuYW1lLCBibGVuLCBtaW4sIG1heCk7CiAgICAgICByZXR1cm47CiAg ICAgfQogCi0gIC8qIERvIG5vdCBydW4gbW9yZSB0aGFuIExUT19QQVJBTExFTElTTSBzdHJl YW1pbmdzCi0gICAgIEZJWE1FOiB3ZSBpZ25vcmUgbGltaXRzIG9uIGpvYnNlcnZlci4gICov CiAgIGlmIChsdG9fcGFyYWxsZWxpc20gPiAwICYmIG5ydW5zID49IGx0b19wYXJhbGxlbGlz bSkKLSAgICB7Ci0gICAgICB3YWl0X2Zvcl9jaGlsZCAoKTsKLSAgICAgIG5ydW5zIC0tOwot ICAgIH0KKyAgICB3YWl0X2Zvcl9jaGlsZCAoKTsKKwogICAvKiBJZiB0aGlzIGlzIG5vdCB0 aGUgbGFzdCBwYXJhbGxlbCBwYXJ0aXRpb24sIGV4ZWN1dGUgbmV3CiAgICAgIHN0cmVhbWlu ZyBwcm9jZXNzLiAgKi8KICAgaWYgKCFsYXN0KQogICAgIHsKKyAgICAgIGlmIChqaW5mbyAh PSBOVUxMICYmIGppbmZvLT5pc19hY3RpdmUpCisJd2hpbGUgKHRydWUpCisJICB7CisJICAg IGlmIChqaW5mby0+Z2V0X3Rva2VuICgpKQorCSAgICAgIGJyZWFrOworCSAgICBpZiAobnJ1 bnMgPiAwKQorCSAgICAgIHdhaXRfZm9yX2NoaWxkICgpOworCSAgICBlbHNlCisJICAgICAg eworCQkvKiBUaGVyZSBhcmUgbm8gZnJlZSB0b2tlbnMsIGxldHMgZG8gdGhlIGpvYiBvdXRz ZWx2ZXMuICAqLworCQlzdHJlYW1fb3V0X3BhcnRpdGlvbnNfMSAodGVtcF9maWxlbmFtZSwg YmxlbiwgbWluLCBtYXgpOworCQlhc21fbm9kZXNfb3V0cHV0ID0gdHJ1ZTsKKwkJcmV0dXJu OworCSAgICAgIH0KKwkgIH0KKwogICAgICAgcGlkX3QgY3BpZCA9IGZvcmsgKCk7CiAKICAg ICAgIGlmICghY3BpZCkKQEAgLTI2NCwxMCArMjg3LDEyIEBAIHN0cmVhbV9vdXRfcGFydGl0 aW9ucyAoY2hhciAqdGVtcF9maWxlbmFtZSwgaW50IGJsZW4sIGludCBtaW4sIGludCBtYXgs CiAgIC8qIExhc3QgcGFydGl0aW9uOyBzdHJlYW0gaXQgYW5kIHdhaXQgZm9yIGFsbCBjaGls ZHJlbiB0byBkaWUuICAqLwogICBlbHNlCiAgICAgewotICAgICAgaW50IGk7CiAgICAgICBz dHJlYW1fb3V0X3BhcnRpdGlvbnNfMSAodGVtcF9maWxlbmFtZSwgYmxlbiwgbWluLCBtYXgp OwotICAgICAgZm9yIChpID0gMDsgaSA8IG5ydW5zOyBpKyspCisgICAgICB3aGlsZSAobnJ1 bnMgPiAwKQogCXdhaXRfZm9yX2NoaWxkICgpOworCisgICAgICBpZiAoamluZm8gIT0gTlVM TCAmJiBqaW5mby0+aXNfYWN0aXZlKQorCWppbmZvLT5kaXNjb25uZWN0ICgpOwogICAgIH0K ICAgYXNtX25vZGVzX291dHB1dCA9IHRydWU7CiAjZWxzZQpAQCAtNDYwLDkgKzQ4NSwxNCBA QCBkb193aG9sZV9wcm9ncmFtX2FuYWx5c2lzICh2b2lkKQogCiAgIGx0b19wYXJhbGxlbGlz bSA9IDE7CiAKLSAgLyogVE9ETzogam9ic2VydmVyIGNvbW11bmljYXRpb24gaXMgbm90IHN1 cHBvcnRlZCwgeWV0LiAgKi8KICAgaWYgKCFzdHJjbXAgKGZsYWdfd3BhLCAiam9ic2VydmVy IikpCi0gICAgbHRvX3BhcmFsbGVsaXNtID0gcGFyYW1fbWF4X2x0b19zdHJlYW1pbmdfcGFy YWxsZWxpc207CisgICAgeworICAgICAgamluZm8gPSBuZXcgam9ic2VydmVyX2luZm8gKCk7 CisgICAgICBpZiAoamluZm8tPmlzX2FjdGl2ZSkKKwlqaW5mby0+Y29ubmVjdCAoKTsKKwor ICAgICAgbHRvX3BhcmFsbGVsaXNtID0gcGFyYW1fbWF4X2x0b19zdHJlYW1pbmdfcGFyYWxs ZWxpc207CisgICAgfQogICBlbHNlCiAgICAgewogICAgICAgbHRvX3BhcmFsbGVsaXNtID0g YXRvaSAoZmxhZ193cGEpOwpkaWZmIC0tZ2l0IGEvZ2NjL29wdHMtY29tbW9uLmNjIGIvZ2Nj L29wdHMtY29tbW9uLmNjCmluZGV4IGMyOTkzZjkxNDBhLi42YzkzNTVmNjM3MiAxMDA2NDQK LS0tIGEvZ2NjL29wdHMtY29tbW9uLmNjCisrKyBiL2djYy9vcHRzLWNvbW1vbi5jYwpAQCAt MjA1OSwzICsyMDU5LDQ1IEBAIGpvYnNlcnZlcl9pbmZvOjpqb2JzZXJ2ZXJfaW5mbyAoKQog ICBpZiAoIWVycm9yX21zZy5lbXB0eSAoKSkKICAgICBlcnJvcl9tc2cgPSAiam9ic2VydmVy IGlzIG5vdCBhdmFpbGFibGU6ICIgKyBlcnJvcl9tc2c7CiB9CisKK3ZvaWQKK2pvYnNlcnZl cl9pbmZvOjpjb25uZWN0ICgpCit7CisgIGlmICghcGlwZV9wYXRoLmVtcHR5ICgpKQorICAg IHBpcGVmZCA9IG9wZW4gKHBpcGVfcGF0aC5jX3N0ciAoKSwgT19SRFdSKTsKK30KKwordm9p ZAoram9ic2VydmVyX2luZm86OmRpc2Nvbm5lY3QgKCkKK3sKKyAgaWYgKCFwaXBlX3BhdGgu ZW1wdHkgKCkpCisgICAgeworICAgICAgZ2NjX2Fzc2VydCAoY2xvc2UgKHBpcGVmZCkgPT0g MCk7CisgICAgICBwaXBlZmQgPSAtMTsKKyAgICB9Cit9CisKK2Jvb2wKK2pvYnNlcnZlcl9p bmZvOjpnZXRfdG9rZW4gKCkKK3sKKyAgaW50IGZkID0gcGlwZV9wYXRoLmVtcHR5ICgpID8g cmZkIDogcGlwZWZkOworICBjaGFyIGM7CisgIHVuc2lnbmVkIG4gPSByZWFkIChmZCwgJmMs IDEpOworICBpZiAobiAhPSAxKQorICAgIHsKKyAgICAgIGdjY19hc3NlcnQgKGVycm5vID09 IEVBR0FJTik7CisgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorICBlbHNlCisgICAgcmV0 dXJuIHRydWU7Cit9CisKK3ZvaWQKK2pvYnNlcnZlcl9pbmZvOjpyZXR1cm5fdG9rZW4gKCkK K3sKKyAgaW50IGZkID0gcGlwZV9wYXRoLmVtcHR5ICgpID8gd2ZkIDogcGlwZWZkOworICBj aGFyIGMgPSAnRyc7CisgIGdjY19hc3NlcnQgKHdyaXRlIChmZCwgJmMsIDEpID09IDEpOwor fQorCisKZGlmZiAtLWdpdCBhL2djYy9vcHRzLWpvYnNlcnZlci5oIGIvZ2NjL29wdHMtam9i c2VydmVyLmgKaW5kZXggOThlYTI1Nzk5NjIuLjc2YzFkOWIyODgyIDEwMDY0NAotLS0gYS9n Y2Mvb3B0cy1qb2JzZXJ2ZXIuaAorKysgYi9nY2Mvb3B0cy1qb2JzZXJ2ZXIuaApAQCAtMjks NiArMjksMTggQEAgc3RydWN0IGpvYnNlcnZlcl9pbmZvCiAgIC8qIERlZmF1bHQgY29uc3Ry dWN0b3IuICAqLwogICBqb2JzZXJ2ZXJfaW5mbyAoKTsKIAorICAvKiBDb25uZWN0IHRvIHRo ZSBzZXJ2ZXIuICAqLworICB2b2lkIGNvbm5lY3QgKCk7CisKKyAgLyogRGlzY29ubmVjdCBm cm9tIHRoZSBzZXJ2ZXIuICAqLworICB2b2lkIGRpc2Nvbm5lY3QgKCk7CisKKyAgLyogR2V0 IHRva2VuIGZyb20gdGhlIHNlcnZlci4gICovCisgIGJvb2wgZ2V0X3Rva2VuICgpOworCisg IC8qIFJldHVybiB0b2tlbiB0byB0aGUgc2VydmVyLiAgKi8KKyAgdm9pZCByZXR1cm5fdG9r ZW4gKCk7CisKICAgLyogRXJyb3IgbWVzc2FnZSBpZiB0aGVyZSBpcyBhIHByb2JsZW0uICAq LwogICBzdHJpbmcgZXJyb3JfbXNnID0gIiI7CiAgIC8qIFNraXBwZWQgTUFLRUZMQUdTIHdo ZXJlIC0tam9ic2VydmVyLWF1dGggaXMgc2tpcHBlZC4gICovCkBAIC0zOSw2ICs1MSw4IEBA IHN0cnVjdCBqb2JzZXJ2ZXJfaW5mbwogICBpbnQgd2ZkID0gLTE7CiAgIC8qIE5hbWVkIHBp cGUgcGF0aC4gICovCiAgIHN0cmluZyBwaXBlX3BhdGggPSAiIjsKKyAgLyogUGlwZSBmaWxl IGRlc2NyaXB0b3IuICAqLworICBpbnQgcGlwZWZkID0gLTE7CiAgIC8qIFJldHVybiB0cnVl IGlmIGpvYnNlcnZlciBpcyBhY3RpdmUuICAqLwogICBib29sIGlzX2FjdGl2ZSA9IGZhbHNl OwogfTsKLS0gCjIuMzcuMQoK --------------rwXE1Mly87drnVULvo10km0w--