From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by sourceware.org (Postfix) with ESMTPS id 189513858C2F for ; Wed, 26 Jul 2023 22:46:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 189513858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-56661fe27cbso256600eaf.3 for ; Wed, 26 Jul 2023 15:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690411579; x=1691016379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YzWvJk8kqR36wK91CI2slqDhKMToLy6iDBhkvhYddes=; b=I2jWvRbUeSIco+BxavwTqKnnS185OESuajQSjQBAUJl2mP7g0rF98n26w6Ks7S8dG5 nV6GUXXS2+dDcYYHJHvUxo2N/eLWNejzbVyQhY+EgiG8xez0zOKgLxhE7LKeFgc0SBwC BqQDHKH8TEihHY+TMO/0wl9rc0ZZdNV3zOqx2eZVRGWrTXFE+IZK8FmJ1h0BmMe/N33/ jXb8zUI5GOLCdceXXAts0cKXzR9gKLDRF5wZ5kYH3VHG20FgP1beMhwhQ+oJ/h5iTstg 7C7EwsPW+6yrC+CHs+l+C/v5NSiA9Gttw1IqsOsDNUFWv4Tg3A0mkRjI2pZzbeYMsFzt Rq5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690411579; x=1691016379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YzWvJk8kqR36wK91CI2slqDhKMToLy6iDBhkvhYddes=; b=Dyw/VbjtYaEmp5xaaFvjvGxDB/lme/m/Vcrqv08hvyXEkCK3+RKx1VzUg7Db+ywzd5 vuAGJ9UGzQDBX2AqNZ2nZZKnSYuZA8GKaD4vp1aHnYBXE7DpHKfBVrIZ3SErbAYG2X0O pyNyPzgNlETEAUbhd1PriFjbFiLsOZUidiJBHoF38N6UKyCS92vxB4sNyzvU1+rwBkZu P0zHccY34Ecvq9R0RbX3oGm8XJI1tQD7nUooIvFX86MKSNnUilz4qP6ZKDPFKDq7LCif Xen36M5b5OpRvqQk9aclafoLGsJdPOpbRwv6CLWkLDoMkbL+uo4QZ+1Wp57S4huOV+jc EMkw== X-Gm-Message-State: ABy/qLYoeNcZ8W5a+XpEB9vb5vfwSM0cGz0KYHkGm+FGnxcgwS6xuPBc x9l3C5grfn2qPNQthCvl8YM= X-Google-Smtp-Source: APBJJlFt8uPYVAX4H7ykA1WznzQVUozjR9Vujc5o2IH/rJ4IpHKyMAIHZbzEVDd+5w5hzsPHTJjZjw== X-Received: by 2002:a05:6358:7f07:b0:123:5664:e493 with SMTP id p7-20020a0563587f0700b001235664e493mr447937rwn.27.1690411579173; Wed, 26 Jul 2023 15:46:19 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id q17-20020a638c51000000b0050f85ef50d1sm27895pgn.26.2023.07.26.15.46.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 15:46:18 -0700 (PDT) Message-ID: <6522f98c-ae29-d98e-bfcd-4373f739a5c2@gmail.com> Date: Wed, 26 Jul 2023 16:46:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , "rdapp.gcc" , "kito.cheng" , "pan2.li" Cc: gcc-patches , "yanzhang.wang" References: <20230719032822.85817-1-pan2.li@intel.com> <20230725055156.595718-1-pan2.li@intel.com> <2a9db9ea-ba9e-264c-fe2f-c44bb8f9d580@gmail.com> <911144fa-47f1-4607-0795-fac42de680fe@gmail.com> <529F26698FF45F91+2023072706212780501559@rivai.ai> From: Jeff Law In-Reply-To: <529F26698FF45F91+2023072706212780501559@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/26/23 16:21, 钟居哲 wrote: > Hi, Jeff. > > insert_insn_end_basic_block is to handle this following case: > > bb 1: > ... > CALL.---->BB_END of bb > bb 2: > vfadd rne > > You can see there is no instructions after CALL. > > So you we use insert_insn_end_basic_block insert a "frrm" at the end of > the bb 1. > > I know typically it's better to insert a edge between bb 1 and bb 2, > then put "frrm" in that edgen. > However, it causes ICE. We'd need to know the reason for the ICE. > > If we really need to follow this approach, it seems that we need to > modify the "mode_sw" PASS? > Currently, we are avoiding changing the codes of PASS. Generally wise, but sometimes we do need to change generic bits. Let's dive a bit into this. We have more freedom here to loosen the profitability constraints since its a target specific pass, but let's at least understand the what's going on with the ICE, then make some decisions about the best way forward. jeff