Re: [PATCH] gccrs: avoid printing to stderr in selftest::rust_flatten_list

[Arthur Cohen <arthur.cohen@embecosm.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1483 bytes --]

Hi David,

Sorry for the delayed reply!

On 12/16/22 18:01, David Malcolm wrote:
> Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
> 
> OK for trunk?
> 
> gcc/rust/ChangeLog:
> 	* resolve/rust-ast-resolve-item.cc (selftest::rust_flatten_list):
> 	Remove output to stderr.
> 
> Signed-off-by: David Malcolm <dmalcolm@redhat.com>
> ---
>   gcc/rust/resolve/rust-ast-resolve-item.cc | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/gcc/rust/resolve/rust-ast-resolve-item.cc b/gcc/rust/resolve/rust-ast-resolve-item.cc
> index 0c38f28d530..1276e845acc 100644
> --- a/gcc/rust/resolve/rust-ast-resolve-item.cc
> +++ b/gcc/rust/resolve/rust-ast-resolve-item.cc
> @@ -1202,9 +1202,6 @@ rust_flatten_list (void)
>     auto paths = std::vector<Rust::AST::SimplePath> ();
>     Rust::Resolver::flatten_list (list, paths);
>   
> -  for (auto &path : paths)
> -    fprintf (stderr, "%s\n", path.as_string ().c_str ());
> -
>     ASSERT_TRUE (!paths.empty ());
>     ASSERT_EQ (paths.size (), 2);
>     ASSERT_EQ (paths[0].get_segments ()[0].as_string (), "foo");

Looks good to me. OK for trunk :)

Thanks for taking the time!

All the best,

-- 
Arthur Cohen <arthur.cohen@embecosm.com>

Toolchain Engineer

Embecosm GmbH

Geschäftsführer: Jeremy Bennett
Niederlassung: Nürnberg
Handelsregister: HR-B 36368
www.embecosm.de

Fürther Str. 27
90429 Nürnberg


Tel.: 091 - 128 707 040
Fax: 091 - 128 707 077

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3195 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]