From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 676443858C53 for ; Wed, 24 Jan 2024 09:58:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 676443858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 676443858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706090326; cv=none; b=wl9tcKEudIRmgVcLCb1nCa3LOsT29emB+w3UYoMHCmNXe/oGnn/sIst9a3CBRRGqHmby767+NraJrh+47Am8bFXP/P7++7MCTVdgN5u7zNQH2/i51KsoQfA0Glfu443svsPc+yu6yDBXoKBlSlO4Y4HIoRlGKV9+zk853PvTtCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706090326; c=relaxed/simple; bh=KrWe07AxGLV+heYQJ9wwqFe+HpVEYNyjMecFAY+/e1s=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=Ecr2YRSKhTznF/arTacKBz3/lPhOgWuuLxeuD/3Och0Nef9IH+fkEeLvZQn9UZ+KCmNb1YfD04iT9AFbELVd2xsv/ezFa8wgUgIyA7xp/lKx0921w3XV35B3VeXaXmzMlwqM866ZovC4i8joEmy+ioNo1DzQ2oF8e+zI46cwnkQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.105]) by gateway (Coremail) with SMTP id _____8CxbetQ37BlUbAEAA--.18824S3; Wed, 24 Jan 2024 17:58:40 +0800 (CST) Received: from [10.20.4.105] (unknown [10.20.4.105]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxRMxQ37BlCKMWAA--.25616S3; Wed, 24 Jan 2024 17:58:40 +0800 (CST) Subject: Re: [PATCH] LoongArch: Fix incorrect return type for frecipe/frsqrte intrinsic functions To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, chenglulu@loongson.cn, xuchenghua@loongson.cn References: <20240124091932.38877-1-xujiahao@loongson.cn> <291eac07320a425b5e6ce26d801bde2c2d5f4cdd.camel@xry111.site> From: Jiahao Xu Message-ID: <6574fefa-1c6f-a6d2-d332-74808fe22dee@loongson.cn> Date: Wed, 24 Jan 2024 17:58:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <291eac07320a425b5e6ce26d801bde2c2d5f4cdd.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxRMxQ37BlCKMWAA--.25616S3 X-CM-SenderInfo: 50xmxthkdrqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7uF4kJF43ZFWkurW5CrykZwc_yoW8Gry5pF yDC3ZIyr48uFZ7WFyDZ343Wwn0vrZxJw129Fyag340kF17J34IqF43KrsxXFn8G3ykJF4S vrWfK3s09a15Z3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9ab4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWU CwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsG vfC2KfnxnUUI43ZEXa7IU8j-e5UUUUU== X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2024/1/24 下午5:48, Xi Ruoyao 写道: > On Wed, 2024-01-24 at 17:19 +0800, Jiahao Xu wrote: >> gcc/ChangeLog: >> >> * config/loongarch/larchintrin.h >> (__frecipe_s): Update function return type. >> (__frecipe_d): Ditto. >> (__frsqrte_s): Ditto. >> (__frsqrte_d): Ditto. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/loongarch/larch-frecipe-intrinsic.c: New test. >> >> diff --git a/gcc/config/loongarch/larchintrin.h b/gcc/config/loongarch/larchintrin.h >> index 7692415e04d..ff2c9f460ac 100644 >> --- a/gcc/config/loongarch/larchintrin.h >> +++ b/gcc/config/loongarch/larchintrin.h >> @@ -336,38 +336,38 @@ __iocsrwr_d (unsigned long int _1, unsigned int _2) >>  #ifdef __loongarch_frecipe >>  /* Assembly instruction format: fd, fj.  */ >>  /* Data types in instruction templates:  SF, SF.  */ >> -extern __inline void >> +extern __inline float >>  __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) >>  __frecipe_s (float _1) >>  { >> -  __builtin_loongarch_frecipe_s ((float) _1); >> +  return (float) __builtin_loongarch_frecipe_s ((float) _1); > I don't think the (float) conversion is needed. > > Indeed, this float conversion is unnecessary; I simply included it to align with the definitions of other intrinsic functions.