From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id DA66C3858CD1 for ; Wed, 20 Dec 2023 20:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA66C3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA66C3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703105032; cv=none; b=b8xDV6m74DJjUkcybXiRtXoXHmZ8u1XUHbzRwEh8peH90SlQhdqvqAoL7h0hh++rbeyuzvzuyUrLXFJJY4ayE0h7FR6rsIWMREc2bEIWQUJA9qHMf13aBhfs4bFvglUtFnaYaGVTjJYx/mD9SHknK7VBeTMrB0mxoVgRIsTgesk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703105032; c=relaxed/simple; bh=nPle+qfLr5yqRE8J5AgM5mY5YENAqwp1eZ4MelYldwk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=lrCTQa5tRS2Fst6Nf7RKc+oRZElozRwZZVpkUOdgg5kI6h3/wgsF3Ab8/4hwkOluxCSHdUG5WUfcKlT8hlE+CnFt1OO/znswO41pAhAter4BnCaw3qvv18vBVWX/iV5DqQImrrTWcCxZq9/JGhjyB4ccbxFwbdFbn4C/uUndD4c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7b7f6caf047so1900739f.3 for ; Wed, 20 Dec 2023 12:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703105030; x=1703709830; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EAqboSwmHHPO5NkDo34U/Ho+K/usUPKSxoDAVdWDJDA=; b=aBq3Wmbm9koA7cpceb2qF/dHDvPaVDP8Ov/FjzhrdKQW1kJ3r0SCuVfb/vaiS7fPfG IFgQ0wp/EXibKwuM9AQVH2OICtKQKu87ossxg0StYDYTDJpFc63uYPLO4WNc2mB5Erwd jOCb2IVr8PMdJdPr7BbNI9UOyxeUoy/IrYylhkKnUpB34zoiZBV8NmWP7DtJEaIpFYWB KoaTMWNHHN8nfAbibREfT3Dw4Gtva7G/SiF/LqElw2nKxQL2bWsWXlEJ9X/zZcpDoz2k JUAqvRikQrP7axwgCWATVbHC+RO9I8D9IHiri+LwYmmQzIZSGrgNi1KacD/HF3bwELon 2C1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703105030; x=1703709830; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EAqboSwmHHPO5NkDo34U/Ho+K/usUPKSxoDAVdWDJDA=; b=kcEe5WfM7gGXMddwg7iJoIBiYeaTsk1/EXHNUoaQFYMEQeSbiVLmbE18E68sJHfdot hVB130VCSx9BcOrjArlNcTEKcMkblVQToNSOJbPqx+v19dKhhlCdjGKpGc8hDOH2D/qC iwes2u1PtndhHqiG7qKN865sJBBzhGVsHx8ZMJtyE3ZLbrk3i/I3QyBbGRp1LTOwmw0e E5xU6f+O5a08mencBvna+155kSjuKJN7gWYMmgIBR8O1HKYlk9um6vGBCwTG4uax9n5Z HLmTgLPXk7lWc8iz2q2vEKDdSY3DYnAqcLFoFul4UeXcFT5tUO/ZdnlS5lKcEKR9rmBM 64Hg== X-Gm-Message-State: AOJu0YwGwl6JFEK2NlYfZRx4OgPnxTyI9wFibe1XDmf+h0ju6vRq+HAH OUEAQduqSowQYG50vqJuIv4= X-Google-Smtp-Source: AGHT+IFieglEmHismaolXL+bU11AH1xNSI9Wizt89Ox9laSwzn1Mm2wjDyjRI0UVMoLcWMmBcHL/ig== X-Received: by 2002:a05:6602:8c1:b0:7ba:7e24:10b with SMTP id h1-20020a05660208c100b007ba7e24010bmr829795ioz.8.1703105029996; Wed, 20 Dec 2023 12:43:49 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id gl26-20020a0566024f1a00b007ba7a40af86sm86429iob.39.2023.12.20.12.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 12:43:49 -0800 (PST) Message-ID: <658c398c-6eb9-4567-ab8c-e97f188a9590@gmail.com> Date: Wed, 20 Dec 2023 13:43:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PING^1 [PATCH] sched: Remove debug counter sched_block Content-Language: en-US To: "Kewen.Lin" , Alexander Monakov , Maxim Kuvyrkov Cc: GCC Patches , Richard Guenther , Richard Sandiford , Jeff Law , Vladimir Makarov , zhroma@ispras.ru, Andrey Belevantsev , Segher Boessenkool , Peter Bergner , Michael Meissner References: <85b4098e-a72f-d013-ff17-8097971f71ba@linux.ibm.com> <09FEFDAE-698B-4B06-A896-8088B9B31539@linaro.org> <8b7e8bf1-89bc-82c4-5b7d-bcbb84f46cb7@linux.ibm.com> From: Jeff Law In-Reply-To: <8b7e8bf1-89bc-82c4-5b7d-bcbb84f46cb7@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/11/23 23:17, Kewen.Lin wrote: > Hi, > > Gentle ping this: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636597.html > > BR, > Kewen > > on 2023/11/15 17:01, Kewen.Lin wrote: >> Hi, >> >> on 2023/11/10 01:40, Alexander Monakov wrote: >> >>> I agree with the concern. I hoped that solving the problem by skipping the BB >>> like the (bit-rotted) debug code needs to would be a minor surgery. As things >>> look now, it may be better to remove the non-working sched_block debug counter >>> entirely and implement a good solution for the problem at hand. >>> >> >> According to this comment, I made and tested the below patch to remove the >> problematic debug counter: >> >> Subject: [PATCH] sched: Remove debug counter sched_block >> >> Currently the debug counter sched_block doesn't work well >> since we create dependencies for some insns and those >> dependencies are expected to be resolved during scheduling >> insns but they can get skipped once we are skipping some >> block while respecting sched_block debug counter. >> >> For example, for the below test case: >> -- >> int a, b, c, e, f; >> float d; >> >> void >> g () >> { >> float h, i[1]; >> for (; f;) >> if (c) >> { >> d *e; >> if (b) >> { >> float *j = i; >> j[0] = 0; >> } >> h = d; >> } >> if (h) >> a = i[0]; >> } >> -- >> ICE occurs with option "-O2 -fdbg-cnt=sched_block:1". >> >> As the discussion in [1], it seems that we think this debug >> counter is useless and can be removed. It's also implied >> that if it's useful and used often, the above issue should >> have been cared about and resolved earlier. So this patch >> is to remove this debug counter. >> >> Bootstrapped and regtested on x86_64-redhat-linux and >> powerpc64{,le}-linux-gnu. >> >> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635852.html >> >> Is it ok for trunk? >> >> BR, >> Kewen >> ----- >> >> gcc/ChangeLog: >> >> * dbgcnt.def (sched_block): Remove. >> * sched-rgn.cc (schedule_region): Remove the support of debug count >> sched_block. OK. SOrry about the delay. jeff