public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [RFC]Support vectorization for Complex type.
Date: Sun, 10 Jul 2022 22:54:45 -0600	[thread overview]
Message-ID: <659026ec-f845-71d6-f35d-407030d30e60@gmail.com> (raw)
In-Reply-To: <20220711034339.18450-1-hongtao.liu@intel.com>



On 7/10/2022 9:43 PM, liuhongt via Gcc-patches wrote:
> The patch only handles load/store(including ctor/permutation, except
> gather/scatter) for complex type, other operations don't needs to be
> handled since they will be lowered by pass cplxlower.(MASK_LOAD is not
> supported for complex type, so no need to handle either).
>
> Instead of support vector(2) _Complex double, this patch takes vector(4)
> double as vector type of _Complex double. Since vectorizer originally
> takes TYPE_VECTOR_SUBPARTS as nunits which is not true for complex
> type, the patch handles nunits/ncopies/vf specially for complex type.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Also test the patch for SPEC2017 and find there's complex type vectorization
> in 510/549(but no performance impact).
No comment on the implementation.  From a benchmarking standpoint you 
might want to look at cam4 in speed, not rate mode.     I'd bet you'd 
want -ffast-math or -fcx-limited-range to avoid divdc3 and have those 
calls expanded inline which may give you a better crack at exposing 
vectorization opportunities in there.

jeff


  reply	other threads:[~2022-07-11  4:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11  3:43 liuhongt
2022-07-11  4:54 ` Jeff Law [this message]
2022-07-11 11:46 ` Richard Biener
2022-07-12  4:11   ` Hongtao Liu
2022-07-12 14:12     ` Richard Biener
2022-07-13  4:46       ` Hongtao Liu
2022-07-13  7:34         ` Richard Biener
2022-07-14  8:20           ` Richard Biener
2022-07-14  8:53             ` Hongtao Liu
2022-07-14  9:26               ` Hongtao Liu
2022-07-14  9:51                 ` Richard Biener
2022-07-18  2:31                   ` [PATCH V2] " liuhongt
2022-07-19  8:43                     ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659026ec-f845-71d6-f35d-407030d30e60@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).