From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id A69BF3858D28 for ; Tue, 27 Jun 2023 09:55:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A69BF3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-313f3a6db22so1912384f8f.3 for ; Tue, 27 Jun 2023 02:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687859740; x=1690451740; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VfgV5cyavNs6AmnGQmgKr1fDhfohLG6GNDCzOsiIOmE=; b=fdMwSQLDYDBDvEX/+JKcq+MB93sVsHAUl1NRx4A3NghltuyIP4MPicCmdG5b/Zjls3 6lye29GTn79uk+Frdv1e+EjnDFBr6khriu87mmZybxY2j815pfOshCT+KgLI8oozQw/3 p6zhh4HMEYAUrjvh9fQUxbXyQ29cBsdsjTDtho8imbD0L7A6pw3ndrrdecFgMGne6YMW e7bfwMpTV0JsSYUhx/bjX7E0ZsJJcmXED/1Tge+pJhPnFEp/cK7cmQCA04TN5AXpwVYK N5uzhs1jF7trSetd6rashUkSXxz2DamUm2FZPebc2H2ZEPg37AUaer4rh2dLyaepfSS9 Gz8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687859740; x=1690451740; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VfgV5cyavNs6AmnGQmgKr1fDhfohLG6GNDCzOsiIOmE=; b=VvN+F30rQ+tTXUm6Q0oi7Xcm5jQ+9VrWOubY4LLuefd2vjo10ldmFSKzyCbZQtb1Ff qUKgx/NeZcd9CokzEOL1oGm1XT23ZMfX/7rW1zu/zePol5gHp3bMrA4lL5Em/SwOGvw0 YDYZllQ22x3XNhFzDttdAH1nEL1oHli7Oz3ODYeqbwuILCMjR0EeuSCPf/ZBPltcjT87 QRDzZ1Pq59Rocs/hOaKziywMa28I1Ynib+KMylLv01N0avS4OO4gZphQPsYvBLSAzHuT ldEW6VT5GLQyylIPk4qfIZjoD4ZW/vWjDfKL/AG8SDHn9op5p4a/9d/Q4KVR9TQ1U2Q3 XDQQ== X-Gm-Message-State: AC+VfDzMCJYEx/cEGcUS0DEvGQfS29nmWhDsMMbJa+Y4BvFfSr/fqcdq t+g7F1v+CcsZdIvyo8GI3a8= X-Google-Smtp-Source: ACHHUZ5wi6fd+Ob8bPt0OgsZMesdQk7egq6yguWGNz1mweausltjQ1jqAnl1+Y7EPcEok2fuGnHeMg== X-Received: by 2002:adf:f8ce:0:b0:314:327:2ecd with SMTP id f14-20020adff8ce000000b0031403272ecdmr302141wrq.67.1687859740312; Tue, 27 Jun 2023 02:55:40 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id u15-20020a5d6acf000000b003111fd2e33dsm9842553wrw.30.2023.06.27.02.55.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 02:55:39 -0700 (PDT) Message-ID: <65b66423-d93d-c5f1-05da-7540a13a0bec@gmail.com> Date: Tue, 27 Jun 2023 11:55:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: rdapp.gcc@gmail.com, gcc-patches , Tamar.Christina@arm.com Subject: Re: [PATCH] match.pd: Use element_mode instead of TYPE_MODE. Content-Language: en-US To: Richard Biener References: <3fc809a1-6667-daca-e95a-b0a58825e16f@gmail.com> <0ea59340-7946-51dc-a060-6f0fc1ccdda0@gmail.com> <802f50c6-6e1d-9e93-a75c-ce947bd1784b@gmail.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > so I suggest to do a similar VECTOR_MODE_P check and your original test. > So > > && (!VECTOR_MODE_P (TYPE_MODE (newtype)) > || target_supports_op_p (newtype, op, optab_default)) > > OK with that change. Separate patch or into the original one? We needed element_mode because TYPE_MODE wouldn't work for a vector_mode so it still somehow fits. Apart from that, out of curiosity, do we want the same optab mechanism (try widening/widened op if the original one failed) for vector types as well in the future? Regards Robin