From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 582303858402 for ; Sun, 28 Nov 2021 19:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 582303858402 Received: by mail-pf1-x429.google.com with SMTP id g19so14382064pfb.8 for ; Sun, 28 Nov 2021 11:21:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=N37gHPhkiHBlWfYjJS9gAOVmLRelNuJJ6GAszaxJHaA=; b=WsnVXYLcGTDO7LsQOUJLcrXBU5WzffBk6Egirt7ML7FxS2WRFtj5VhKsK0t/50lFdD f/vs9noTnHaW00wD76xFYjV5bogdeLHRJPARvgNkrmhEsyaWMQxjarsJ8ZBC/ET+K/Mw CybxzX/NrZCSh/WeN6dr6yQD5/UHRuY9xjIHKC0b3Q6ZGWe2LHUnaR1JXmSDCHdsuTAR ojCiUvTdxWhbL9zka5Kt7pGIKyHHrNU0FplkA/s0Sw5FGfRHAj94ZrYMkYYqNVP0Q2HY jEZSmX8hO3Fh35jlkUA3UFZwzPE+GpXHe5GVV/C/g5at/3fPMDM59SR7X1Nl98AAqbot 3ZHA== X-Gm-Message-State: AOAM532ya1updua920e0zv/MwlX1IRGdPyEXvo6R+PaQkXtDgNytr8vR IG+yd/Hn8yihFD5ZuJZ6gQskdaXyvA0= X-Google-Smtp-Source: ABdhPJz4BCRtKtwpKAd/Q4Yulmn45UKxUfRf0d+EdsA88m5EDqpO/ZN0NnSNXkoUuBduVOBrWCt7og== X-Received: by 2002:aa7:9d81:0:b0:49f:e072:bfc7 with SMTP id f1-20020aa79d81000000b0049fe072bfc7mr35108836pfq.48.1638127313475; Sun, 28 Nov 2021 11:21:53 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id 63sm14315681pfz.119.2021.11.28.11.21.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Nov 2021 11:21:53 -0800 (PST) Message-ID: <660b3254-f107-9da6-23e5-d4d5b1f51349@gmail.com> Date: Sun, 28 Nov 2021 12:21:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] Restore can_be_invalidated_p semantics to before refactoring Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org Cc: msebor@redhat.com References: <37545rsn-6682-46p8-8986-7o7q6576n1sr@fhfr.qr> From: Jeff Law In-Reply-To: <37545rsn-6682-46p8-8986-7o7q6576n1sr@fhfr.qr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Nov 2021 19:21:55 -0000 On 11/26/2021 12:53 AM, Richard Biener via Gcc-patches wrote: > This restores the semantics of can_be_invalidated_p to the original > semantics of the function this was split out from tree-ssa-uninit.c. > The current semantics only ever look at the first predicate which > cannot be correct. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? > > Thanks, > Richard. > > 2021-11-26 Richard Biener > > * gimple-predicate-analysis.cc (can_be_invalidated_p): > Restore semantics to the one before the split from > tree-ssa-uninit.c. OK.  Sorry this got missed in the review of splitting out those bits. jeff