From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
To: Mikael Morin <morin-mikael@orange.fr>, <gcc-patches@gcc.gnu.org>
Cc: <nathan@acm.org>, <hubicka@ucw.cz>
Subject: Re: [PATCH v2] gcov: Respect triplet when looking for gcov
Date: Sun, 11 Sep 2022 18:04:41 +0200 [thread overview]
Message-ID: <662abb45-dad9-f0f7-4af6-940829d648a6@foss.st.com> (raw)
In-Reply-To: <a9fcb3b8-e583-5512-3825-d37b3e97feef@orange.fr>
Hi,
On 2022-09-11 16:34, Mikael Morin wrote:
> Hello,
>
>> diff --git a/gcc/testsuite/gcc.misc-tests/gcov.exp
>> b/gcc/testsuite/gcc.misc-tests/gcov.exp
>> index 82376d90ac2..a55ce234f6e 100644
>> --- a/gcc/testsuite/gcc.misc-tests/gcov.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/gcov.exp
>> @@ -24,9 +24,9 @@ global GCC_UNDER_TEST
> (...)
>> } else {
>> - set GCOV gcov
>> + set GCOV {transform gcov]
>
> Typo: I guess the opening curly bracket '{' should be a square one '['?
Yes. Apparently I was too stressed when preparing this patch. Can you
fix it for me and submit it or do you want me to send a v3?
next prev parent reply other threads:[~2022-09-11 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 12:56 Torbjörn SVENSSON
2022-09-11 14:34 ` Mikael Morin
2022-09-11 16:04 ` Torbjorn SVENSSON [this message]
2022-09-11 19:38 ` Mikael Morin
2022-09-12 7:06 ` Torbjorn SVENSSON
2022-09-12 7:40 ` Mikael Morin
2022-09-12 8:40 ` Martin Liška
2022-09-12 9:39 ` Torbjorn SVENSSON
2022-09-12 9:42 ` Martin Liška
2022-11-16 2:11 ` [PATCH] testsuite: Fix mistransformed gcov Hans-Peter Nilsson
2022-11-16 7:59 ` Torbjorn SVENSSON
2022-11-16 15:38 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=662abb45-dad9-f0f7-4af6-940829d648a6@foss.st.com \
--to=torbjorn.svensson@foss.st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=morin-mikael@orange.fr \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).