* [COMMITTED] Change threading comment before pass_ccp pass.
@ 2021-10-19 8:48 Aldy Hernandez
2021-10-19 10:55 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Aldy Hernandez @ 2021-10-19 8:48 UTC (permalink / raw)
To: Richard Biener, GCC patches
As suggested. Thanks.
gcc/ChangeLog:
* passes.def: Change threading comment before pass_ccp pass.
---
gcc/passes.def | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gcc/passes.def b/gcc/passes.def
index c11c237f6d2..4c54176328b 100644
--- a/gcc/passes.def
+++ b/gcc/passes.def
@@ -339,9 +339,7 @@ along with GCC; see the file COPYING3. If not see
NEXT_PASS (pass_thread_jumps);
NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */);
NEXT_PASS (pass_vrp_threader);
- /* Threading can leave many const/copy propagations in the IL.
- Clean them up. Instead of just copy_prop, we use ccp to
- compute alignment and nonzero bits. */
+ /* Run CCP to compute alignment and nonzero bits. */
NEXT_PASS (pass_ccp, true /* nonzero_p */);
NEXT_PASS (pass_warn_restrict);
NEXT_PASS (pass_dse);
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [COMMITTED] Change threading comment before pass_ccp pass.
2021-10-19 8:48 [COMMITTED] Change threading comment before pass_ccp pass Aldy Hernandez
@ 2021-10-19 10:55 ` Richard Biener
2021-10-19 11:31 ` Aldy Hernandez
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2021-10-19 10:55 UTC (permalink / raw)
To: Aldy Hernandez; +Cc: GCC patches
On Tue, Oct 19, 2021 at 10:48 AM Aldy Hernandez <aldyh@redhat.com> wrote:
>
> As suggested. Thanks.
>
> gcc/ChangeLog:
>
> * passes.def: Change threading comment before pass_ccp pass.
> ---
> gcc/passes.def | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gcc/passes.def b/gcc/passes.def
> index c11c237f6d2..4c54176328b 100644
> --- a/gcc/passes.def
> +++ b/gcc/passes.def
> @@ -339,9 +339,7 @@ along with GCC; see the file COPYING3. If not see
> NEXT_PASS (pass_thread_jumps);
> NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */);
> NEXT_PASS (pass_vrp_threader);
> - /* Threading can leave many const/copy propagations in the IL.
> - Clean them up. Instead of just copy_prop, we use ccp to
> - compute alignment and nonzero bits. */
Well, the comment is still true as long as pass_vrp_threader is there ;)
> + /* Run CCP to compute alignment and nonzero bits. */
> NEXT_PASS (pass_ccp, true /* nonzero_p */);
> NEXT_PASS (pass_warn_restrict);
> NEXT_PASS (pass_dse);
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [COMMITTED] Change threading comment before pass_ccp pass.
2021-10-19 10:55 ` Richard Biener
@ 2021-10-19 11:31 ` Aldy Hernandez
0 siblings, 0 replies; 3+ messages in thread
From: Aldy Hernandez @ 2021-10-19 11:31 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC patches
On 10/19/21 12:55 PM, Richard Biener wrote:
> On Tue, Oct 19, 2021 at 10:48 AM Aldy Hernandez <aldyh@redhat.com> wrote:
>>
>> As suggested. Thanks.
>>
>> gcc/ChangeLog:
>>
>> * passes.def: Change threading comment before pass_ccp pass.
>> ---
>> gcc/passes.def | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/gcc/passes.def b/gcc/passes.def
>> index c11c237f6d2..4c54176328b 100644
>> --- a/gcc/passes.def
>> +++ b/gcc/passes.def
>> @@ -339,9 +339,7 @@ along with GCC; see the file COPYING3. If not see
>> NEXT_PASS (pass_thread_jumps);
>> NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */);
>> NEXT_PASS (pass_vrp_threader);
>> - /* Threading can leave many const/copy propagations in the IL.
>> - Clean them up. Instead of just copy_prop, we use ccp to
>> - compute alignment and nonzero bits. */
>
> Well, the comment is still true as long as pass_vrp_threader is there ;)
Ha ha! Oops. You're right.
Tell you what, if we decide not to rearrange the pipeline, I'll put the
comment back :).
Aldy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 8:48 [COMMITTED] Change threading comment before pass_ccp pass Aldy Hernandez
2021-10-19 10:55 ` Richard Biener
2021-10-19 11:31 ` Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).