From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Kyrill Tkachov <kyrylo.tkachov@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets
Date: Wed, 14 Jun 2017 09:07:00 -0000 [thread overview]
Message-ID: <6666386c-bd81-de40-aa14-7b8998b828d6@foss.arm.com> (raw)
In-Reply-To: <CAKdteOa1T3mxcisdHdOUhM+e_c6W5=x5Vj4JjpL7tX=t3vwqNw@mail.gmail.com>
On 14/06/17 09:29, Christophe Lyon wrote:
> On 14 June 2017 at 10:25, Thomas Preudhomme
> <thomas.preudhomme@foss.arm.com> wrote:
>>
>>
>> On 13/06/17 20:22, Christophe Lyon wrote:
>>>
>>> Hi Thomas,
>>>
>>> On 13 June 2017 at 11:08, Thomas Preudhomme
>>> <thomas.preudhomme@foss.arm.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Conditions checked for ARM targets in vector-related effective targets
>>>> are inconsistent:
>>>>
>>>> * sometimes arm*-*-* is checked
>>>> * sometimes Neon is checked
>>>> * sometimes arm_neon_ok and sometimes arm_neon is used for neon check
>>>> * sometimes check_effective_target_* is used, sometimes
>>>> is-effective-target
>>>>
>>>> This patch consolidate all of these check into using is-effective-target
>>>> arm_neon and when little endian was checked, the check is kept.
>>>>
>>>> ChangeLog entry is as follows:
>>>>
>>>> *** gcc/testsuite/ChangeLog ***
>>>>
>>>> 2017-06-06 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>>
>>>> * lib/target-supports.exp (check_effective_target_vect_int):
>>>> Replace
>>>> current ARM check by ARM NEON's availability check.
>>>> (check_effective_target_vect_intfloat_cvt): Likewise.
>>>> (check_effective_target_vect_uintfloat_cvt): Likewise.
>>>> (check_effective_target_vect_floatint_cvt): Likewise.
>>>> (check_effective_target_vect_floatuint_cvt): Likewise.
>>>> (check_effective_target_vect_shift): Likewise.
>>>> (check_effective_target_whole_vector_shift): Likewise.
>>>> (check_effective_target_vect_bswap): Likewise.
>>>> (check_effective_target_vect_shift_char): Likewise.
>>>> (check_effective_target_vect_long): Likewise.
>>>> (check_effective_target_vect_float): Likewise.
>>>> (check_effective_target_vect_perm): Likewise.
>>>> (check_effective_target_vect_perm_byte): Likewise.
>>>> (check_effective_target_vect_perm_short): Likewise.
>>>> (check_effective_target_vect_widen_sum_hi_to_si_pattern):
>>>> Likewise.
>>>> (check_effective_target_vect_widen_sum_qi_to_hi): Likewise.
>>>> (check_effective_target_vect_widen_mult_qi_to_hi): Likewise.
>>>> (check_effective_target_vect_widen_mult_hi_to_si): Likewise.
>>>> (check_effective_target_vect_widen_mult_qi_to_hi_pattern):
>>>> Likewise.
>>>> (check_effective_target_vect_widen_mult_hi_to_si_pattern):
>>>> Likewise.
>>>> (check_effective_target_vect_widen_shift): Likewise.
>>>> (check_effective_target_vect_extract_even_odd): Likewise.
>>>> (check_effective_target_vect_interleave): Likewise.
>>>> (check_effective_target_vect_multiple_sizes): Likewise.
>>>> (check_effective_target_vect64): Likewise.
>>>> (check_effective_target_vect_max_reduc): Likewise.
>>>>
>>>> Testing: Testsuite shows no regression when targeting ARMv7-A with
>>>> -mfpu=neon-fpv4 and -mfloat-abi=hard or when targeting Cortex-M3 with
>>>> default FPU and float ABI (soft).
>>>>
>>>
>>> That's strange, my testing detects a syntax error:
>>>
>>> Executed from: gcc.dg/vect/vect.exp
>>> gcc.dg/vect/slp-9.c: error executing dg-final: unbalanced close paren
>>
>>
>> Indeed, I can see the missing parenthesis. I've checked again with the sum
>> file and even with -v -v -v -v dg-cmp-results does not show any regression.
>> compare_tests does though but is often more noisy (saying some tests having
>> disappeared and appeared).
>> This sounds like dg-cmp-results needs to be improved here. I'll do that
>> first then test a fixed version of the patch.
>>
>
> I did patch compare_tests a while ago such that it catches ERROR message from
> dejagnu (r240288)
So dg-cmp-results assume there is only one tool tested in the .sum file (it
throws everything before "^Running" and everything after "^[[:space:]]+==="
which it assumes is the summary. Gosh, I've used it countless time in that way...
Will provide a patch to make it work also in that setup.
Best regards,
Thomas
next prev parent reply other threads:[~2017-06-14 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 9:08 Thomas Preudhomme
2017-06-13 19:22 ` Christophe Lyon
2017-06-14 8:26 ` Thomas Preudhomme
2017-06-14 8:29 ` Christophe Lyon
2017-06-14 9:07 ` Thomas Preudhomme [this message]
2017-06-15 16:18 ` Thomas Preudhomme
2017-06-19 7:41 ` Christophe Lyon
2017-06-19 9:16 ` Thomas Preudhomme
2017-06-19 9:24 ` Christophe Lyon
2017-06-19 14:11 ` Thomas Preudhomme
2017-06-19 14:31 ` Christophe Lyon
2017-06-19 14:47 ` Thomas Preudhomme
2017-06-20 12:44 ` Christophe Lyon
2017-06-28 14:49 ` Thomas Preudhomme
2017-06-28 14:59 ` Kyrill Tkachov
2017-06-28 15:03 ` Thomas Preudhomme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6666386c-bd81-de40-aa14-7b8998b828d6@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).