From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-229445-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 17923 invoked by alias); 24 Oct 2008 16:56:43 -0000
Received: (qmail 17915 invoked by uid 22791); 24 Oct 2008 16:56:43 -0000
X-Spam-Check-By: sourceware.org
Received: from rv-out-0708.google.com (HELO rv-out-0708.google.com) (209.85.198.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Oct 2008 16:56:08 +0000
Received: by rv-out-0708.google.com with SMTP id c5so917177rvf.56         for <gcc-patches@gcc.gnu.org>; Fri, 24 Oct 2008 09:56:04 -0700 (PDT)
Received: by 10.140.247.11 with SMTP id u11mr1333253rvh.37.1224867364905;         Fri, 24 Oct 2008 09:56:04 -0700 (PDT)
Received: by 10.141.91.15 with HTTP; Fri, 24 Oct 2008 09:56:04 -0700 (PDT)
Message-ID: <668c430c0810240956l5665dfe1m12b9a280ba20cdd@mail.gmail.com>
Date: Fri, 24 Oct 2008 17:59:00 -0000
From: "Bruce Korb" <bruce.korb@gmail.com>
To: gcc-patches@gcc.gnu.org, "Joseph S. Myers" <joseph@codesourcery.com>
Subject: RE: [4.5] C constant expressions, VLAs etc. fixes
In-Reply-To: <Pine.LNX.4.64.0810241634590.30779@digraph.polyomino.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <Pine.LNX.4.64.0810241634590.30779@digraph.polyomino.org.uk>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2008-10/txt/msg01067.txt.bz2

Hi Joseph,

Fixincludes stuff looks good to me.  A tiny nit:

+    select    = "\\(\\(\\(type\\) 0.25\\) && \\(\\(type\\) 0.25 - 1\\)\\)";
might look cleaner as:
+    select    = '\(\(\(type\) 0.25\) && \(\(type\) 0.25 - 1\)\)';

Cheers - Bruce