From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 044E83858D33; Thu, 20 Apr 2023 04:37:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 044E83858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33K1f5tG019712; Thu, 20 Apr 2023 04:37:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=mime-version : date : from : to : cc : subject : in-reply-to : references : message-id : content-type : content-transfer-encoding; s=pp1; bh=K3ifdqnma5VHb7bywllSJoo2u3B3QstGWfrubJ4AIg4=; b=a+m4SurMjeQJl6k/xGzyX+hp4ZlKO7w287yYY/KoKM/1mFG6X9WurVdqot5v7mXpLtPc ULomBkhK7XiL+p7ikYY7EITZ4diwouMRz3aJ+dCGGtOlVt/5lIe64ZXid7+aieMC1rc5 ncIZdhXo9p3gW7AAF/yViA2cQU4+aLSvnU4Igs5W9bEco3A3PxKskpM6zLUnpSpcpaYs UJ0aBXe+To7TfLcX3Lj63TUlDJOTCqTFuAIR+lLqtTGiyeKJ4LDAk4uNvRUpxQXWi7Pg 9KcKHBCFb3ds77XC2wubJAuJDTR/xJJvbU7j/Zgch4aUFxERoSR6rwM07ARcmVKGmMLx gA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1pky7409-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 04:37:19 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33K4WoIE005630; Thu, 20 Apr 2023 04:37:19 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1pky73yx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 04:37:19 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33K4HYPW026721; Thu, 20 Apr 2023 04:37:18 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([9.208.129.113]) by ppma02dal.us.ibm.com (PPS) with ESMTPS id 3q1uxdkgsq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 04:37:18 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33K4bGjq10879658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Apr 2023 04:37:16 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C398958050; Thu, 20 Apr 2023 04:37:16 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3030D58052; Thu, 20 Apr 2023 04:37:16 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 20 Apr 2023 04:37:16 +0000 (GMT) MIME-Version: 1.0 Date: Thu, 20 Apr 2023 12:37:15 +0800 From: guojiufu To: "Kewen.Lin" Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, rguenther@suse.de, jeffreyalaw@gmail.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] PR testsuite/106879 FAIL: gcc.dg/vect/bb-slp-layout-19.c on powerpc64 In-Reply-To: <4c9eba2a-28ec-a463-ab0b-5daab8d382d7@linux.ibm.com> References: <20230419020336.722450-1-guojiufu@linux.ibm.com> <4c9eba2a-28ec-a463-ab0b-5daab8d382d7@linux.ibm.com> Message-ID: <66e60d03e16bbecad33c3ebf6a2bb54e@linux.ibm.com> X-Sender: guojiufu@linux.ibm.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: _X_srfJh_CpjxJMbi9hWZ7fd-u1mb8f8 X-Proofpoint-ORIG-GUID: kxOpinlpRfYfouJrXdRSGyEmnbwTLPrn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-20_02,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304200035 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kewen, On 2023-04-19 10:53, Kewen.Lin wrote: > Hi Jeff, > > on 2023/4/19 10:03, Jiufu Guo wrote: >> Hi, >> >> On P7, option -mno-allow-movmisalign is added during testing, which >> prevents slp happen on the case. >> >> Like Like PR65484 and PR87306, this patch use vect_hw_misalig to guard > Dup like... ~~ missing the last > character n. Always thanks for your helpful catching and comments! Committed via r14-105-g57e7229a29ca0e. BR, Jeff (Jiufu) > >> the case on powerpc targets. >> >> Tested on ppc64{le,} and x86_64. >> Is this ok for trunk? >> >> BR, >> Jeff (Jiufu) >> >> gcc/testsuite/ChangeLog: >> >> PR testsuite/106879 >> * gcc.dg/vect/bb-slp-layout-19.c: Modify to guard the check with >> vect_hw_misalig on POWERs. > ... ~~~~~ Same here. > > OK for trunk with these nits fixed, thanks! > > BR, > Kewen > >> >> --- >> gcc/testsuite/gcc.dg/vect/bb-slp-layout-19.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-layout-19.c >> b/gcc/testsuite/gcc.dg/vect/bb-slp-layout-19.c >> index f075a83a25b..faf98e8d3c0 100644 >> --- a/gcc/testsuite/gcc.dg/vect/bb-slp-layout-19.c >> +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-layout-19.c >> @@ -31,4 +31,9 @@ void f() >> e[3] = b3; >> } >> >> -/* { dg-final { scan-tree-dump-times "add new stmt: \[^\\n\\r\]* = >> VEC_PERM_EXPR" 3 "slp1" { target { vect_int_mult && vect_perm } } } } >> */ >> +/* On older powerpc hardware (POWER7 and earlier), the default flag >> + -mno-allow-movmisalign prevents vectorization. On POWER8 and >> later, >> + when vect_hw_misalign is true, vectorization occurs. For other >> + targets, ! vect_no_align is a sufficient test. */ >> + >> +/* { dg-final { scan-tree-dump-times "add new stmt: \[^\\n\\r\]* = >> VEC_PERM_EXPR" 3 "slp1" { target { { vect_int_mult && vect_perm } && { >> { ! powerpc*-*-* } || { vect_hw_misalign } } } } } } */