From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id EAA323858D38 for ; Mon, 11 Mar 2024 09:56:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAA323858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAA323858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710150993; cv=none; b=Ov/53nARuwI+Vza8vU8jwV9VC4nByVe4UhNyc3mMBKIy/okrKNVCFb+lhDbWTrn31M4fEfqaDOo1RVB/ziVd5xOlApBz4xq/5AROA88ki3CoyXgIDELorG6AIp6LkWvNylSVuZYif/xVfz8wJmHJL571TMuiQ3UnubLQuABDPq0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710150993; c=relaxed/simple; bh=3BQ6Da3vfSplwYIlm1Fmh86qJ/KL9ZQBFE1+2AjXJAw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gzgklfpBocmI77NzK44gmZe/IggB/tPVBUR3ZobrzkNXxOE3uxaZnASUFJtdQPT9DW25BNN9cuHcT1qGrlw2Euuy7GaZWfK0zE02pYLlvcrdBQj49jvZtmTMUsJ4RZZj9pQ8lwnkdRvXXvRXlcXf89KYxV4vGCDtTNPUuclRdrI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42B7S95F007107 for ; Mon, 11 Mar 2024 09:56:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=eERCLdqW6CX1SD8XqzTQpbEffpGIdmZTsE1gdMfeRNU=; b=F+PjzMb+zt4N5TIbi7KQDiV8LTDvIiihR7xTmBwgyBNW/rZFKLJjg2QSrCDUAZkzmb90 qx5BlEWYmB3Aqb93B2F+vgT01j6Ic5mc+GUiYzYouIZvclubIj+NipcwsFwd8lG0YOZf ioUOI6ibWdIMgUc62FACbGY2fHdWPscAudoSqqTDFODPul29zew4iURF0EjkwTuWXxKs nLLRvPwQXcOYm70ukUeZrvBvwoKUQMTc2iKEb+yLNrUrvxKlIk4AegKq0e8SKHuJ5t3h 1NbBchmAQidYHf0z34HcOD4A5nymHlhUg9JDoBSu4tnyoFDzoNflwSqdGz6rckZR65bW 4A== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wswkat7j9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2024 09:56:31 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42B7jP5x020446 for ; Mon, 11 Mar 2024 09:56:30 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ws3kkqm9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2024 09:56:30 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42B9uPLL41812290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2024 09:56:27 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F0D352004F; Mon, 11 Mar 2024 09:56:24 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1D172004E; Mon, 11 Mar 2024 09:56:24 +0000 (GMT) Received: from [9.171.93.116] (unknown [9.171.93.116]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 11 Mar 2024 09:56:24 +0000 (GMT) Message-ID: <66f78fae-6a59-4a80-9974-87fa0e64c894@linux.ibm.com> Date: Mon, 11 Mar 2024 10:56:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] s390: Fix tests rosbg_si_srl and rxsbg_si_srl Content-Language: en-US To: Stefan Schulze Frielinghaus , gcc-patches@gcc.gnu.org References: <20240229121427.1200023-1-stefansf@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20240229121427.1200023-1-stefansf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: EXuFwKE-kUG-0lvYb-tML3Th-6Od8Gbv X-Proofpoint-GUID: EXuFwKE-kUG-0lvYb-tML3Th-6Od8Gbv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_06,2024-03-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 mlxlogscore=846 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403110073 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/29/24 13:14, Stefan Schulze Frielinghaus wrote: > Starting with r14-2047-gd0e891406b16dc two SI mode tests are optimized > into DI mode. Thus, the scan-assembler directives fail. For example > RTL expression > > (ior:SI (subreg:SI (lshiftrt:DI (reg:DI 69) > (const_int 2 [0x2])) 4) > (subreg:SI (reg:DI 68) 4)) > > is optimized into > > (ior:DI (lshiftrt:DI (reg:DI 69) > (const_int 2 [0x2])) > (reg:DI 68)) > > Fixed by moving operands into memory in order to enforce SI mode > computation. > > Furthermore, in r9-6056-g290dfd9bc7bea2 the starting bit position of the > scan-assembler directive for rosbg was incorrectly set to 32 which > actually should be 32+SHIFT_AMOUNT, i.e., in this particular case 34. > > gcc/testsuite/ChangeLog: > > * gcc.target/s390/md/rXsbg_mode_sXl.c: Fix tests rosbg_si_srl > and rxsbg_si_srl. Ok, thanks! Andreas