From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100793 invoked by alias); 26 Jun 2017 22:13:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100781 invoked by uid 89); 26 Jun 2017 22:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=(unknown) X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 22:13:27 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5QM8aQU030034 for ; Mon, 26 Jun 2017 18:13:25 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2bb563nd88-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 26 Jun 2017 18:13:25 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Jun 2017 18:13:23 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 26 Jun 2017 18:13:22 -0400 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5QMDM3t26673292; Mon, 26 Jun 2017 22:13:22 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11A0A28046; Mon, 26 Jun 2017 18:13:16 -0400 (EDT) Received: from oc6462846008.ibm.com (unknown [9.80.195.231]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP id C42CC2803D; Mon, 26 Jun 2017 18:13:15 -0400 (EDT) Subject: Re: [PATCH] PR66669: Fix failure of gcc.dg/loop-8.c on Power (Backport) To: gcc-patches@gcc.gnu.org Cc: law@redhat.com References: <57db91bc-c64f-d001-17e2-6d54c91611b7@linux.vnet.ibm.com> From: Kelvin Nilsen Date: Mon, 26 Jun 2017 22:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <57db91bc-c64f-d001-17e2-6d54c91611b7@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17062622-0008-0000-0000-0000024DC786 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007282; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00879133; UDB=6.00438128; IPR=6.00659288; BA=6.00005443; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015959; XFM=3.00000015; UTC=2017-06-26 22:13:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062622-0009-0000-0000-000035CF68AF Message-Id: <671667d9-6d91-edb9-c97f-91580fbdf485@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-26_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706260366 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01962.txt.bz2 Is it ok to backport this patch to GCC-6? On 01/23/2017 09:59 AM, Kelvin Nilsen wrote: > > The test gcc.dg/loop-8.c makes assumptions that are not valid on Power > architecture (and on certain other architectures for which this issue > has already been addressed). The test case assumes that a single > loop-invariant statement will be moved outside the loop. On Power, a > constant is copy-propagated within the loop, and the subsequent > loop-invariant code motion moves two loop-invariant statements out of > the loop. > > This patch simply disables this test case on Power architecture. > > > gcc/testsuite/ChangeLog: > > 2017-01-23 Kelvin Nilsen > > PR target/66669 > * gcc.dg/loop-8.c: Modify dg-skip-if directive to exclude this > test on powerpc targets. > > Index: gcc/testsuite/gcc.dg/loop-8.c > =================================================================== > --- gcc/testsuite/gcc.dg/loop-8.c (revision 244730) > +++ gcc/testsuite/gcc.dg/loop-8.c (working copy) > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-options "-O1 -fdump-rtl-loop2_invariant" } */ > -/* { dg-skip-if "unexpected IV" { "hppa*-*-* mips*-*-* visium-*-*" } { "*" } { "" } } */ > +/* { dg-skip-if "unexpected IV" { "hppa*-*-* mips*-*-* visium-*-* powerpc*-*-*" } { "*" } { "" } } */ > > void > f (int *a, int *b) > > -- Kelvin Nilsen, Ph.D. kdnilsen@linux.vnet.ibm.com home office: 801-756-4821, cell: 520-991-6727 IBM Linux Technology Center - PPC Toolchain