From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4FF4E385843B for ; Thu, 9 May 2024 19:12:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FF4E385843B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FF4E385843B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715281952; cv=none; b=fTT32d24hGzIUl/TYZ74riryPesyvX55jSnpbvMM2YfPDGdX67704JLEK+FdABX3dJz9bsB1z7cGnFKi4tC9dcwFa/ZmjQws6CBNGkgYz8Ci+BdfErAm41T21ChkClNXJUyh0Pwme4QbvMBoq5nD0fgaggXItXv7nNl+yOtbLec= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715281952; c=relaxed/simple; bh=05DIPZ6VyXOU6fBTDGqHl1KOZrCd8RnSmnwgo0Z6CE8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ZTJxE8yQv7dAB670uvWNgQaj+VP53LrThOD98IKVlUosRkVLF49PysdG2K1FiuSZlrPpZHjBpNxHvaqwN3sPG+CpI6wLgwsePPbK5F4fkz4y/cN/GcZKgqbewhfXmbtyBeRIPaX7aqUqdyd979IcxyZGtP5seZBftFHlSwjuw2s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715281951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tHSTpE+7tB40RTcK4iL2H0Tn9d7YrcvwhJMPp1eOvv4=; b=OEDODXVdEwvLht8R0jMBtx4Iqt+AlXfdt6xvh6kj5DOq8sllULvzlWt4jsfTHFHMz5MMni eQzeDExEhn8vxTNoi+ZeuAbDGJ79SH3/LPNK3nzBmnycv3WakUz8O6jlPYj7UBTyhaQEHH N85wp99rnLJN49mypNq928PMHuNKIXc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-110-Hj_V4mSIMTiOoa6FaklSDg-1; Thu, 09 May 2024 15:12:29 -0400 X-MC-Unique: Hj_V4mSIMTiOoa6FaklSDg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41feab38d16so938085e9.3 for ; Thu, 09 May 2024 12:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715281948; x=1715886748; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tHSTpE+7tB40RTcK4iL2H0Tn9d7YrcvwhJMPp1eOvv4=; b=VW58hnVqKX0jQ1WVernFn10V80gJISG+0ZVNLmPCaXH1RoNar0jk1oH9adpATdw3DN CaGM2PpyVLr9+DTe2uRe2U1sFixKC92Dkez+WumfjtoYJeX4BJ70ES7Jd820d8Nk4e7A Q1gPNyYfqRGz7io1Klvi3AmE17iVSoYc0V31Ue8ORRZSA+anbzbSePiXHB6h1Begvakz 5ccGHgT2/KBr/rqV5v5hAWdGW94Hyt2lPhTz43bCouIBbDkno7Zg/dR4ml7t0r8Ykj6A qzSu8Y4xLyVVNt8PKQWWR9q3XogVw5LZaTFQ2IiZ0ZmBaZoJ+BVfhxYHd6yd4fEks3MC Qp5Q== X-Gm-Message-State: AOJu0YyZlg6Dt2ELVTiq7jh1HStsJDYhM0u/enjK6Q4/Yhrvv9mox5In O13T7TDUDM3YU9wgXfJE5CBA0p2PazhH/x6++ngtrfcOq9+ph1BTCFR7psrGV9xwBNQEV4+mW3h KgkJV+niKV4U12k3aF0Era1o2C22aEk1W9dOJjaYsI5OJhL+xnoWdW7I= X-Received: by 2002:a05:600c:3d99:b0:419:f088:249c with SMTP id 5b1f17b1804b1-41feaa39324mr4712505e9.12.1715281948379; Thu, 09 May 2024 12:12:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyRGmcBoRBDvr7+xld7r5esogzwuw37w+Si5PJwZdRUkPLXe6U+XpR01MEkg5WePqwn6ekIQ== X-Received: by 2002:a05:600c:3d99:b0:419:f088:249c with SMTP id 5b1f17b1804b1-41feaa39324mr4712305e9.12.1715281947922; Thu, 09 May 2024 12:12:27 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41f87b26675sm70310355e9.2.2024.05.09.12.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 12:12:27 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1s59Bq-000M6j-9s; Thu, 09 May 2024 19:12:26 +0000 Date: Thu, 9 May 2024 19:12:26 +0000 (UTC) From: Joseph Myers To: "Kewen.Lin" cc: GCC Patches , Jakub Jelinek , Richard Biener , Richard Sandiford , Segher Boessenkool , Peter Bergner , Michael Meissner , David Edelsohn Subject: Re: [PATCH 1/4] rs6000: Make all 128 bit scalar FP modes have 128 bit precision [PR112993] In-Reply-To: <813e8433-0428-1854-c82c-fc0743368fa8@linux.ibm.com> Message-ID: <678c653f-b635-c3df-8a7b-8783a638e76e@redhat.com> References: <813e8433-0428-1854-c82c-fc0743368fa8@linux.ibm.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 8 May 2024, Kewen.Lin wrote: > to widen IFmode to TFmode. To make build_common_tree_nodes > be able to find the correct mode for long double type node, > it introduces one hook mode_for_longdouble to offer target > a way to specify the mode used for long double type node. I don't really like layering a hook on top of the old target macro as a way to address a deficiency in the design of that target macro (floating types should have their mode, not a poorly defined precision value, specified directly by the target). A better hook design might be something like mode_for_floating_type (enum tree_index), where the argument is TI_FLOAT_TYPE, TI_DOUBLE_TYPE or TI_LONG_DOUBLE_TYPE, replacing all definitions and uses of FLOAT_TYPE_SIZE, DOUBLE_TYPE_SIZE and LONG_DOUBLE_TYPE_SIZE with the single new hook and appropriate definitions for each target (with a default definition that uses SFmode for float and DFmode for double and long double, which would be suitable for many targets). -- Joseph S. Myers josmyers@redhat.com