From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 911793858D32 for ; Tue, 13 Jun 2023 02:21:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 911793858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8teZ-0006Zp-NE for gcc-patches@gcc.gnu.org; Mon, 12 Jun 2023 22:21:06 -0400 Received: from loongson.cn (unknown [10.20.4.52]) by gateway (Coremail) with SMTP id _____8DxDeuC0odktWAEAA--.9356S3; Tue, 13 Jun 2023 10:20:50 +0800 (CST) Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxVeSA0odkYjIYAA--.4003S2; Tue, 13 Jun 2023 10:20:49 +0800 (CST) Subject: Re: [PATCH] LoongArch: Set 4 * (issue rate) as the default for -falign-functions and -falign-loops To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: WANG Xuerui , Chenghua Xu References: <20230418121753.50830-1-xry111@xry111.site> <0c8216d3-c40d-fa38-5cd5-129b4c3a81bb@loongson.cn> <1880a04ddbc06eeba1a2d68d0c40e9d5ef68bd37.camel@xry111.site> <45202d67-5272-3dfb-e5bb-6318b28bab0f@loongson.cn> From: Lulu Cheng Message-ID: <6793fa2f-07a9-f902-bfc3-5e8738269185@loongson.cn> Date: Tue, 13 Jun 2023 10:20:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxVeSA0odkYjIYAA--.4003S2 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7tr1xXF1fXr13AFWxWFyfAFc_yoW8AFW7pF WfAFnFkFWDtr18Jw4jyw1rJr4qgw4rKryDXrWSk34rWws8KF9Ygr4rtFZ8CFy3urykGF1Y vF40q3W7Wwn8A3cCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr 0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzZ2- UUUUU Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-0.096,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/6/12 下午5:19, Xi Ruoyao 写道: > On Tue, 2023-05-30 at 09:30 +0800, Lulu Cheng wrote: >> 在 2023/5/29 下午2:09, Xi Ruoyao 写道: >>> On Tue, 2023-04-18 at 21:06 +0800, Lulu Cheng wrote: >>>> Hi, ruoyao: >>>> >>>> Thank you so much for making this submission. But we are testing >>>> the >>>> impact of these two alignment parameters >>>> >>>> (also including -falign-jumps and -falign-lables ) on performance. >>>> So >>>> before the result comes out, this patch will >>>> >>>> not be merged into the main branch for the time being. >>> Hi! >>> >>> Is there an estimate when the benchmark will be done?  If it will be >>> done soon I'll wait for the result before performing a full system >>> rebuild, otherwise I'll use my gut feeling to specify a -falign- >>> functions= value for the build :). >>> >> Sorry for taking so long to reply to the email. From our current test >> results, >> >> the performance of the SPEC is best when combined with -falign- >> loops=16, >> >> -falign-jumps=16, -falign-functions=32 and -falign-lables=16. > I've completed a system rebuild with -falign- > {jumps,functions,labels}=16. I've missed -falign-loops=16 but the doc > says -falign-labels=16 implies -falign-jumps=16 and -falign-loops=16 (if > -falign-jumps or -falign-loops are not set explicitly with a larger > value). > > I'll make a patch to set -falign-functions=32 and -falign-labels=16 with > -mtune={la464,loongarch64} after setting a basic develop environment on > the new system... And I'm wondering if things will change with LA664 > :). > > We haven't tested it on LA664 yet, so it's not clear whether this is consistent with LA464. This test will not be done on LA664 anytime soon. But once I've done the test, I'll let you know by email.