From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 9E6CF385C323 for ; Tue, 14 Jun 2022 19:12:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E6CF385C323 Received: by mail-pf1-x42f.google.com with SMTP id u37so977095pfg.3 for ; Tue, 14 Jun 2022 12:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=VoHMTyNXjjGZKzUv2uYUf7RKWW7dGIpHhOoBsRUAn2k=; b=rLkdgf7XnswvgbWLCNo0LxoRZDHp3okY6pOAhxSrh5UTzYknjfDATjrhbNbUwBmGQM GRPD6KeIsuslnGlw/BEPE77bei7pFN/q1pAyUKMFK8n9V7O5bfzPpyJ2z8Ujc397ew/Q +6LmlraQniXJfR1t/WNpunWgPk9YbO3oAJ9DLq8Do/W7yqn8foQ+Em0wddjx6+QOa0Bu 3KUYwonTBeOwFjsx+rlK3xKy1Xege/Bsj2UAUgSh1Z7JCc9xGR06RvypBKB1DVk2cWDQ lswYkOSjfppMpl/UQGvdTdm8M6Wz+bZTP8sEQG817VWcP6Wd7lRfrI6OjENFCnH+Q4/R 4lOA== X-Gm-Message-State: AOAM53094jd3pk1hDhM+yvxcn7XwdpQT2VBXpE9HMyVW/j69X4uL9t3+ eVGJd7A1gpfgLi72INzkCIeoGbh56bDAFQ== X-Google-Smtp-Source: AGRyM1uSKLTUMkpQ0rO+30jnuPQfBxz8o+sgc9BCl7A82WFf7LcTLFUKqaYHvWUka+MDHKW4EluqPQ== X-Received: by 2002:a05:6a00:893:b0:51e:77ab:8874 with SMTP id q19-20020a056a00089300b0051e77ab8874mr5730287pfj.21.1655233947533; Tue, 14 Jun 2022 12:12:27 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id o123-20020a62cd81000000b0051e6b11e595sm173831pfg.116.2022.06.14.12.12.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 12:12:26 -0700 (PDT) Message-ID: <67b605d7-a50e-8d96-e809-1150d5d068df@gmail.com> Date: Tue, 14 Jun 2022 13:12:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] opts: improve option suggestion Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <3b3b807f1dca4aa46e3068973fa301327806014a.camel@redhat.com> <2f8361de-d1b8-8d73-e346-b1d094a07768@suse.cz> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SCC_BODY_URI_ONLY, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2022 19:12:33 -0000 On 5/24/2022 2:45 AM, Martin Liška wrote: > PING^1 > > On 5/12/22 09:10, Martin Liška wrote: >> On 5/11/22 20:49, David Malcolm wrote: >>> On Wed, 2022-05-11 at 16:49 +0200, Martin Liška wrote: >>>> In case where we have 2 equally good candidates like >>>> -ftrivial-auto-var-init= >>>> -Wtrivial-auto-var-init >>>> >>>> for -ftrivial-auto-var-init, we should take the candidate that >>>> has a difference in trailing sign symbol. >>>> >>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >>>> >>>> Ready to be installed? >>>> Thanks, >>>> Martin >>>> >>>>         PR driver/105564 >>>> >>>> gcc/ChangeLog: >>>> >>>>         * spellcheck.cc (test_find_closest_string): Add new test. >>>>         * spellcheck.h (class best_match): Prefer a difference in >>>>         trailing sign symbol. OK jeff