Re: [PATCH][Testsuite] Use user defined memmove in gcc.c-torture/execute/builtins/memops-asm-lib.c

[Martin Sebor <msebor@gmail.com>]

On 06/23/2017 03:19 AM, Renlin Li wrote:
> Hi all,
>
> After the change r249278. bcopy is folded into memmove. And in newlib
> aarch64
> memmove implementation, it will call memcpy in certain conditions.
> The memcpy defined in memops-asm-lib.c will abort when the test is running.
>
> In this case, I defined a user memmove function which by pass the
> library one.
> So that memcpy won't be called accidentally.
>
> Okay to commit?

Having memmove call memcpy when there is no overlap seems like
a valid transformation.  I don't know which test specifically
fails so the question on my mind is whether it perhaps is overly
restrictive in assuming that this transformation must never take
place.  Other than that, although I can't really approve patches,
this one looks okay to me.  Thanks for getting to the bottom of
the failure and fixing it!

Martin

>
> gcc/testsuite/ChangeLog:
>
> 2017-06-22  Renlin Li  <renlin.li@arm.com>
>         Szabolcs Nagy  <szabolcs.nagy@arm.com>
>
>     * gcc.c-torture/execute/builtins/memops-asm-lib.c (my_memmove): New.
>     * gcc.c-torture/execute/builtins/memops-asm.c (memmove): Declare
> memmove.