From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30988 invoked by alias); 23 Jun 2017 15:27:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30245 invoked by uid 89); 23 Jun 2017 15:27:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f176.google.com Received: from mail-qk0-f176.google.com (HELO mail-qk0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Jun 2017 15:27:12 +0000 Received: by mail-qk0-f176.google.com with SMTP id 16so38309878qkg.2 for ; Fri, 23 Jun 2017 08:27:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=sn8AT21NjgS0d4aMfCtpEkzC3YdDWsDNWxlHyxQzopM=; b=a5uPVaTsNXXOWS8yuslL5fN2KaL75gsd8AXhRytJOacDvKK2epFmiUsT+8QrINDede rzrd6kz/c1G5G5WTwEPxCELQGKpSFNoOYwpcgwPiQXDUeBkP2X5UQOip5YrQOFo1p5NL udpmv22U/ckFN2VqokgfZc4aSDoI78/t7XVfbu+48iHcDhI18QNGLE6E0jdo0QdD0Zi2 wDcyPyrEmuhf77LGNeogdtV9SydA83b9Q5w4q+3BrjF5gVrEMpomOBOZR10QdkAb27GH dbtXiOv6Md0owAsH/+KE1Lhz8js7lzvyhhE+JXLE6Vsftevs5mgKnJQP8YhqOT4lfbRC Y3nw== X-Gm-Message-State: AKS2vOz7GAN1r8aDvRf3knkvgHzGd/UKKOyOg7ZOH7OQ9sAD/1NX8OlF AxlGAS9DoQ9MtQ== X-Received: by 10.55.78.88 with SMTP id c85mr10538170qkb.134.1498231630377; Fri, 23 Jun 2017 08:27:10 -0700 (PDT) Received: from localhost.localdomain (184-96-144-212.hlrn.qwest.net. [184.96.144.212]) by smtp.gmail.com with ESMTPSA id 34sm3760506qtp.17.2017.06.23.08.27.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 08:27:09 -0700 (PDT) Subject: Re: [PATCH][Testsuite] Use user defined memmove in gcc.c-torture/execute/builtins/memops-asm-lib.c To: Renlin Li , "gcc-patches@gcc.gnu.org" , richard.sandiford@arm.com References: <594CDD3A.9090902@foss.arm.com> From: Martin Sebor Message-ID: <67beba0f-5c33-871e-05b1-3244fbb752d6@gmail.com> Date: Fri, 23 Jun 2017 15:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <594CDD3A.9090902@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01795.txt.bz2 On 06/23/2017 03:19 AM, Renlin Li wrote: > Hi all, > > After the change r249278. bcopy is folded into memmove. And in newlib > aarch64 > memmove implementation, it will call memcpy in certain conditions. > The memcpy defined in memops-asm-lib.c will abort when the test is running. > > In this case, I defined a user memmove function which by pass the > library one. > So that memcpy won't be called accidentally. > > Okay to commit? Having memmove call memcpy when there is no overlap seems like a valid transformation. I don't know which test specifically fails so the question on my mind is whether it perhaps is overly restrictive in assuming that this transformation must never take place. Other than that, although I can't really approve patches, this one looks okay to me. Thanks for getting to the bottom of the failure and fixing it! Martin > > gcc/testsuite/ChangeLog: > > 2017-06-22 Renlin Li > Szabolcs Nagy > > * gcc.c-torture/execute/builtins/memops-asm-lib.c (my_memmove): New. > * gcc.c-torture/execute/builtins/memops-asm.c (memmove): Declare > memmove.