From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C18633857815 for ; Thu, 14 Mar 2024 07:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C18633857815 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C18633857815 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710403103; cv=none; b=isYQOZhzvCOLgPNTbb8nU3BHLLEPSA+AIvmfpGJRdeLQwe2d80PCF8NtQs6+9do2Y5219H4+tPOleJf8L2uulbafiPmjhvSjGCsvFLZMFvNyVYVlq9qUNAsxD/8XgT8OxjHYTTHNEFs0xehBj8s70mUQTZR2bE/pt+57TN83LF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710403103; c=relaxed/simple; bh=jLtUiC1Rer70e9PHwVPwz+YrEU6KslhvEMje1Wz3yq0=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=nhjPLjNw/hwpqdcHLl7Yo+HsrNrTBxtq3ueWbO9T6pxD4sAuSh8/6YivfDcpK8AQG90Df57lG8O06+tsZxGXahiBpjGQw/j+rpHLOHt0r+LMfBJGa2NQvA963YXB8U9kDoBfIzq8+/1snxjPFklT5Y3owuN8zv4bY4Zz/WNu+E4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkfyk-0008B3-7l for gcc-patches@gcc.gnu.org; Thu, 14 Mar 2024 03:58:20 -0400 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Axz+sRrvJlwgQZAA--.60469S3; Thu, 14 Mar 2024 15:58:09 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxjhMNrvJlOcxZAA--.48963S3; Thu, 14 Mar 2024 15:58:06 +0800 (CST) Subject: Re: [PATCH] LoongArch: Remove unused and incorrect "sge_" define_insn To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20240313130444.44708-1-xry111@xry111.site> From: chenglulu Message-ID: <67c10641-248e-78e7-6b6b-a9c9b3df62e9@loongson.cn> Date: Thu, 14 Mar 2024 15:58:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20240313130444.44708-1-xry111@xry111.site> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxjhMNrvJlOcxZAA--.48963S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7tFWDAFWrXFyrXFWfCr1xJFc_yoW8Zr4kpr WDuas2kr48Jr4xKw1kZay7Xw45WryxJrW7ZFW3Wwsakrnrur1xXFWjkr9IqFykXayFqr1I vF4rK3W3ZF45C3XCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1CP fJUUUUU== Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9,MIME_CHARSET_FARAWAY=2.45,NICE_REPLY_A=-1.763,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ÔÚ 2024/3/13 ÏÂÎç9:03, Xi Ruoyao дµÀ: > If this insn is really used, we'll have something like > > slti $r4,$r0,$r5 > > in the code. The assembler will reject it because slti wants 2 > register operands and 1 immediate operand. But we've not got any bug > report for this, indicating this define_insn is unused at all. > > Note that do_store_flag (in expr.cc) is already converting x >= 1 to > x > 0 unconditionally, so this define_insn is indeed unused and we can > just remove it. > > gcc/ChangeLog: > > * config/loongarch/loongarch.md (any_ge): Remove. > (sge_): Remove. > --- > > Not fully tested but should be obvious. Ok for trunk? LGTM! Thanks! > > gcc/config/loongarch/loongarch.md | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md > index 525e1e82183..18fd9c1e7d5 100644 > --- a/gcc/config/loongarch/loongarch.md > +++ b/gcc/config/loongarch/loongarch.md > @@ -517,7 +517,6 @@ (define_code_iterator equality_op [eq ne]) > ;; These code iterators allow the signed and unsigned scc operations to use > ;; the same template. > (define_code_iterator any_gt [gt gtu]) > -(define_code_iterator any_ge [ge geu]) > (define_code_iterator any_lt [lt ltu]) > (define_code_iterator any_le [le leu]) > > @@ -3355,15 +3354,6 @@ (define_insn "*sgt_" > [(set_attr "type" "slt") > (set_attr "mode" "")]) > > -(define_insn "*sge_" > - [(set (match_operand:GPR 0 "register_operand" "=r") > - (any_ge:GPR (match_operand:X 1 "register_operand" "r") > - (const_int 1)))] > - "" > - "slti\t%0,%.,%1" > - [(set_attr "type" "slt") > - (set_attr "mode" "")]) > - > (define_insn "*slt_" > [(set (match_operand:GPR 0 "register_operand" "=r") > (any_lt:GPR (match_operand:X 1 "register_operand" "r")