From: Vladimir Makarov <vmakarov@redhat.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR83712
Date: Sat, 10 Mar 2018 16:40:00 -0000 [thread overview]
Message-ID: <67d9e1eb-f04f-8bf6-9c9b-a694a41dd70c@redhat.com> (raw)
In-Reply-To: <5d72622b-a0bc-ec13-5cf3-e7573cba245e@redhat.com>
A few people reported that the patch broke i686. I am going to work on
the patch more. Meanwhile I've reverted the patch.
On 03/09/2018 11:16 AM, Vladimir Makarov wrote:
> The following patch fixes
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83712
>
> It is another "cannot find a spill reg for reload" problem. LRA has
> already a code splitting hard reg live ranges to avoid such problem.Â
> This code is in LRA inheritance pass. Unfortunately, the code does
> splitting for small class pseudos only. This PR is a more complicated
> code and it is hard to adapt the inheritance sub-pass to reliably
> solve such problems.
>
> To fix the PR, I added a sub-pass which works in very rare cases after
> we already found that we have no hard regs for a reload pseudo. It
> tries to split a hard reg live range for the pseudo. After that it
> tries again to assign a hard reg to the pseudo. The patch changes
> LRA-subpass flow for this. I hope that the patch will finally solved
> all such problems but I am not sure to be completely certain.
>
> The patch was bootstrapped and tested on x86-64 and ppc64.
>
> Committed as rev. 258390.
>
next prev parent reply other threads:[~2018-03-10 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 16:16 Vladimir Makarov
2018-03-09 16:42 ` Jeff Law
2018-03-10 13:31 ` H.J. Lu
2018-03-10 16:40 ` Vladimir Makarov [this message]
2018-03-10 16:43 ` Jeff Law
2018-03-13 21:56 Patch " Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d9e1eb-f04f-8bf6-9c9b-a694a41dd70c@redhat.com \
--to=vmakarov@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).