From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 0C4103858D1E for ; Sat, 18 Nov 2023 00:01:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C4103858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C4103858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700265698; cv=none; b=lbZ1/tFCfcpQmj/TNUp6wlFM0DEwlOnQYK3xMmIaLw+vJLcqGR4EKREbefojF18rBekPHf+wiWP7vgZ6/SCw1ikWFwvqlIaiHNxupoXe33kibwGGuAFNIpaTIFjYz1bpIyv5UDwaqW2x0QzBVhnacwGG+YBhI1asyqeiNBGbyOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700265698; c=relaxed/simple; bh=LAJ8JHzNdKKkDCtGPIkP7OelNYY3RV9B+SHTHLcuGQs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HCGXDXPHhWSEegS4TL43ZKEmiJOMjkOeoz75HXDUozHxc0qY8XI8OrzOweEfOe/OtYhfV8tKm4JlhxIx6F58x0KUynv4LgVT5cii3UnpAkEbLh/unrJhe8AZn64bZR451DCbw3Jl1jfdH9xsao3gZlmmPtjF+O/sx826Ozb1PMA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5c1f8b0c149so1425195a12.3 for ; Fri, 17 Nov 2023 16:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700265695; x=1700870495; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cW7HKyIbUHX+YaQafeHy7MFQcrtoOzknrNMSpr7uUoo=; b=igziKsxca1xB5Am0cF+BEimGYeUYpzuzcTxxNoB6JDwdsjixkSwCS4tBeV9h9JYGdS KE1VxSgCGFUS3H2fAflwtWStaveFirasUtY9X+pYoyp57iCNDXz0OP2GmZAcsejRYXeD eFyMMbXDgKLhnSVHpe/Q8PQlowlTMI0rpYUWdaX9Bm4VA4bTDtNBDHt0AOwmLUOHG/6u QM7Uityz0BFA/kI7Dhi0eyVpmonrnN2lonh/hFJhoTAdGC3X0o//4CG6otrwO6slE9YW Xn3E64q3f5e0Vjh4Msqfgnz27CTN4Pz+PJ3+VX/AGeLWHZXLR4lSGPkNKFBr09+4bWES Z9rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700265695; x=1700870495; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cW7HKyIbUHX+YaQafeHy7MFQcrtoOzknrNMSpr7uUoo=; b=PhwQc+jtU3cdYBmAF1Sbo7e5AOf3sHBdMyzOJ4y+fV+X4dJGWJJggKeYtgx9SqP0nK 8SFQSH5piXgu7XDp8Ju0+fihb9Hh00NZX5Hz7HwgPL7vA86OsdA9+vG03q0lXLdwgxzL tlr5DcXJobuwaVmY2s8NicOfGpJ7rnbpQ55KA6keRGlVbxi6nZQagblBYEvzbBNfHTVG RZPuA0phuPAQ93GKv3BGLWdjpY3bwoPXK9TULpBGYC9iSBuNIEv+lvp6SOdYHHGDTZyi 3NK7UKgyqyzW2JtdXcjOLxZtre8V1GKrt/Vl8NA4DqAx5dcuMsnGD9IfKU1pG9qI00J5 5W3g== X-Gm-Message-State: AOJu0Yx/1tEMjsJMHRqQJh9pdjBrWItwnwKNn/+U20w9ajW2ZcifjHpI G4uxWwkFUOFHXZpEpfIHMug= X-Google-Smtp-Source: AGHT+IEAe70YRBFPpiac3JxitKG6vw4VU1MEVYmvkfKF9iJFXXBvnnmqX3dWn+cC/A+DJhefNUibWQ== X-Received: by 2002:a17:90b:38c2:b0:280:22e2:60ea with SMTP id nn2-20020a17090b38c200b0028022e260eamr1128901pjb.3.1700265694565; Fri, 17 Nov 2023 16:01:34 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id t2-20020a17090aae0200b00274262bcf8dsm3698048pjq.41.2023.11.17.16.01.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 16:01:34 -0800 (PST) Message-ID: <67df2e14-448a-4b2f-970e-63bff13cb17f@gmail.com> Date: Fri, 17 Nov 2023 17:01:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: RISC-V: Support XTheadVector extensions Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , palmer Cc: gcc-patches , "kito.cheng" , "kito.cheng" , "cooper.joshua" , "rdapp.gcc" References: <38511D776BA09E14+2023111807161322258411@rivai.ai> From: Jeff Law In-Reply-To: <38511D776BA09E14+2023111807161322258411@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/17/23 16:16, 钟居哲 wrote: > >> I assume this hunk is meant for riscv_output_operand in riscv.cc.  We >>>may also need to add '^' to the punct_valid_p hook.  But yes, this is >>>the preferred way to go when all we need to do is prefix the instruction >>>with "th.". > > No. I don't think we need to add '^' . I don't want theadvector to touch > any codes > of vector.md. > Mixing up theadvector with RVV1.0 is a nighmare for RVV maintain. > People like me don't want to touch any thing related to Thead. > But anyway, I will take care of that in GCC-15. I suspect it's going to be even worse if you we have multiple patterns with the same underlying RTL, but just different output strings. The standard way to handle that has been with an output modifier and/or ASSEMBLER_DIALECT. If you look at the PA port for example, the assembler syntax changed dramatically between the PA1.0/PA1.1 era and the PA2.0 era. But we support both variants trivially without duplicating all the patterns. But we've got time to sort this out. I don't think the code in question was targeted towards gcc-14. jeff