public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gcc-patches@gcc.gnu.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] testsuite: Allow for non-SECTION_MERGE systems in gcc.dg/pr115066.c [PR115066]
Date: Tue, 21 May 2024 14:04:35 -0400	[thread overview]
Message-ID: <67edb3e3-c0b7-44c5-b3b9-5c8a98713fb0@redhat.com> (raw)
In-Reply-To: <ydded9vv1lh.fsf@CeBiTec.Uni-Bielefeld.DE>

On 5/21/24 07:36, Rainer Orth wrote:
> gcc.dg/pr115066.c currently FAILs on Solaris/SPARC with the native as:
> 
> FAIL: gcc.dg/pr115066.c scan-assembler \\\\.byte\\\\t0xb\\\\t# Define macro strx
> 
> Instead of the expected
> 
> 	.byte   0xb     ! Define macro strx
> 
> the assembler output contains
> 
> 	.byte   0x1     ! Define macro
> 
> Apparently this happens because the Solaris as/ld combo doesn't support
> SHF_MERGE.
> 
> While I initially meant to just skip the test on sparc*-*-solaris2* && !gas,
> Tom suggested to allow for both forms instead, which is what his patch
> does.
> 
> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (as and gas
> each) and x86_64-pc-linux-gnu.
> 
> Ok for trunk?

OK.


      reply	other threads:[~2024-05-21 18:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 11:36 Rainer Orth
2024-05-21 18:04 ` Jason Merrill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67edb3e3-c0b7-44c5-b3b9-5c8a98713fb0@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).