public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Allow for non-SECTION_MERGE systems in gcc.dg/pr115066.c [PR115066]
@ 2024-05-21 11:36 Rainer Orth
  2024-05-21 18:04 ` Jason Merrill
  0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2024-05-21 11:36 UTC (permalink / raw)
  To: gcc-patches; +Cc: Tom de Vries, Jason Merrill

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

gcc.dg/pr115066.c currently FAILs on Solaris/SPARC with the native as:

FAIL: gcc.dg/pr115066.c scan-assembler \\\\.byte\\\\t0xb\\\\t# Define macro strx

Instead of the expected

	.byte   0xb     ! Define macro strx

the assembler output contains

	.byte   0x1     ! Define macro

Apparently this happens because the Solaris as/ld combo doesn't support
SHF_MERGE.

While I initially meant to just skip the test on sparc*-*-solaris2* && !gas,
Tom suggested to allow for both forms instead, which is what his patch
does.

Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (as and gas
each) and x86_64-pc-linux-gnu.

Ok for trunk?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2024-05-21  Tom de Vries  <tdevries@suse.de>

	gcc/testsuite:
	PR debug/115066
	* gcc.dg/pr115066.c (scan-assembler): Allow for alternative form
	of Define macro.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sol2sparc-testsuite-pr115066.patch --]
[-- Type: text/x-patch, Size: 754 bytes --]

# HG changeset patch
# Parent  630ea4594490d9bd4911b95d13eaca62a8cd4dba
testsuite: Allow for non-SECTION_MERGE systems in gcc.dg/pr115066.c [PR115066]

diff --git a/gcc/testsuite/gcc.dg/pr115066.c b/gcc/testsuite/gcc.dg/pr115066.c
--- a/gcc/testsuite/gcc.dg/pr115066.c
+++ b/gcc/testsuite/gcc.dg/pr115066.c
@@ -3,6 +3,6 @@
 /* { dg-options "-gsplit-dwarf -g3 -dA -gdwarf-4" } */
 /* { dg-final { scan-assembler-times {\.section\t"?\.debug_macro} 1 } } */
 /* { dg-final { scan-assembler-not {\.byte\t0x5\t[^\n\r]* Define macro strp} } } */
-/* { dg-final { scan-assembler {\.byte\t0xb\t[^\n\r]* Define macro strx} } } */
+/* { dg-final { scan-assembler {\.byte\t0xb\t[^\n\r]* Define macro strx|\.byte\t0x1\t[^\n\r]* Define macro} } } */
 
 #define foo 1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: Allow for non-SECTION_MERGE systems in gcc.dg/pr115066.c [PR115066]
  2024-05-21 11:36 [PATCH] testsuite: Allow for non-SECTION_MERGE systems in gcc.dg/pr115066.c [PR115066] Rainer Orth
@ 2024-05-21 18:04 ` Jason Merrill
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Merrill @ 2024-05-21 18:04 UTC (permalink / raw)
  To: Rainer Orth, gcc-patches; +Cc: Tom de Vries

On 5/21/24 07:36, Rainer Orth wrote:
> gcc.dg/pr115066.c currently FAILs on Solaris/SPARC with the native as:
> 
> FAIL: gcc.dg/pr115066.c scan-assembler \\\\.byte\\\\t0xb\\\\t# Define macro strx
> 
> Instead of the expected
> 
> 	.byte   0xb     ! Define macro strx
> 
> the assembler output contains
> 
> 	.byte   0x1     ! Define macro
> 
> Apparently this happens because the Solaris as/ld combo doesn't support
> SHF_MERGE.
> 
> While I initially meant to just skip the test on sparc*-*-solaris2* && !gas,
> Tom suggested to allow for both forms instead, which is what his patch
> does.
> 
> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (as and gas
> each) and x86_64-pc-linux-gnu.
> 
> Ok for trunk?

OK.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-21 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-21 11:36 [PATCH] testsuite: Allow for non-SECTION_MERGE systems in gcc.dg/pr115066.c [PR115066] Rainer Orth
2024-05-21 18:04 ` Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).