From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18958 invoked by alias); 3 Aug 2018 20:54:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18939 invoked by uid 89); 3 Aug 2018 20:54:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=torvald, Riegel, oliva, riegel X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Aug 2018 20:54:10 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A55130820F4; Fri, 3 Aug 2018 20:54:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-6.rdu2.redhat.com [10.10.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C54C17A40; Fri, 3 Aug 2018 20:54:05 +0000 (UTC) Subject: Re: [PATCH v2] libitm: sh: avoid absolute relocation in shared library (PR 86712) To: slyfox@inbox.ru, gcc-patches@gcc.gnu.org, Andreas Schwab Cc: Sergei Trofimovich , Torvald Riegel , Alexandre Oliva , Oleg Endo , Kaz Kojima References: <87in4zbkh9.fsf@igel.home> <20180728130416.7730-1-slyfox@inbox.ru> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <67f4e6b4-931a-6c4c-a9a7-25e1d65f7b75@redhat.com> Date: Fri, 03 Aug 2018 20:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180728130416.7730-1-slyfox@inbox.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00312.txt.bz2 On 07/28/2018 07:04 AM, slyfox.inbox.ru via gcc-patches wrote: > From: Sergei Trofimovich > > Cc: Andreas Schwab > Cc: Torvald Riegel > Cc: Alexandre Oliva > Cc: Oleg Endo > Cc: Kaz Kojima > Signed-off-by: Sergei Trofimovich > --- > libitm/config/sh/sjlj.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S > index 043f36749be..f265ab8f898 100644 > --- a/libitm/config/sh/sjlj.S > +++ b/libitm/config/sh/sjlj.S > @@ -53,7 +53,7 @@ _ITM_beginTransaction: > #else > cfi_def_cfa_offset (4*10) > #endif > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__ > +#if !defined __PIC__ > mov.l .Lbegin, r1 > jsr @r1 > mov r15, r5 > @@ -78,7 +78,7 @@ _ITM_beginTransaction: > > .align 2 > .Lbegin: > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__ > +#if !defined __PIC__ > .long GTM_begin_transaction > #else > .long GTM_begin_transaction@PCREL-(.Lbegin0-.) > THanks. I installed this version. jeff