From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 75496385840B for ; Tue, 5 Oct 2021 17:08:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 75496385840B Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-qvLfY0X2NKeIXMpq6lRA6A-1; Tue, 05 Oct 2021 13:08:50 -0400 X-MC-Unique: qvLfY0X2NKeIXMpq6lRA6A-1 Received: by mail-qk1-f197.google.com with SMTP id q5-20020a05620a0d8500b0045edb4779dbso1865112qkl.2 for ; Tue, 05 Oct 2021 10:08:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2d9me98rb04OB3PZP+pZx48I/jdis4z9oIAPyYSOZ4k=; b=urYui3XPe+B34Me1mluTHBFtDSzeumVqWcDYE0ST0zXyVStTdPhRoYOXecs8wR5tYo WE7sptgFeVqATZ0UxZ9XOxY8gj+fDgmskvFNj9Oii7Ormdt4d+bhVNBWTUaK61pxgvsP cpBiEPIKxfE26WuMqULyELtK8nTijklmCEtzcTs3goOxWN+5J6YhCzTropm4rsuvKXJp za+uoUYnItXWJseSewarXzPkyJgXz+i40DHUiq2m8sqASeZQcQ1EKrLTbUxgqUuLcCk2 g7XFq4n0PcaA0QZHnG9l18y6iqjskr1SJlenuVfBK1Mti8L4O5+wchnbWO6i5grLFNPX euOw== X-Gm-Message-State: AOAM531QYjG5lShpqfUGwt7i4YsHI+DLFPpPf8O5BtevHY/27zmTbTvj z8wLvc+hpt4kqNOuWP5bT2FO3+BNgsO+GSjUdF4BXMwrnTyrilKGzHwbjGDtfAvXHHwVLFAPs+u Uc6EjUfvcXeuZign1+VX25ohj7pzltnSuG73CDQuqrOzOYDT1LTZ4ew2pVGKHGfPG6o2FNg== X-Received: by 2002:ac8:9c:: with SMTP id c28mr20969577qtg.137.1633453729139; Tue, 05 Oct 2021 10:08:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+0xCzUJI+kgxm1TQC6Mx9VHXMCROpFFab/kyKOM2rNHOM2rkNhedDBRAijnRoub6kR9O4nw== X-Received: by 2002:ac8:9c:: with SMTP id c28mr20969546qtg.137.1633453728902; Tue, 05 Oct 2021 10:08:48 -0700 (PDT) Received: from [192.168.0.102] ([104.219.123.55]) by smtp.gmail.com with ESMTPSA id k16sm11648641qta.27.2021.10.05.10.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 10:08:48 -0700 (PDT) Subject: Re: [PATCH] Loop unswitching: support gswitch statements. To: Richard Biener , =?UTF-8?Q?Martin_Li=c5=a1ka?= Cc: GCC Patches References: From: Andrew MacLeod Message-ID: <6813defb-dcfb-ea6e-18f8-2985b389ec2c@redhat.com> Date: Tue, 5 Oct 2021 13:08:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-CA X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 17:08:52 -0000 On 9/28/21 7:50 AM, Richard Biener wrote: > On Wed, Sep 15, 2021 at 10:46 AM Martin Liška wrote: >> Hello. >> >> The patch extends the loop unswitching pass so that gswitch >> statements are supported. The pass now uses ranger which marks >> switch edges that are known to be unreachable in a versioned loop. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? >> Thanks, >> Martin >> Do you have any switch size restrictions or limits? I'm about to add --param which will limit ranger to switches of a specified size, defaulting to 50 outgoing edges. It turns out a number of the pathological cases we see are very large switches, and we spend a lot of time processing and unioning ranges on the various edges and at meet points. Anyway, the limit will make ranger not "see" switches above the threshold, so it will not generate ranges for them. I hope to eliminate this for next release, but for now it serves a purpose. The patch currently makes this apply to all rangers, but if this is problematic for you, I will adjust it to make sure its only when invoked via EVRP. Andrew