From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A48DE3858032 for ; Fri, 3 Mar 2023 15:05:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A48DE3858032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 323EPgEI003210 for ; Fri, 3 Mar 2023 15:05:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=8L60CQenoXjZ5BQqxZCX5AHSmlzuKVnOA0o4oj3AOeU=; b=gGdbagJHe14uEyZqg2iVwF6PPFLVZa4vfBU2U005R3Yui06gHmNx74RLEjgEcIUOoK0Y xLMDdAchaZKdMd45YJCz2idiYXqJWbnpmBlRn0dzuYs4TRt3r6MgXEtwgm+gBvizRk2o z8/W1msVvT8BmQdXap/5rVtcKlnYeaYU8AQs4TGzpVkvDdvnhUWklaWlUUD8rQ5H7VdE CvTJ+B3lPWKRBu+ZI3togW4+eQDyrndRZLuAcGcXH8LUwCZ/0hzhzD7ZMgE3aeVTuRWO Vk4CY0BA2gC/wcdKZCbKL+2spLXCTtJkuxiro8vJ7NDzPNGOcXEJgGnjKJYtutPqjByz sA== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p3jn8hfng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 03 Mar 2023 15:05:32 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 323C80PT013009 for ; Fri, 3 Mar 2023 15:05:30 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3nybcq7ahf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 03 Mar 2023 15:05:30 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 323F5QVC29688564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Mar 2023 15:05:27 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFDB520043; Fri, 3 Mar 2023 15:05:26 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A5A420040; Fri, 3 Mar 2023 15:05:26 +0000 (GMT) Received: from [9.171.11.44] (unknown [9.171.11.44]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 3 Mar 2023 15:05:26 +0000 (GMT) Message-ID: <6817d605-18f5-262c-32e8-232e29a80a76@linux.ibm.com> Date: Fri, 3 Mar 2023 16:05:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] s390: Fix ifcvt test cases Content-Language: en-US To: Robin Dapp , GCC Patches References: <3d239f06-9289-b54b-515f-f77ba69c07fe@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <3d239f06-9289-b54b-515f-f77ba69c07fe@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: khrljocmcDho4gqPswxqDW1IhWtxxxjB X-Proofpoint-ORIG-GUID: khrljocmcDho4gqPswxqDW1IhWtxxxjB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-03_02,2023-03-03_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303030130 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/2/23 19:13, Robin Dapp wrote: > Hi, > > we seem to flip flop between the "high" and "not low" variants of load on > condition. Accept both in the affected test cases. > > Going to commit this as obvious. > > Regards > Robin > > -- > > gcc/testsuite/ChangeLog: > > * gcc.target/s390/ifcvt-two-insns-bool.c: Allow "high" and > "not low or equal" load on condition variant. > * gcc.target/s390/ifcvt-two-insns-int.c: Dito. > * gcc.target/s390/ifcvt-two-insns-long.c: Dito. Ok. Thanks! Andreas > --- > gcc/testsuite/gcc.target/s390/ifcvt-two-insns-bool.c | 4 ++-- > gcc/testsuite/gcc.target/s390/ifcvt-two-insns-int.c | 4 ++-- > gcc/testsuite/gcc.target/s390/ifcvt-two-insns-long.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-bool.c b/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-bool.c > index 1027ddceb935..a56bc4676143 100644 > --- a/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-bool.c > +++ b/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-bool.c > @@ -3,8 +3,8 @@ > /* { dg-do run } */ > /* { dg-options "-O2 -march=z13 -mzarch --save-temps" } */ > > -/* { dg-final { scan-assembler "lochih\t%r.?,1" } } */ > -/* { dg-final { scan-assembler "locrh\t.*" } } */ > +/* { dg-final { scan-assembler "lochi(?:h|nle)\t%r.?,1" } } */ > +/* { dg-final { scan-assembler "locr(?:h|nle)\t.*" } } */ > #include > #include > #include > diff --git a/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-int.c b/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-int.c > index fc6946f2466d..64b8a732290e 100644 > --- a/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-int.c > +++ b/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-int.c > @@ -3,8 +3,8 @@ > /* { dg-do run } */ > /* { dg-options "-O2 -march=z13 -mzarch --save-temps" } */ > > -/* { dg-final { scan-assembler "lochih\t%r.?,1" } } */ > -/* { dg-final { scan-assembler "locrh\t.*" } } */ > +/* { dg-final { scan-assembler "lochi(h|nle)\t%r.?,1" } } */ > +/* { dg-final { scan-assembler "locr(?:h|nle)\t.*" } } */ > #include > #include > #include > diff --git a/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-long.c b/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-long.c > index 51af4985247a..f2d784e762a8 100644 > --- a/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-long.c > +++ b/gcc/testsuite/gcc.target/s390/ifcvt-two-insns-long.c > @@ -3,8 +3,8 @@ > /* { dg-do run } */ > /* { dg-options "-O2 -march=z13 -mzarch --save-temps" } */ > > -/* { dg-final { scan-assembler "locghih\t%r.?,1" } } */ > -/* { dg-final { scan-assembler "locgrh\t.*" } } */ > +/* { dg-final { scan-assembler "locghi(?:h|nle)\t%r.?,1" } } */ > +/* { dg-final { scan-assembler "locgr(?:h|nle)\t.*" } } */ > > #include > #include