From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 603423858D20 for ; Mon, 29 Jan 2024 12:03:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 603423858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 603423858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706529838; cv=none; b=hSuE71Pln1dvB1nviM0yRoU/PQqcww1W7VL+hyfjYLrNtSy2NIQTn/Q5YYYeBmpBvEUqCJ/rHMUC2qUirAtBHHv+B6Bnz8RRuTFHBoWjYB02vqxf6jY8ZyfQaPEG2j4r6slNF0KrK+FXmkEkyNc86Mz7tfOCMuk10BIJj1tSn4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706529838; c=relaxed/simple; bh=XB0Ko5qCKIQbhNSmXIdR47QlyfFTPGKWAiLdxZ9ltDM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=qJc3LLx4iC8GRHAP8c3srCqGg91wCDNTD/qKIpe22olP71mINJHg330CXDNPIT+WTg7NnsQ64kae6azrYIGjnxnLltCBNNR4nFUQLc29yFX/h6LKOxCYoLPUtAEmsnSv3dlDFB3gAEffU0wjD/HTaFikMrZMX1EgOWxpo3NHyAQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02AD91F7EB; Mon, 29 Jan 2024 12:03:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706529835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Eqo1Yq6OmpH+gHdtRpZIyyodrcfCvDB1A23lYdNszlE=; b=e9BT3v9nRvNapnwuLegxSqey0qSa5txCj1huTZn8fLTqxl7yWdvEknTYw5iLoe3joG/SJI ddeUVIRSPkKfZfmcePkCarmSsOVVATk3qk247HXcb4ONSa6pCUbRrHwcfgDF6gFpiK8OQE 04JS2uKqpzaQLWg53RntaWbNAb0szyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706529835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Eqo1Yq6OmpH+gHdtRpZIyyodrcfCvDB1A23lYdNszlE=; b=D1cPdmEGGqHzICXhFgY+7qn/P3Jj3AmSE4SM/4b5fuivuduhrgzA3408ej+Q+LsSINlrIO To+zdNKPJkttrhAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706529833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Eqo1Yq6OmpH+gHdtRpZIyyodrcfCvDB1A23lYdNszlE=; b=1tXu3hFFQZC05gl9FkEr9tcrY9ho5L+NCY4H0cAgdcvuzwtg3vD1MMMZ2CUXfGsZhlhhly 66IMKNH62B3G4LC5dihRNXflo1EVwLJZegxl1a2xDyF0Th1dM63+wts7l+PruZJPdFITsl V4R7B63lxTnvG8nzHc1a2Oma3pyl5nI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706529833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Eqo1Yq6OmpH+gHdtRpZIyyodrcfCvDB1A23lYdNszlE=; b=gBe21qxRdKaoewCsfWx0Y/OrPx9d669ixAWrM9XQzxCfGZC3bkvOcR5QhhmonCduOhoi0g 0IJizsN7r/7gA+Cw== Date: Mon, 29 Jan 2024 12:58:20 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] middle-end/113622 - allow .VEC_SET and .VEC_EXTRACT for global hard regs In-Reply-To: Message-ID: <686son31-sn83-755r-8p08-5os7op468o16@fhfr.qr> References: <20240129103038.CAAD13858439@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -2.83 X-Spamd-Result: default: False [-2.83 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(1.27)[0.423]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[gcc.target:url,gimple-isel.cc:url,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 29 Jan 2024, Jakub Jelinek wrote: > On Mon, Jan 29, 2024 at 11:24:58AM +0100, Richard Biener wrote: > > The following expands .VEC_SET and .VEC_EXTRACT instruction selection > > to global hard registers, not only automatic variables (possibly) > > promoted to registers. This can avoid some ICEs later and create > > better code. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > > > OK? > > > > Thanks, > > Richard. > > > > PR middle-end/113622 > > * gimple-isel.cc (gimple_expand_vec_set_extract_expr): > > Also allow DECL_HARD_REGISTER variables. > > > > * gcc.target/i386/pr113622-1.c: New testcase. > > --- > > gcc/gimple-isel.cc | 3 ++- > > gcc/testsuite/gcc.target/i386/pr113622-1.c | 12 ++++++++++++ > > 2 files changed, 14 insertions(+), 1 deletion(-) > > create mode 100644 gcc/testsuite/gcc.target/i386/pr113622-1.c > > > > diff --git a/gcc/gimple-isel.cc b/gcc/gimple-isel.cc > > index 7e2392ecd38..e94f292dd38 100644 > > --- a/gcc/gimple-isel.cc > > +++ b/gcc/gimple-isel.cc > > @@ -104,7 +104,8 @@ gimple_expand_vec_set_extract_expr (struct function *fun, > > machine_mode outermode = TYPE_MODE (TREE_TYPE (view_op0)); > > machine_mode extract_mode = TYPE_MODE (TREE_TYPE (ref)); > > > > - if (auto_var_in_fn_p (view_op0, fun->decl) > > + if ((auto_var_in_fn_p (view_op0, fun->decl) > > + || DECL_HARD_REGISTER (view_op0)) > > && !TREE_ADDRESSABLE (view_op0) > > && ((!is_extract && can_vec_set_var_idx_p (outermode)) > > || (is_extract > > All we know here from the earlier checks is DECL_P (view_op0), but > DECL_HARD_REGISTER uses VAR_DECL_CHECK, shouldn't this be > || (VAR_P (view_op0) && DECL_HARD_REGISTER (view_op0))) > instead? Ah, yeah - will fix. > > diff --git a/gcc/testsuite/gcc.target/i386/pr113622-1.c b/gcc/testsuite/gcc.target/i386/pr113622-1.c > > new file mode 100644 > > index 00000000000..2d6cb3c89a8 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/i386/pr113622-1.c > > @@ -0,0 +1,12 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-O2 -mavx512f -w" } */ > > + > > +typedef float __attribute__ ((vector_size (64))) vec; > > +register vec a asm("zmm2"), b asm("zmm0"), c asm("zmm1"); > > I'd feel better if this used say zmm5, zmm6, zmm7 or something similar > so that it doesn't clash with some of the implicitly used SSE > registers, but on the other side still fit into 8 SSE registers > which ia32 has access to. OK, will adjust. Thanks, Richard. > > + > > +void > > +test (void) > > +{ > > + for (int i = 0; i < 8; i++) > > + c[i] = a[i] < b[i] ? 0.1 : 0.2; > > +} > > Otherwise LGTM. > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)