From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110559 invoked by alias); 13 Oct 2017 14:15:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110463 invoked by uid 89); 13 Oct 2017 14:14:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Oct 2017 14:14:58 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EA8787649; Fri, 13 Oct 2017 14:14:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0EA8787649 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law@redhat.com Received: from localhost.localdomain (ovpn-112-4.rdu2.redhat.com [10.10.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38E2618B94; Fri, 13 Oct 2017 14:14:56 +0000 (UTC) Subject: Re: [PATCH] Fix bitmap_bit_in_range_p (PR tree-optimization/82493). To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc-patches@gcc.gnu.org References: <9c9fd60f-cb7a-e702-aabb-9e31dca6a92a@suse.cz> <2215478f-6715-189a-e6a4-8d171901d31f@redhat.com> <467ec34e-7af8-b5b8-264a-a336bd810e49@suse.cz> From: Jeff Law Message-ID: <68952825-154d-7821-d755-cb18e2f48ff9@redhat.com> Date: Fri, 13 Oct 2017 14:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00868.txt.bz2 On 10/13/2017 07:03 AM, Martin Liška wrote: > On 10/13/2017 10:01 AM, Martin Liška wrote: >> On 10/12/2017 11:54 PM, Jeff Law wrote: >>> On 10/11/2017 12:13 AM, Martin Liška wrote: >>>> 2017-10-10 Martin Liska >>>> >>>> PR tree-optimization/82493 >>>> * sbitmap.c (bitmap_bit_in_range_p): Fix the implementation. >>>> (test_range_functions): New function. >>>> (sbitmap_c_tests): Likewise. >>>> * selftest-run-tests.c (selftest::run_tests): Run new tests. >>>> * selftest.h (sbitmap_c_tests): New function. >>> I went ahead and committed this along with a patch to fix the off-by-one >>> error in live_bytes_read. Bootstrapped and regression tested on x86. >>> >>> Actual patch attached for archival purposes. >>> >>> Jeff >>> >> >> Thanks. >> >> I'll carry on and write another set of unit tests. >> >> Martin >> > > Sending patch candidate, may I install it after it finishes regression tests? Yes. Please. Jeff