From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5721 invoked by alias); 22 Jan 2013 00:44:07 -0000 Received: (qmail 5670 invoked by uid 22791); 22 Jan 2013 00:44:06 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from na3sys009aog123.obsmtp.com (HELO na3sys009aog123.obsmtp.com) (74.125.149.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jan 2013 00:43:50 +0000 Received: from sc-owa02.marvell.com ([199.233.58.137]) (using TLSv1) by na3sys009aob123.postini.com ([74.125.148.12]) with SMTP ID DSNKUP3gwpj3vfgcbHb8BTxuFAhI5MVS12ZG@postini.com; Mon, 21 Jan 2013 16:43:50 PST Received: from SC-vEXCH2.marvell.com ([10.93.76.134]) by sc-owa02.marvell.com ([10.93.76.22]) with mapi; Mon, 21 Jan 2013 16:43:45 -0800 From: Yi-Hsiu Hsu To: "ramrad01@arm.com" CC: "gcc-patches@gcc.gnu.org" Date: Tue, 22 Jan 2013 00:44:00 -0000 Subject: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores Message-ID: <689C75E0D210324F8BE88961219F681629F811A69D@SC-VEXCH2.marvell.com> References: <689C75E0D210324F8BE88961219F681624B5949520@SC-VEXCH2.marvell.com> <689C75E0D210324F8BE88961219F681624B5BCD276@SC-VEXCH2.marvell.com> <50F95BFB.1060808@arm.com> <689C75E0D210324F8BE88961219F681629F811A54C@SC-VEXCH2.marvell.com> <50FD1ED0.8090807@arm.com> In-Reply-To: <50FD1ED0.8090807@arm.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01071.txt.bz2 Hi Ramana, Sorry for missing the Changelog, I will add it for future patches. Thanks for your kindly help. Cheers, Compiler Team @ MTL Yi-Hsiu, Hsu -----Original Message----- From: Ramana Radhakrishnan [mailto:ramrad01@arm.com]=20 Sent: Monday, January 21, 2013 6:56 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores Hi Yi-Hsiu Hsu, On 01/21/13 08:51, Yi-Hsiu Hsu wrote: > Hi Ramana, > > Attached is the patch for marvell-pj4.md to fix the simple_alu_shift cate= gory. > Thanks for your kindly help. In the future please submit patches with a Changelog entry. I've created on= e for this patch as it needed a bit of splitting up given the mis-commit ea= rlier by doko. So in this case I've now committed the following with the following Changel= og entry. Regards, Ramana 2013-01-21 Yi-Hsiu Hsu * config/arm/marvell-pj4.md (pj4_shift_conds, pj4_alu_shift, pj4_alu_shift_conds, pj4_shift): Handle simple_alu_shift. > > Cheers, > Yi-Hsiu, Hsu > > -----Original Message----- > From: Ramana Radhakrishnan [mailto:ramrad01@arm.com] > Sent: Friday, January 18, 2013 10:28 PM > To: Yi-Hsiu Hsu > Cc: gcc-patches@gcc.gnu.org ; > Subject: Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores > > On 06/20/12 03:53, Yi-Hsiu Hsu wrote: >> marvell-pj4 is added to BE8_LINK_SPEC. > > Sorry about the time it's taken to finish this patch up. I seem to have m= issed this one in the review process. > > I've now applied the attached patch after taking into account the recent = attribute changes and treated alu_reg and simple_alu_imm as you have treate= d alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. > > Additionally I've removed tune_marvell as that seems redundant at this po= int of time - an additional attribute and testing that appears to be unnece= ssary instead of just one more inequality test. > > The only part I'm not sure about is how to treat the simple_alu_shift cat= egory here , so a patch to handle them in the pj4 pipeline description woul= d be welcome. > > > Thanks > Ramana > > 2013-01-18 Yi-Hsiu Hsu > Ramana Radhakrishnan > > * config/arm/marvell-pj4.md: New file. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm.md (generic_sched): Add marvell_pj4. > (generic_vfp): Likewise. > * config/arm/arm-cores.def: Add marvell-pj4. > * config/arm/arm-tune.md: Regenerate. > * config/arm/arm-tables.opt: Regenerate. > * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. > * doc/invoke.texi: Document marvell-pj4. > >> >> Modified patch is attached. >> >> Thanks! >> >> B.R. >> Yi-Hsiu, Hsu >> >> -----Original Message----- >> From: Ramana Radhakrishnan [mailto:ramana.radhakrishnan@linaro.org] >> Sent: Thursday, June 14, 2012 2:19 AM >> To: Yi-Hsiu Hsu >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores >> >> On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: >>> Hi, >>> >>> This patch maintains Marvell PJ4 cores pipeline description. >>> Run arm testsuite on arm-linux-gnueabi and no extra regressions are fou= nd. >>> >>> * config/arm/marvell-pj4.md: New marvell-pj4 pipeline descript= ion. >>> * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. >>> * config/arm/arm-cores.def: Add core marvell-pj4. >>> * config/arm/arm-tune.md: Regenerated. >>> * config/arm/arm-tables.opt: Regenerated. >>> * doc/invoke.texi: Added entry for marvell-pj4. >> >> This command line option should also be added to BE8_LINK_SPEC=20 >> similar to what's done for the other v7-a cores. >> >> Ok with that change. >> >> regards, >> Ramana >> >> >> >>> >>> >>> Thanks! >>> >>> P.S. I create the patch from revision 187308, but this revision is unab= le to build successfully, then I apply this patch to revision 187623 and su= ccessfully build and pass the testsuite. >>> =3D