From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 80DA83858CD1 for ; Mon, 11 Dec 2023 16:18:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80DA83858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 80DA83858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702311496; cv=none; b=chzJ3oHukdRR+sNxhpaCx9xPdKoPTOHgwJO5WsG6898Yu+Dyvo+OiCYs78IpMRFsCz0bRzPPWwN+pSM0bHq0xlIcovW0XcD4f42bPsfMBP43R0WsleVUqn1Wm1k1lA9TZ6hhtKIxmZOEjrwhcB2merwtxi5aG2OJ/+rKP1okLDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702311496; c=relaxed/simple; bh=+QFdVaQjavbGJGTjb7/mxVy7198lOEEGsASAMIv0O0c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iCzhNNq0WPqoZiU39B8FhMhY026lewBL6MOCaRFeug9uUffQDrUvIxVf8Q38MBWEsnaJm6Rq51Z9y3bwzgvdMvSueX7uVUm9rWH4iVFDSwtcq0fg2dhezusgb4fCQ8q2udroM1WWu99VGN+9KAOznT4qziNegRHrmi2PUv5MhnI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54c77e0835bso6743549a12.2 for ; Mon, 11 Dec 2023 08:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702311486; x=1702916286; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MXucPf/cD7YC7+jk6y5R7RbSz8Hxgjons0phtvLiIKE=; b=gCMRdfbaul8D4KsRWqxc/XeiKqlivRYFYCc2Zg7w7tA+9+fJOUcUipCM4v79o/EyAQ Xcxv30kYUBsc8xVSPnysz0Fmak+PMpFA1Ch67TkwzjlTGHwvomZwm97j6QA6yZXmvvDP wA8zg7sZtW/OalQ+x9psdZCL+YCYw2Kk8WrAc4cUfnPZ5H8j9glqpoiw0A9DAhA0c5Mv 95XLT8GY8cxFPwfqrTSH83ejoZERDTuVIF6jZfAkipYqF/+pY8B85DM3pcOBzzfSINcG AboEBZmedwBqqdYMtVIlqUBNNnvER9peV4PMrrw/1J91JzbI1taclw+7d5H+tW0gB1B6 csog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702311486; x=1702916286; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MXucPf/cD7YC7+jk6y5R7RbSz8Hxgjons0phtvLiIKE=; b=fhQ1F9d+zBLpCO45r5zy5+6aLLnrwc9BEBj1pBJSCGxvC/cfZgf4UNwh201QYU6dWT uxH2LdcuGYORwleLWH47qJEYWdTBFh4w818IRYrDaqSsOdgx2XKqwPaivscXvHbGNHCo n5WF8x/SFsZsAwHQnGxoY3bkAR7C5eQ/YT8K6wLpO6jQbtZYAczI/2p1E2uUCzwecflg 3YH1rznpnZVECqh/JD2N/u6rjM+I/3YwLzh7POa3nhuPKxMX5stDD2nGJv2omMEOTu61 atVlH26l+2tH+nucsfp4cbn2rIpLJR344KurFQQkYoXsm7IUSfndA6EyaY6ag1PI7cR2 EqRg== X-Gm-Message-State: AOJu0YwA1f6FNM5ySaYR/8OTcbvoujuAmKmwfOkn2oPhL7Xp6u8X8n6u YuP/xb8gTSt3xS4IrXHUZ60masIYf3A= X-Google-Smtp-Source: AGHT+IHXlcQzM4bQcFxkIPfDcBKj2BRgVff/UVCtObUR2r1p2RSys38wWhNsPTRCBNaIv0//6hn/Dw== X-Received: by 2002:a50:9b43:0:b0:54b:c09e:ff40 with SMTP id a3-20020a509b43000000b0054bc09eff40mr2852656edj.8.1702311485547; Mon, 11 Dec 2023 08:18:05 -0800 (PST) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id q26-20020a50aa9a000000b0054c6261d245sm4017253edc.37.2023.12.11.08.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 08:18:05 -0800 (PST) Message-ID: <68e113f5-bc8c-49ae-889a-9c2c00748f12@gmail.com> Date: Mon, 11 Dec 2023 17:18:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com Subject: Re: Ping: [PATCH] Add a late-combine pass [PR106594] Content-Language: en-US To: gcc-patches@gcc.gnu.org References: From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, I have tested the new pass on riscv64 and while it did exhibit some regressions, none of them are critical. Mostly, test expectations will need to be adjusted - no new execution failures. As mentioned in the initial discussion it does help us get the behavior we want but, as of now, seems to propagate/combine a bit more than I expected. I suppose a bit of register-pressure tuning will still be required in order to get the behavior we want. It will also force us to properly set latencies/costs for the register-file-crossing vector instructions. All in all I would be very glad to see this get in :) Regards Robin